Re: [PATCH v2] usb: mtu3: wait for TX FIFO to drain before disconnect

[Carlo Caione via U-Boot <u-boot@lists.u-boot-project.org>]

On Mon Jul 20, 2026 at 2:20 PM CEST, Marek Vasut wrote:
> On 7/20/26 9:32 AM, Carlo Caione wrote:
>
> Hello Carlo,
>
>>>> @@ -261,8 +290,14 @@ void mtu3_ep_stall_set(struct mtu3_ep *mep, bool set)
>>>>    		set ? "SEND STALL" : "CLEAR STALL, with EP RESET");
>>>>    }
>>>>    
>>>> -void mtu3_dev_on_off(struct mtu3 *mtu, int is_on)
>>>> +int mtu3_dev_on_off(struct mtu3 *mtu, int is_on)
>>>>    {
>>>> +	int ret = 0;
>>>> +
>>>> +	/* QMU completion may precede transmission from the TX FIFO. */
>>>> +	if (!is_on)
>>>> +		ret = mtu3_wait_for_tx_fifo_empty(mtu);
>>>
>>> Shouldn't this bail early on ret != 0 ?
>> 
>> No, disconnect must still be forced after resetting a timed-out endpoint
>> (we still want to disconnect it, even forcefully)
> Can you please include a code comment that clarifies this ?

Done in V3 already: https://lore.kernel.org/all/20260720-ccaione-upstream-mtu3-tx-fifo-drain-v3-1-45c0e072b64a@baylibre.com/

thanks,

--
Carlo Caione