From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E8EB1EDA0F; Tue, 21 Jul 2026 12:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784637437; cv=none; b=Sk1vadky0V3zo3JKrUetKXqVjWbavDL6GzECYFQ4Gm3aAJ6faRWBk0TF+qiDjsXQb1j4B28qpo6rOnTSundD9S0rWh5BGQbLZswrgWKYXrER6E+3f0J3w/gQkrwoMpCi9oLISsYTB4gYYvJLzw9wnazKvWXlgB+TbLh0HLpmg1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784637437; c=relaxed/simple; bh=U4fj03Py4P0EnSAJIKgGip8KPplL7G7WTFxOCjzlgtU=; h=Content-Type:Date:Message-Id:Cc:Subject:From:To:In-Reply-To: References:MIME-Version; b=DbmdSYYS6RPAo15Suo7ZMaeCpIPrOaX+MSJVAHI40xk2XixJGuaQ+U/7potPwGDtxsYTLQbW0+ZuWhiWhTUdhhH6zrOloc+XkD/3ShXh2YLsPXwQnZr3mHsJKnAkYZReNnV+1HFDq5BTiJcy3QZCwWNi9AJHJV6XVtraYplISPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=ddw+IOn4; arc=none smtp.client-ip=54.204.34.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="ddw+IOn4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1784637419; bh=Q3WVCZdvhuzyHyhwodqX72fDjFGew7fzT/sycGPfkAg=; h=Date:Message-Id:Subject:From:To:MIME-Version; b=ddw+IOn4Z1IxGNo827TTOcA+zo+Q+to9R0k3LDcjnGaUHh/cDeZIKYgyBCA42Ar4B 8sXAufBFF8gOxzFRuFbFHlKcYFtKDrObT/WJjwTMJDaNoeucGmSbTztMG/HF1tJJNd fIRIAdt74fiza5NInm3MyPo7IijxG6dMTQPCXJTc= X-QQ-mid: zesmtpgz3t1784637417te9d389f1 X-QQ-Originating-IP: njHsgAYR90QJ38EFUoM52TrKnqiRhrriBDg10lgkAhg= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 21 Jul 2026 20:36:55 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 6462590554883498070 EX-QQ-RecipientCnt: 15 Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Jul 2026 05:36:54 -0700 Message-Id: Cc: , , , , "Krzysztof Kozlowski" , , "Troy Mitchell" Subject: Re: [PATCH 1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs From: "Troy Mitchell" To: , "Michael Turquette" , "Stephen Boyd" , "Brian Masney" , "Yixun Lan" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" In-Reply-To: <20260717073330.3CC8B1F000E9@smtp.kernel.org> References: <20260717-k3-clk-fix-i2s-v1-0-e95001a692ee@linux.spacemit.com> <20260717-k3-clk-fix-i2s-v1-1-e95001a692ee@linux.spacemit.com> <20260717073330.3CC8B1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: ObFHHlrAm4404UbD/nd2kVy19hy8HzuKctFHMY3TlPCPjWmoA/iZ7O31 piVS9BHD/aI0WPsvAE+q0ntZ2x0XfgsKnfOSV3Z/xfmEXsBkIy+ARqldXXbZfp3XQpQHoz+ n6x0DVD5JyZiZ4ua/qSyVG3KNs6pkNEwAd0suz+Nje8CGGpuMeMqynRrTzfxPez8X1Uqrza fJTK44e3RaHm6JVC4gNCRZ12LUItlCuE50Wc6/CoApZyPqVXkJZ65eh70TUzX1WfA0SC5B6 VmXBWYjR+6WY+MNtYcAaLXHqOleCVeE0YbF83Cmw3r6i0Ak/I6+InVVsonke9Gf3+FGQ2Dn Ow8dLjtTxONTGFxM16hGuqfD9Wk1Oz/JyTKY8x5BKPbCc+TYqdtmLi3X1eOUzXcDe67nC0k /VImbbZNF6IBRXjRAENwH4OYmcFhsjoEOjo6t+N6cAAORUUOq0CVzC9PZGkHwKx7bWHsd6a cOUFHcv2qwsyO4X8iEGofcO9KGVPhrTteMExZLpucP+GKlhFAbfTandGc+dUoT1u8SmjjE0 JnV9C0iicv2vWAvQNcmtOyJDrPC/lBzYO1cLog7USN+gACnxOhqEW6bDMwauBXV8/11yjw9 hzuiChp9d9Fw+xDM5olQ/b927b5Tdy8UQOn6hWCIZyzyg32xGm+ZYXZhYbTTcJGGsyg4/UL Z0Vq6URyDaH5IWrjc2ka8GmPCJxQBSu2fkxKF3HQnZ510XZG1HoR8tkE9A1CHiLgM6nozzI ml0U3gH904yVlHMOPrvBjSxlhSlaEH6a9VSDACi/c9F2M+f/HQdsosWJ8uGd/oT69Qa9BqA RXzNg6JdrbMpILMs69rDqwSB4wksIPW+8txYBHRwwpvu9QrMnEAxAykOKAf8PUur+84cYPz mSbWGLNdldlVwjy6P68BuQHEeoKcknRf8Vq4y1E2XC9LMduOD89wGE6gCD3CSbEEkBUBgFi 0E8FJJdbN4sb9tb7t20gSiTUbPJ8B02W7fuLoB4hf3NUqgvWBdnF8ZnuuH7EDfuF9HNhlLV sNe1yeOwGkWvwcwxdRKDi5HCOK30KBTO+VCMWaPMPJhkxZuRG8qtITcpizcNM= X-QQ-XMRINFO: Mp0Kj//9VHAxzExpfF+O8yhSrljjwrznVg== X-QQ-RECHKSPAM: 0 > CLK_MPMU_I2S1_SYSCLK keeps its existing ID (47) but will be repointed to > the real per-instance i2s1 clock in a subsequent patch. No in-tree user > references this ID so the semantic change is contained. > > [Severity: Medium] > Does the commit message reference the correct clock ID here? > > Looking at include/dt-bindings/clock/spacemit,k3-clocks.h, 47 is actually > assigned to a different clock: > > #define CLK_MPMU_I2S1_SYSCLK 34 > ... > #define CLK_MPMU_I2S2_SYSCLK 47 > > Could the commit message be updated to reflect the accurate existing ID for > CLK_MPMU_I2S1_SYSCLK? Good catch. CLK_MPMU_I2S1_SYSCLK has ID 34, while ID 47 belongs to CLK_MPMU_I2S2_SYSCLK. I will correct the commit message in the next version. - Troy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C28AC4452F for ; Tue, 21 Jul 2026 12:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:To: From:Subject:Cc:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FOKsyk5ka8+7aCg15q8esJVWnUn8osrmUfScQqSOGHo=; b=I1v6POoEjU6r4b a1a77KixsE4SFKJq8zHUc/41Wyg5O66dF8xvNcVu8hMjlLtdgIGxJXaQjDQkeyq0KuRBGjKFysTV2 aIIdAtT35Ep8UIMcDspI1zaIyGDft4hisqXfzUXGszhgCXOa69fbt45kDvdelAc7FeGhduYeS7QPj Ono6sjG/NRqCLayxYGvtDU7NL1DB/GcmuCC9oHecqVYUo7U0PzA8VboKkdvJpxM8uqVUKYx40XWC1 5CPKtiF9JqrNgQQvIevFtyMvV00qIvirvNReervXbq6Ie8DyKms6YaF7hRB8FH3CuH1lSwrV7RHqx iny9JdsUjJsLj1irlGuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wm9jA-00000009R1C-0ctJ; Tue, 21 Jul 2026 12:37:40 +0000 Received: from smtpbgbr2.qq.com ([54.207.22.56]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wm9j5-00000009Qzx-3uir for linux-riscv@lists.infradead.org; Tue, 21 Jul 2026 12:37:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1784637419; bh=Q3WVCZdvhuzyHyhwodqX72fDjFGew7fzT/sycGPfkAg=; h=Date:Message-Id:Subject:From:To:MIME-Version; b=ddw+IOn4Z1IxGNo827TTOcA+zo+Q+to9R0k3LDcjnGaUHh/cDeZIKYgyBCA42Ar4B 8sXAufBFF8gOxzFRuFbFHlKcYFtKDrObT/WJjwTMJDaNoeucGmSbTztMG/HF1tJJNd fIRIAdt74fiza5NInm3MyPo7IijxG6dMTQPCXJTc= X-QQ-mid: zesmtpgz3t1784637417te9d389f1 X-QQ-Originating-IP: njHsgAYR90QJ38EFUoM52TrKnqiRhrriBDg10lgkAhg= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 21 Jul 2026 20:36:55 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 6462590554883498070 EX-QQ-RecipientCnt: 15 Date: Tue, 21 Jul 2026 05:36:54 -0700 Message-Id: Cc: , , , , "Krzysztof Kozlowski" , , "Troy Mitchell" Subject: Re: [PATCH 1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs From: "Troy Mitchell" To: , "Michael Turquette" , "Stephen Boyd" , "Brian Masney" , "Yixun Lan" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" In-Reply-To: <20260717073330.3CC8B1F000E9@smtp.kernel.org> References: <20260717-k3-clk-fix-i2s-v1-0-e95001a692ee@linux.spacemit.com> <20260717-k3-clk-fix-i2s-v1-1-e95001a692ee@linux.spacemit.com> <20260717073330.3CC8B1F000E9@smtp.kernel.org> MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: MpO6L0LObisWp8Fdvp153dHVOrxO43BDAzAf9lw1P+hBYQqaPgGyMW+g d9SVm2T1W61ScaEhgVHZ2aTvUoEh1A94cVJDBpQWNH1vaPN1xfv7cojiipphv4evFgV9KBk IzOrIlSaDxKoCfq0jkn5WdkL9t5ihEuuLdu23Gs/AgQepOPBz8TtMXKGpUXUMaEg/o0MXYj b+WkaIOXtcCvNQaBBkcOFoJpmZ6pXYXttzVq6aImQEHAXNVCKHU2GHyJVKxzDf09smXjQ+Y UnTEtghmk2Z18uJyukHXzM6MWFe0UuY9ZZkhXHFHIoss5PjBRTj093vTQzreH1lk5rh9dBJ 2OmhnYgE4nlZbB6Kgm6h11TLdg8gYGV6w+hIYcTXKn/Q0Oj3X1kDHaOaH+QIcvYB6FkNvBB gsAQlN8AN4KP6+qnCLE5PtnUNGPFYUgwMUnEx8RT12j7/XAfS5/mU08fDKQnoD9I31UwxdE csYA2dwR9pdXvDT75soVS4jZfv4mW5Fz/Fs39kg7Ss6j+jNDFZuY2l3EwjFy3dw5lbLMfO8 3/j62SWkeAeJlYcV9cMaJOuetEGDy6i5JgtXiXCLpD9pZ22uiFTpWwdft248fWWoQ+tiW3j dO/qtorJvLyDr7XuSOXoz7jM5siUiJUWPEJtSg0/pr8mCw/IdYrjrVhiNFekhV+18wVOR2v 2+aQWUKhH+ZMeLsBkxhBHdMUGNcDtws41m8e6Za3y5u8lR9HLY4RLCVfCsn97nkXWq5tbKW KtgtJTuQgD+IvGmb3i/9bfqnuHYzm4QKZxBz/YRKGEtlXRcWKlBCX1d7E1IEWmz4N6V1kKb veiqGotT4qh2vVcwWxC40N4EF1NRfwRMU+xPOHPMQt5D9IIAQWypfOD8EKfnF6f5mPclKra 33v27ajhFXCUNpUFu/fDGxtarPQfoI1YdaEo8nsulpoH03pufc/MHx/Y2qISlihqroXq19N iQlct0ZBNFN0i3qS3JG8SfeAuY/IhnWm7gEuZ2I+hE1PTeFgMFAtniKhusZiePF5uY0wGZs frjQ4R1M3v1Z/u0/gFc26e9ZOnN/JPWTGneCcT9N21kfjCq5JQe/HzsVXZ6TY= X-QQ-XMRINFO: OWPUhxQsoeAVwkVaQIEGSKwwgKCxK/fD5g== X-QQ-RECHKSPAM: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260721_053737_495740_A6395FB9 X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > CLK_MPMU_I2S1_SYSCLK keeps its existing ID (47) but will be repointed to > the real per-instance i2s1 clock in a subsequent patch. No in-tree user > references this ID so the semantic change is contained. > > [Severity: Medium] > Does the commit message reference the correct clock ID here? > > Looking at include/dt-bindings/clock/spacemit,k3-clocks.h, 47 is actually > assigned to a different clock: > > #define CLK_MPMU_I2S1_SYSCLK 34 > ... > #define CLK_MPMU_I2S2_SYSCLK 47 > > Could the commit message be updated to reflect the accurate existing ID for > CLK_MPMU_I2S1_SYSCLK? Good catch. CLK_MPMU_I2S1_SYSCLK has ID 34, while ID 47 belongs to CLK_MPMU_I2S2_SYSCLK. I will correct the commit message in the next version. - Troy _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv