From: "Danilo Krummrich" <dakr@kernel.org>
To: "Deborah Brouwer" <deborah.brouwer@collabora.com>
Cc: "Daniel Almeida" <daniel.almeida@collabora.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Benno Lossin" <lossin@kernel.org>, "Gary Guo" <gary@garyguo.net>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<rust-for-linux@vger.kernel.org>, <boris.brezillon@collabora.com>,
<samitolvanen@google.com>, <work@onurozkan.dev>,
<acourbot@nvidia.com>, <lyude@redhat.com>,
<laura.nao@collabora.com>, <beata.michalska@arm.com>,
<alvin.sun@linux.dev>, <steven.price@arm.com>
Subject: Re: [PATCH v7 4/7] drm/tyr: add GPU virtual memory (VM) support
Date: Tue, 21 Jul 2026 19:26:18 +0200 [thread overview]
Message-ID: <DK4FBIWI47PQ.1J3WZDTDGL42X@kernel.org> (raw)
In-Reply-To: <20260713-fw-boot-b4-v7-4-afd8dc1494dd@collabora.com>
On Tue Jul 14, 2026 at 5:18 AM CEST, Deborah Brouwer wrote:
> + // dummy_obj is used to initialize the GPUVM tree.
> + let dummy_obj = gem::new_dummy_object(ddev).inspect_err(|e| {
> + pr_err!("Failed to create dummy GEM object: {:?}\n", e);
> + })?;
In quite a lot of places in this patch and the other patches, please don't use
pr_* primitives in drivers, please use dev_* instead.
next prev parent reply other threads:[~2026-07-21 17:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 3:18 [PATCH v7 0/7] drm/tyr: firmware loading and MCU boot support Deborah Brouwer
2026-07-14 3:18 ` [PATCH v7 1/7] drm/tyr: add resources to RegistrationData Deborah Brouwer
2026-07-14 3:18 ` [PATCH v7 2/7] drm/tyr: add a generic slot manager Deborah Brouwer
2026-07-14 3:26 ` sashiko-bot
2026-07-14 3:18 ` [PATCH v7 3/7] drm/tyr: add Memory Management Unit (MMU) support Deborah Brouwer
2026-07-14 3:30 ` sashiko-bot
2026-07-14 3:18 ` [PATCH v7 4/7] drm/tyr: add GPU virtual memory (VM) support Deborah Brouwer
2026-07-14 3:28 ` sashiko-bot
2026-07-21 12:55 ` Daniel Almeida
2026-07-21 12:58 ` Daniel Almeida
2026-07-21 17:26 ` Danilo Krummrich [this message]
2026-07-14 3:18 ` [PATCH v7 5/7] drm/tyr: add a kernel buffer object Deborah Brouwer
2026-07-14 3:26 ` sashiko-bot
2026-07-21 17:19 ` Daniel Almeida
2026-07-14 3:18 ` [PATCH v7 6/7] drm/tyr: add parser for firmware binary Deborah Brouwer
2026-07-14 3:28 ` sashiko-bot
2026-07-21 20:52 ` Daniel Almeida
2026-07-14 3:18 ` [PATCH v7 7/7] drm/tyr: add Microcontroller Unit (MCU) booting Deborah Brouwer
2026-07-14 3:34 ` sashiko-bot
2026-07-21 21:13 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK4FBIWI47PQ.1J3WZDTDGL42X@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=alvin.sun@linux.dev \
--cc=beata.michalska@arm.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=laura.nao@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.