All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Joshua Peisach" <jpeisach@ubuntu.com>
To: "Michail Tatas" <michail.tatas@gmail.com>,
	<louis.chauvet@bootlin.com>, <simona@ffwll.ch>,
	<melissa.srw@gmail.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <airlied@gmail.com>,
	<hamohammed.sa@gmail.com>, <maarten.lankhorst@linux.intel.com>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [PATCH] drm/vkms: Advertise PREMULTI blend mode
Date: Wed, 22 Jul 2026 10:40:22 -0400	[thread overview]
Message-ID: <DK56F0N1D7ZA.1IYP6RGCYDI3T@ubuntu.com> (raw)
In-Reply-To: <al1pElMQZsDfpAYI@michalis-linux>

On Sun Jul 19, 2026 at 8:17 PM EDT, Michail Tatas wrote:
> Since we only support pre-multiplied alpha blend mode,
> advertise that, otherwise validate_blend_mode_for_alpha_formats()
> will throw a WARN.
>
> Reported-by: syzbot+6245cb95ae707991bffa@syzkaller.appspotmail.com
> Signed-off-by: Michail Tatas <michail.tatas@gmail.com>
> ---
>
> syzbot link: https://syzkaller.appspot.com/bug?extid=6245cb95ae707991bffa
>
>  drivers/gpu/drm/vkms/vkms_plane.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
> index 68cb2a3335e6..a2e5ebee729a 100644
> --- a/drivers/gpu/drm/vkms/vkms_plane.c
> +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> @@ -246,6 +246,12 @@ struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev,
>  					  DRM_COLOR_YCBCR_BT601,
>  					  DRM_COLOR_YCBCR_FULL_RANGE);
>  
> +	/* Since our composer only supports pre-multiplied alpha,
> +	 * advertise only the PREMULTI blend mode.
> +	 */
> +	drm_plane_create_blend_mode_property(&plane->base,
> +					BIT(DRM_MODE_BLEND_PREMULTI));
> +
>  	if (vkms_config_plane_get_default_pipeline(plane_cfg))
>  		vkms_initialize_colorops(&plane->base);
>  

Hi,

Unfortunately, this still causes the warning on my machine. In my
config CONFIG_DRM_VKMS is not set.

-Josh

  reply	other threads:[~2026-07-22 14:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20  0:17 [PATCH] [PATCH] drm/vkms: Advertise PREMULTI blend mode Michail Tatas
2026-07-22 14:40 ` Joshua Peisach [this message]
2026-07-22 15:03   ` Joshua Peisach
2026-07-22 15:39 ` Louis Chauvet
2026-07-28 14:38   ` Pimyn Girgis
2026-08-05 12:51     ` Pimyn Girgis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK56F0N1D7ZA.1IYP6RGCYDI3T@ubuntu.com \
    --to=jpeisach@ubuntu.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=melissa.srw@gmail.com \
    --cc=michail.tatas@gmail.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.