From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB2B4156FA for ; Thu, 23 Jul 2026 09:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784797339; cv=none; b=cFoz02uaEztNWORrzNQlf4bpAfx040/9/QIQ5KLjklFTDeHMMKvrXx3YGCbZ8nP390utvNfyh0jUJgyT7YIJO57x7UYRQ85s3LEJadhePz3OZQYVY2gZWQarwzUl+ALw/Y9PvMSgArfOjWHKljrFdjVhdHOQ2ecrPPxggdFhSBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784797339; c=relaxed/simple; bh=4jVBs7ObQQC7fjydV/VV4ICVasHuLptyhflOAa6YSQs=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=T+62uF4UXng8WIrNSXqG9HQ/nlQU3XbayS7efxduYcDD48usbOUfAQCdlbB6IW1f8TllxYndmA4QlwdaEArEPcxNTFUSpqhpMxX/J0SA6Uq7d+C65zO4epXPx9hIqDPRYSa6q3VjXd9Ii0otR6FO400k66le0dg/Fk9g+TyPz9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=oYmHFakP; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="oYmHFakP" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1784797330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1PrK33UFnL51Yikk7HZvEthg4vpaBxc9dwwZV4cmtgs=; b=oYmHFakPdPtNeOnn7Mn+PFTTcil1Fls8CvNpv3K5nlbPtwcTVmeVzAV7Bvl7lyhnhvH5dE kZ0zBp6xdH+C3LLTbSKZswNmCpAZiMOzTrLcqxIK2LLUAopEfy/wwBLsZi6scpkCB9WB9u zCbdL7bYPNpz+2+GcEBVOMg/BxF9ZTiY8fikx9ajMOSqQvLj9LsslXTUQdUOMPyUhKRJ0Q MFTHVoDBv21bTzN/5Hs7+4VjKJJlswmVclcljHUNFHV0cdl/J28Q13U6RTFPZVWQ34nUR9 UahL+2Vao1t+OQftY+ywsrz/V8nGFAKqGxeHQ8cC1rRq1/q4v7tmeoLpfYwLpw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 23 Jul 2026 11:02:03 +0200 Message-Id: To: "Cristian Ciocaltea" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Chen-Yu Tsai" , "Samuel Holland" , "Dave Stevenson" , =?utf-8?q?Ma=C3=ADra_Canal?= , "Raspberry Pi Kernel Maintenance" , "Sandy Huang" , =?utf-8?q?Heiko_St=C3=BCbner?= , "Andy Yan" , "Algea Cao" , "Daniel Stone" , "Liu Ying" , "Phong LE" Cc: , , , , , Subject: Re: [PATCH v9 46/61] drm/rockchip: rk3066_hdmi: Advertise HDMI 1.4 capabilities X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20260723-dw-hdmi-qp-scramb-v9-0-4fb12ea22ac9@collabora.com> <20260723-dw-hdmi-qp-scramb-v9-46-4fb12ea22ac9@collabora.com> In-Reply-To: <20260723-dw-hdmi-qp-scramb-v9-46-4fb12ea22ac9@collabora.com> X-Migadu-Flow: FLOW_OUT Hi Cristian, On Thu Jul 23, 2026 at 3:35 AM CEST, Cristian Ciocaltea wrote: > Bridges using DRM_BRIDGE_OP_HDMI are now expected to also provide a > supported HDMI version. This is not yet enforced, but will become > mandatory once the migration to the new caps-based HDMI connector > initialization API is completed. > > The RK3066 HDMI TX supports HDMI 1.4a, as described in commit > f84d3d37b7fb ("drm: rockchip: introduce rk3066 hdmi"). However, the > driver does not currently enforce a maximum TMDS character rate, it only > filters non-CEA modes and excludes VIC 1 (640x480) via the .mode_valid > callback. > > Advertise HDMI 1.4 support for now so that modes exceeding the 340 MHz > TMDS limit are rejected by the core. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/roc= kchip/rk3066_hdmi.c > index f28d6a883e09..c080abe676c4 100644 > --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c > +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > @@ -14,6 +14,7 @@ > #include > =20 > #include > +#include > #include > #include > #include > @@ -712,6 +713,7 @@ rk3066_hdmi_register(struct drm_device *drm, struct r= k3066_hdmi *hdmi) > hdmi->bridge.type =3D DRM_MODE_CONNECTOR_HDMIA; > hdmi->bridge.vendor =3D "Rockchip"; > hdmi->bridge.product =3D "RK3066 HDMI"; > + hdmi->bridge.supported_hdmi_ver =3D HDMI_VERSION_1_3; Is this correct or should this be HDMI_VERSION_1_4 ? In the other 'Advertise HDMI N.M capabilities' patches, there is a (direct) match between the version mention in the commit summary and the supported_hdmi_ver property, but not here. Cheers, Diederik > =20 > hdmi->bridge.ddc =3D rk3066_hdmi_i2c_adapter(hdmi); > if (IS_ERR(hdmi->bridge.ddc)) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23446C531CB for ; Thu, 23 Jul 2026 09:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:Subject:Cc: To:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SCat/Rh1sm59lfhfxxkkLRsQHVywkvQknhizboiKbTg=; b=42hgULPV2ivH0h CxDMyM03BzVouyI2/fRq9RTsVncSpSVBMIwVhR/vpKJSfQ5V7vOdJW2fzVlKpF4IaQprWToCOiNWs rJS1b7EgXqBlUJDUxfz2ZCWjqWvGvPXv4mSeJmXgh9Swpd5hlZXgk1+q0GQ3Veotp2QtZNIhb5P+Y T+9hjDP8vWCwD13Y3UhKYVcT0sv0qjm8w4Nx6xDY9MpRuEI3bep23Ol1pWgR34aMEgunIfIvkm29P fRk3VKAcG6ZSFdAOS6R0cAdLgtcDOYKt1LlCOlfW6Wv5xyV8263CMJpRJmps5Kd7KQaobdVj9lE3M XpwMFRs6DVbDLsnRpZfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmpJy-0000000DnQN-04ku; Thu, 23 Jul 2026 09:02:26 +0000 Received: from out-171.mta0.migadu.com ([91.218.175.171]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmpJv-0000000DnPD-2yvw for linux-rockchip@lists.infradead.org; Thu, 23 Jul 2026 09:02:24 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1784797330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1PrK33UFnL51Yikk7HZvEthg4vpaBxc9dwwZV4cmtgs=; b=oYmHFakPdPtNeOnn7Mn+PFTTcil1Fls8CvNpv3K5nlbPtwcTVmeVzAV7Bvl7lyhnhvH5dE kZ0zBp6xdH+C3LLTbSKZswNmCpAZiMOzTrLcqxIK2LLUAopEfy/wwBLsZi6scpkCB9WB9u zCbdL7bYPNpz+2+GcEBVOMg/BxF9ZTiY8fikx9ajMOSqQvLj9LsslXTUQdUOMPyUhKRJ0Q MFTHVoDBv21bTzN/5Hs7+4VjKJJlswmVclcljHUNFHV0cdl/J28Q13U6RTFPZVWQ34nUR9 UahL+2Vao1t+OQftY+ywsrz/V8nGFAKqGxeHQ8cC1rRq1/q4v7tmeoLpfYwLpw== Date: Thu, 23 Jul 2026 11:02:03 +0200 Message-Id: To: "Cristian Ciocaltea" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Chen-Yu Tsai" , "Samuel Holland" , "Dave Stevenson" , =?utf-8?q?Ma=C3=ADra_Canal?= , "Raspberry Pi Kernel Maintenance" , "Sandy Huang" , =?utf-8?q?Heiko_St=C3=BCbner?= , "Andy Yan" , "Algea Cao" , "Daniel Stone" , "Liu Ying" , "Phong LE" Cc: , , , , , Subject: Re: [PATCH v9 46/61] drm/rockchip: rk3066_hdmi: Advertise HDMI 1.4 capabilities X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20260723-dw-hdmi-qp-scramb-v9-0-4fb12ea22ac9@collabora.com> <20260723-dw-hdmi-qp-scramb-v9-46-4fb12ea22ac9@collabora.com> In-Reply-To: <20260723-dw-hdmi-qp-scramb-v9-46-4fb12ea22ac9@collabora.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260723_020223_896513_D6092038 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Cristian, On Thu Jul 23, 2026 at 3:35 AM CEST, Cristian Ciocaltea wrote: > Bridges using DRM_BRIDGE_OP_HDMI are now expected to also provide a > supported HDMI version. This is not yet enforced, but will become > mandatory once the migration to the new caps-based HDMI connector > initialization API is completed. > > The RK3066 HDMI TX supports HDMI 1.4a, as described in commit > f84d3d37b7fb ("drm: rockchip: introduce rk3066 hdmi"). However, the > driver does not currently enforce a maximum TMDS character rate, it only > filters non-CEA modes and excludes VIC 1 (640x480) via the .mode_valid > callback. > > Advertise HDMI 1.4 support for now so that modes exceeding the 340 MHz > TMDS limit are rejected by the core. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > index f28d6a883e09..c080abe676c4 100644 > --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c > +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > @@ -14,6 +14,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -712,6 +713,7 @@ rk3066_hdmi_register(struct drm_device *drm, struct rk3066_hdmi *hdmi) > hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA; > hdmi->bridge.vendor = "Rockchip"; > hdmi->bridge.product = "RK3066 HDMI"; > + hdmi->bridge.supported_hdmi_ver = HDMI_VERSION_1_3; Is this correct or should this be HDMI_VERSION_1_4 ? In the other 'Advertise HDMI N.M capabilities' patches, there is a (direct) match between the version mention in the commit summary and the supported_hdmi_ver property, but not here. Cheers, Diederik > > hdmi->bridge.ddc = rk3066_hdmi_i2c_adapter(hdmi); > if (IS_ERR(hdmi->bridge.ddc)) _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip