All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hardik Kumar" <hardikxk@gmail.com>
To: phillip.wood@dunelm.org.uk, "Hardik Kumar" <hardikxk@gmail.com>,
	git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
	"René Scharfe" <l.s.r@web.de>, "Patrick Steinhardt" <ps@pks.im>,
	"Pablo Sabater" <pabloosabaterr@gmail.com>
Subject: Re: [PATCH v4] utf8: replace utf8_strwidth todo with descriptive comment
Date: Tue, 28 Jul 2026 22:34:12 +0530	[thread overview]
Message-ID: <DKAD8F8VLOMQ.3KKRGKVG6UT02@gmail.com> (raw)
In-Reply-To: <c8fb2eba-c1c8-4f59-b467-e6d4766623d8@gmail.com>

On Tue Jul 28, 2026 at 9:11 PM IST, Phillip Wood wrote:

> The last sentence does not really capture the reasons given in the 
> message of the commit that added this comment. If you haven't done so 
> already you should read it - see 937b71cc8b (utf8: fix overflow when 
> returning string width, 2022-12-01). The fundamental reason to call 
> cast_size_t_to_int(), rather than relying on an implicit conversion to 
> the return type, is not about changing signatures, it is about avoiding 
> an overflow that caused git to crash.

I did check that commit before. My attempt at explaining the reason
wasn't quite right. I have improved it in the next patch.

Thanks for the review.
Hardik

  reply	other threads:[~2026-07-28 17:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-26 12:34 [PATCH] change utf8_strwidth() return type to size_t Hardik Kumar
2026-07-26 13:41 ` René Scharfe
2026-07-26 15:50   ` Hardik Kumar
2026-07-26 14:52 ` Pablo Sabater
2026-07-26 15:52   ` Hardik Kumar
2026-07-26 19:57   ` [PATCH v2] utf8: use size_t for string width methods and callee sites Hardik Kumar
2026-07-27  0:06     ` Junio C Hamano
2026-07-27  4:02       ` Junio C Hamano
2026-07-27  6:42         ` Hardik Kumar
2026-07-27  1:06     ` Pablo Sabater
2026-07-27  6:40       ` Hardik Kumar
2026-07-27  6:59 ` [PATCH v3] utf8: make utf8_strwidth() and utf8_strnwidth() return size_t Hardik Kumar
2026-07-27  7:04   ` Hardik Kumar
2026-07-27 12:51   ` Phillip Wood
2026-07-27 14:55     ` Junio C Hamano
2026-07-27 16:20       ` Hardik Kumar
2026-07-27 19:52         ` Junio C Hamano
2026-07-27 16:13     ` Hardik Kumar
2026-07-27 21:15 ` [PATCH v4] utf8: replace utf8_strwidth todo with descriptive comment Hardik Kumar
2026-07-28 15:41   ` Phillip Wood
2026-07-28 17:04     ` Hardik Kumar [this message]
2026-07-28 18:24     ` Junio C Hamano
2026-07-28 17:02 ` [PATCH v5] " Hardik Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKAD8F8VLOMQ.3KKRGKVG6UT02@gmail.com \
    --to=hardikxk@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    --cc=pabloosabaterr@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.