From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F31D43DA7F3 for ; Wed, 29 Jul 2026 09:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.194.254.142 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785316465; cv=none; b=YQk7mY2+BfVnTgfbRJPgIpAJzerz3ad1pdz55TsrcQe2VcaBfSjGrD+eZggaNQICNPgiysZsfbmdw5wRr3Cyyv/166hlyrxVrNoT2dg+M2nqranknm7vaYdn4QBKrKQqRduTLzpp63Pk9C19anGR8dd0hk2hA5X181yqr8AYG2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785316465; c=relaxed/simple; bh=7dQJOLYN/AMcn00lyTExvQ2yf6auzhnjf1GDAS+h8Qg=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=sKqGEOjVPj93+RHMTq3wJryKZ4VqcsSL0XeOuTfIveWTGxGy9N+/VOCsoINnPpmIRyVmOcO7NNlLUalVZ8j0NhpHsi2cKpgkhXCk/ajbC+tByafxFdOqjA00v8JjJb9SvCk7WnICC5XqcG/HnLig0O2meHmrBaLrCThRInb8A44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=UqH1d/0T; arc=none smtp.client-ip=18.194.254.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="UqH1d/0T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1785316457; bh=7dQJOLYN/AMcn00lyTExvQ2yf6auzhnjf1GDAS+h8Qg=; h=Mime-Version:Date:Message-Id:Subject:From:To; b=UqH1d/0TgC+l78WYVDHiRncKlC9aEt3cT+oE4U3kv8R7xwcpSiGZ4yVUQKltjpPja 5rdFZWbLsCGuz4Qp11v5OuNf/7xikmiNEjuLC/Ml6N0+GCOI86iUpMqebxGFyPyk+r HfL/hhnp2JhSHXdpstO4C1L54hbcWkJfWDjKg7wE= X-QQ-mid: zesmtpgz5t1785316453t920e2043 X-QQ-Originating-IP: zAlwTsMr81y+gJMiR91lCYUcBGOKHctjS3NDk86hNXY= Received: from localhost ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 29 Jul 2026 17:14:11 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 7786942154255255945 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Jul 2026 17:14:11 +0800 Message-Id: Cc: "frank.binns" , "robh" , "krzk+dt" , "conor+dt" , "dlan" , "dri-devel" , "devicetree" , "linux-kernel" , "linux-riscv" , "spacemit" Subject: Re: [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu From: "Baihui Liang" To: "Krzysztof Kozlowski" X-Mailer: aerc 0.17.0 References: <065a229b-e6a8-4cce-8725-9c2e19c8f463@kernel.org> In-Reply-To: <065a229b-e6a8-4cce-8725-9c2e19c8f463@kernel.org> X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: ORqNQdnYjakCHXgNrmTcfxnv4EWQVlw+GuaL4A3WExIvph/YknP2M2El RlKoRwFYZC+0fSDiLO76QChlvH4txp/I6KteFIJTtb4OxFnfP5eoAjz1TYDroCNMj+r5WhB Nm53f8qgGaHpZUHpntMhLC1nwmgVPR7892K7y0vFWXpCKJ8ZkBzc6GbqdFVO0SYaKNOLijB 2fO1EI8iE8IukBWHgZFX5RyscZRDKqwWU3zMF1XP4XhEyEXNLimDd2IcJFciRwcmzBZddmJ itFoMX9pDFXpnstj+5VFoSo0rbKGKAnZfFSY8+t/L3NdHOTteZ1lW1RJIlBs6eR83UlE6J4 jOKM8EMLKi7EaE+XIy+700wOJp4yqCqdNlxMjzVhsp8TV5F4ecylByOQSkJQEu4RXtXgL8s VUq+80Hin+lUYCyefv9aBDeLdmvLXGfPZ3Loc0em2k0USlDkp5cJ1ZgIPh+GNvgNy4aKqxC NEAvqM8QFGGg8NzQshMPBIHxEClC1iQWNxvEVWO3QNofYPrhfeLWxqZgOB8JPfMrSASxso9 o52bsfEgUze/crCw0G5Th7OavL788+NIVUOImJD5FV0Pz0SFtHqUgyHDT3cwL6wbhul06Ky +LW8Vo/IfmpFF6NTaCWX6Qow5Bsz2dayF9gFmsNcJhXllg6F3IfyIzhIFcbl/LDnbhsMGi7 yt/zAqBpFF5pJr8U+KTPxv12JfE0+lWahSV1t1g25DJcZFJKu+N0qnuwGZzgxEnKR4C2A/u eMCz/pLNFHREiS7fy1bodjwj1dcQIMiWWAfK+qryhZM6Doh1VD13gd+cpSbK4OMs4DxLxRx ec7wobMAiBr69Ztix/0DLFAK2+d76TygGgssPKjG9oKLkKVUUlyymYHrGey2jgG3wx7X7iS oITKVj9lcYdswfWwHG6hPg7GQMOUvL8rhxFwgeJ6kB5VKO6xe6UI08+RzK8B2yZQFnK97Zt rbSl3m6qhgcCMH6zsmxbT5QiupqF64ZaIuj8uUEpZMddUiedfFg3TEJs51YmVt+iAhPnJIJ p0uySSf5sNVL8Dkyl8mtpi0RF8L21fHEecgMkDvQ== X-QQ-XMRINFO: MSVp+SPm3vtSI1QTLgDHQqIV1w2oNKDqfg== X-QQ-RECHKSPAM: 0 On Wed Jul 29, 2026 at 3:57 PM CST, Krzysztof Kozlowski wrote: > On 29/07/2026 09:46, Baihui Liang wrote: > > On Tue, Jul 28, 2026, Krzysztof Kozlowski wrote: > > > > [...] > > > > spacemit,k3-gpu is added to the existing ti,am62-gpu/ti,am62p= -gpu/ > > > > ti,j721s2-gpu "if" block that restricts clocks to a single en= try, > > > > since K3 has the same single-clock requirement. It does not m= atch any > > > > "if" block that constrains power-domains, so that property fa= lls back > > > > > > I don't get this explanation. Are you explaining what the patch is= doing > > > or explaining WHY you did this that way? > >=20 > >=20 > > That paragraph was describing schema mechanics, which does not belong i= n > > a commit message. v4 will drop it and state only the hardware facts: th= e > > K3 integration of the BXM-4-64 has a single "core" clock, and it has no > > software-controllable GPU power domain. > >=20 > >=20 > > > > to this schema's general constraints, where it is optional. T= his > > > > leaves room for a power-domains provider to be added later wi= thout a > > > > further binding change, should one ever be modelled in Linux = for this > > > > SoC. > > > > > > No, you need to provide constraints now. Please read carefully > > > writing-bindings. > >=20 > >=20 > > Understood. spacemit,k3-gpu currently matches no power-domains "if" > > block, so it falls back to the top-level 1-2 domains with > > power-domain-names "a"/"b". That would let a K3 DT with two power > > domains pass validation, which does not describe this hardware. v4 will > > add an explicit "if" block: > >=20 > >=20 > >     - if: > >         properties: > >           compatible: > >             contains: > >               const: spacemit,k3-gpu > >       then: > >         properties: > >           power-domains: false > >           power-domain-names: false > > I understand only half of this. Please fix your email client. > > And why this reply misses reply-to header which connects it to proper > thread? How am I supposed to find the thread now, among 200 I received > yesterday? Sorry -- that went out through a webmail client which sent HTML, so the quoting and the YAML indentation were destroyed, and it composed a new message instead of replying in place, which is why it lost the thread. I have switched to git send-email over our own SMTP; this reply should be plain text and properly threaded. > So your name is presented here as "Baihui Liang" then why do you use > some fake company name? liangbaihui@linux.spacemit.com is my real work address at SpacemiT. It is now sent through the company's own mail server. > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D4A5C54F52 for ; Wed, 29 Jul 2026 09:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RQzJxIwnmcmv4Tw30PUB3Dxtx6TsJfN4XbX3jMUGM04=; b=488uKvsfjKG+Ta UqD6rsJ83HWHjuBUmqoQGYcowWi2I2GsE/gm0KhDadjpTNhRefrrvvXQln38kFtXOV0zd9tNET61e qU3Awv8mdQhGuHGGC8irqUglbs/jRbfUw7VXyGz3XVv2PrJ0avVn0c7bLHuIh+ENZIl5E0EqR7Ol8 4B5BoKMkvuxfKFhY+9busZNPd7U4j6RWiYnqld7T+u35jfozkinmZI7NWdqE4OFEexFq+Rsy04snR USn65U6pKcAfUgnWqgu8kn98Mgqkn+KUkio7//aYNdK9TbEkwT2BPMGsjqyfNmyvjto9bgOv6zd+9 Q/UsB/Dc1x6O1A+dS1qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wp0Nd-00000007L3E-2H27; Wed, 29 Jul 2026 09:15:13 +0000 Received: from smtpbgeu1.qq.com ([52.59.177.22]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wp0NV-00000007Kya-3ecy for linux-riscv@lists.infradead.org; Wed, 29 Jul 2026 09:15:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1785316462; bh=7dQJOLYN/AMcn00lyTExvQ2yf6auzhnjf1GDAS+h8Qg=; h=Mime-Version:Date:Message-Id:Subject:From:To; b=t+rz80j6QvUXPZ3fax4An8udlSlIJg8WIEQfzxtYlPImTYt48OeSN+A6zRPRwgRr1 Y67L3RDsYtftIUfk3xMiNHw8uVGV6sdAiSKbnoyiwzEfILt8o82Onskd/Uqc7XBNhy C/wOWZzHCtDkiNeOzICYpJja5orIm/SUE4AiHHhI= X-QQ-mid: zesmtpgz5t1785316453t920e2043 X-QQ-Originating-IP: zAlwTsMr81y+gJMiR91lCYUcBGOKHctjS3NDk86hNXY= Received: from localhost ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 29 Jul 2026 17:14:11 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 7786942154255255945 Mime-Version: 1.0 Date: Wed, 29 Jul 2026 17:14:11 +0800 Message-Id: Cc: "frank.binns" , "robh" , "krzk+dt" , "conor+dt" , "dlan" , "dri-devel" , "devicetree" , "linux-kernel" , "linux-riscv" , "spacemit" Subject: Re: [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu From: "Baihui Liang" To: "Krzysztof Kozlowski" X-Mailer: aerc 0.17.0 References: <065a229b-e6a8-4cce-8725-9c2e19c8f463@kernel.org> In-Reply-To: <065a229b-e6a8-4cce-8725-9c2e19c8f463@kernel.org> X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: NiFdmnmiW14nHyLZW49OFnOnrQv7pEUGBojWfLnJ5yyoCmLXC9cz7V5p xGYy4V4aS2FXmrhIlarC0KUF4HW/Ytv84XSJOMeZxZixfipGOyrmKSZ0Tue1w0gJyngmx6Y tMcExDPFYoORhVJDscoUyzklc9rhuDteR8z7ZNybSv6rgXSl4VoyKNSa6vPwUY/OTP3Vfnv GBsI0s3u1Wb3WB7VN0h97oSUuP+mijAVdiHXU9pci7XErPtzuEAl5Zx32vLQLMnRHK42x3B aTqPBaRnb3tsSfZBdjafuAS3ARLHlxjNE+Q+avYxEomNF9cN2OP6loWP3URpcOVHdwca5tF fZkU6wL8uQKaSHqPieiSMnJOAEBMIDvQ2dUtjRkMGAqtGDY34Q4lC8aC/z/Ol1Y2DxaCEFe PXqK8EBPQh/BXyKqwJs+IIqyh8HnvreNpR2PHJV4rqkzAoPg+XTnZNtRC74Sie+GFO7qzYI h1zslLcCeASZ4re6kWEC9sf7TdCvYKnef94EFvaXVVhmdHmAbd/6MMf9VDevrTULRoFJxMH j+szNkMzHCGz52H07E15GY+aj0iAOAlhEfNXvCJrRErXeVXs9KboV4mION+I/BCy6g2/gRR lxl8bYIF65zW9JgtIQbjTwU1nRicBCzIZABF4XQZ49g1MR18T9b5K3v+rb8r+k/UJ7G53jP p4cRLEXMj+XvJnuXsgVK18HtNJBFCK7cJKnCBsKKvMIHDj5IGEfju4fY9Dvx/JVC1VzjIyk mPnTTGHnwCw3p6fbrl+wnZCrOLhqPb/lt1fPG64stuqxtTQQasokD53eAm8BORRhe/9TkHk nltwMblDW6a+Wi1nGCQ9dY9GrsP0xibn+Tlit9DKF/YxagcV8cBRe3lo/ENzWdME60JPxrK vcBHl51DDsv/tjSAgqGmt0sujy/Gk4e45lSvCbc3tQ5y2tWy1tqFymHwDZKwJJUGaNJ2QFf JJCCaIhPK2/Hwc7xF71hL8Ks1eJ+AV9wlboPg5K3sdh0WURQFjnv60o/QG8D/cTJFFWrbi/ vy8CYeTuXZqD8LPTKQiPysHz7jrfpOdgKb2/caUg== X-QQ-XMRINFO: M/715EihBoGS47X28/vv4NpnfpeBLnr4Qg== X-QQ-RECHKSPAM: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260729_021506_743667_D3328C05 X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed Jul 29, 2026 at 3:57 PM CST, Krzysztof Kozlowski wrote: > On 29/07/2026 09:46, Baihui Liang wrote: > > On Tue, Jul 28, 2026, Krzysztof Kozlowski wrote: > > > > [...] > > > > spacemit,k3-gpu is added to the existing ti,am62-gpu/ti,am62p-gpu/ > > > > ti,j721s2-gpu "if" block that restricts clocks to a single entry, > > > > since K3 has the same single-clock requirement. It does not match any > > > > "if" block that constrains power-domains, so that property falls back > > > > > > I don't get this explanation. Are you explaining what the patch is doing > > > or explaining WHY you did this that way? > > > > > > That paragraph was describing schema mechanics, which does not belong in > > a commit message. v4 will drop it and state only the hardware facts: the > > K3 integration of the BXM-4-64 has a single "core" clock, and it has no > > software-controllable GPU power domain. > > > > > > > > to this schema's general constraints, where it is optional. This > > > > leaves room for a power-domains provider to be added later without a > > > > further binding change, should one ever be modelled in Linux for this > > > > SoC. > > > > > > No, you need to provide constraints now. Please read carefully > > > writing-bindings. > > > > > > Understood. spacemit,k3-gpu currently matches no power-domains "if" > > block, so it falls back to the top-level 1-2 domains with > > power-domain-names "a"/"b". That would let a K3 DT with two power > > domains pass validation, which does not describe this hardware. v4 will > > add an explicit "if" block: > > > > > >     - if: > >         properties: > >           compatible: > >             contains: > >               const: spacemit,k3-gpu > >       then: > >         properties: > >           power-domains: false > >           power-domain-names: false > > I understand only half of this. Please fix your email client. > > And why this reply misses reply-to header which connects it to proper > thread? How am I supposed to find the thread now, among 200 I received > yesterday? Sorry -- that went out through a webmail client which sent HTML, so the quoting and the YAML indentation were destroyed, and it composed a new message instead of replying in place, which is why it lost the thread. I have switched to git send-email over our own SMTP; this reply should be plain text and properly threaded. > So your name is presented here as "Baihui Liang" then why do you use > some fake company name? liangbaihui@linux.spacemit.com is my real work address at SpacemiT. It is now sent through the company's own mail server. > Best regards, > Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv