All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>
Cc: <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/heaptrack: new package
Date: Wed, 05 Aug 2026 18:05:47 +0200	[thread overview]
Message-ID: <DKH501Y6N1NZ.1HTLE63ORQKA5@bootlin.com> (raw)
In-Reply-To: <amzvreeFgp0eJyM4@windsurf>

Hi Thomas,

thanks for reviewing!

On Fri Jul 31, 2026 at 8:59 PM CEST, Thomas Petazzoni wrote:
> Hello,
>
> On Fri, Jul 31, 2026 at 07:25:35PM +0200, Luca Ceresoli wrote:
>
>> diff --git a/package/heaptrack/Config.in b/package/heaptrack/Config.in
>> new file mode 100644
>> index 000000000000..ea54195c9318
>> --- /dev/null
>> +++ b/package/heaptrack/Config.in
>> @@ -0,0 +1,26 @@
>> +config BR2_PACKAGE_HEAPTRACK
>> +	bool "heaptrack"
>> +	depends on BR2_INSTALL_LIBSTDCPP
>> +	depends on BR2_LINUX_KERNEL
>
> You also need to replicate the "depends on" the things you select, so:
>
> 	depends on BR2_TOOLCHAIN_HAS_THREADS # boost, libunwind, elfutils
> 	depends on BR2_USE_WCHAR # boost, elfutils
> 	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
> 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libunwind
> 	depends on !BR2_STATIC_LIBS # libunwind, elfutils
>
> Also, I'm curious about the BR2_LINUX_KERNEL dependency. heaptrack
> builds its own kernel modules?

Nope, my mistake.

v2 incoming with that removed, plus the various changes you suggested
including a runtime test case.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-08-05 16:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 17:25 [Buildroot] [PATCH] package/heaptrack: new package Luca Ceresoli via buildroot
2026-07-31 18:59 ` Thomas Petazzoni via buildroot
2026-08-05 16:05   ` Luca Ceresoli via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKH501Y6N1NZ.1HTLE63ORQKA5@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.