Re: [PATCH v3 4/7] riscv: milkv_duo: Use upstream devicetree

["Junhui Liu" <junhui.liu@pigmoral.tech>]

Hi Zhuxu,

On Thu Aug 6, 2026 at 8:13 PM CST, Zhuxu Ran wrote:
> Switch Milk-V Duo to the upstream CV1800B devicetree by enabling
> CONFIG_OF_UPSTREAM and selecting sophgo/cv1800b-milkv-duo.
>
> The upstream devicetree keeps the Ethernet MAC disabled and does not
> describe the CV1800B SPIF controller. Add U-Boot overrides to preserve
> the existing networking and SPI NOR support.
>
> Signed-off-by: Zhuxu Ran <zhuxu_ran@zohomail.com>
> ---
>  arch/riscv/dts/cv1800b-milkv-duo-u-boot.dtsi | 36 ++++++++++++++++++++++++++++
>  board/sophgo/milkv_duo/MAINTAINERS           |  1 +
>  configs/milkv_duo_defconfig                  |  3 ++-
>  3 files changed, 39 insertions(+), 1 deletion(-)
>

[...]

> diff --git a/board/sophgo/milkv_duo/MAINTAINERS b/board/sophgo/milkv_duo/MAINTAINERS
> index 651a0592f7a..a6ff5585240 100644
> --- a/board/sophgo/milkv_duo/MAINTAINERS
> +++ b/board/sophgo/milkv_duo/MAINTAINERS
> @@ -4,3 +4,4 @@ S:	Maintained
>  F:	board/sophgo/milkv_duo/
>  F:	configs/milkv_duo_defconfig
>  F:	doc/board/sophgo/milkv_duo.rst
> +F:	arch/riscv/dts/cv1800b-milkv-duo-u-boot.dtsi

How about sorting these alphabetically?

> diff --git a/configs/milkv_duo_defconfig b/configs/milkv_duo_defconfig
> index f1f3930564b..9d6b80362d5 100644
> --- a/configs/milkv_duo_defconfig
> +++ b/configs/milkv_duo_defconfig
> @@ -4,7 +4,8 @@ CONFIG_SYS_MALLOC_F_LEN=0x8000
>  CONFIG_NR_DRAM_BANKS=1
>  CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>  CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x82300000
> -CONFIG_DEFAULT_DEVICE_TREE="cv1800b-milkv-duo"
> +CONFIG_DEFAULT_DEVICE_TREE="sophgo/cv1800b-milkv-duo"
> +CONFIG_OF_UPSTREAM=y
>  CONFIG_SYS_LOAD_ADDR=0x80080000
>  CONFIG_IDENT_STRING="milkv_duo"
>  CONFIG_TARGET_MILKV_DUO=y

-- 
Best regards,
Junhui Liu