From: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>
To: <sashiko-reviews@lists.linux.dev>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>
Cc: <conor+dt@kernel.org>, <devicetree@vger.kernel.org>, <robh@kernel.org>
Subject: Re: [PATCH v5 1/4] dt-bindings: iio: light: veml6030: add veml6031x00 ALS series
Date: Fri, 07 Aug 2026 16:34:23 +0200 [thread overview]
Message-ID: <DKISB5L2MJXM.S5JH6EXSRJM2@gmail.com> (raw)
In-Reply-To: <20260807140640.80DF61F000E9@smtp.kernel.org>
On Fri Aug 7, 2026 at 4:06 PM CEST, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The multiline `title` string in the YAML bindings lacks proper indentation on its continuation line, resulting in a fatal YAML syntax error.
> --
>
> --- Patch [1]: [PATCH v5 1/4] dt-bindings: iio: light: veml6030: add veml6031x00 ALS series ---
> commit 8d68b2e616d3ddf21759545fea44ab122ecc25e0
> Author: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>
> dt-bindings: iio: light: veml6030: add veml6031x00 ALS series
>
> This commit adds the veml6031x00 series of ambient light sensors to the
> vishay,veml6030 bindings, updating the required compatibility strings and
> datasheet references.
>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>> index 0041e1db68388..6a387c76df353 100644
>> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>> @@ -4,7 +4,8 @@
>> $id: http://devicetree.org/schemas/iio/light/vishay,veml6030.yaml#
>> $schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> -title: VEML3235, VEML3328, VEML6030, VEML6035 and VEML7700 Ambient Light Sensors (ALS)
>> +title: VEML3235, VEML3328, VEML6030, VEML6031x00 series, VEML6035
>> +and VEML7700 Ambient Light Sensors (ALS)
>
> [Severity: Low]
> Does this continuation line need to be indented?
>
> Because it lacks indentation relative to the root mapping at column 0, the
> YAML parser treats it as a new implicit block mapping key rather than a
> continuation of the title scalar. This results in a syntax error during
> dt_binding_check.
>
> [ ... ]
This is right, another device was added to the title between versions and
this 2-line title need two white spaces at the beginning of the second
line. I just validated it with dt_binding_check, and it will be added to
V6.
Best regards,
Javier
next prev parent reply other threads:[~2026-08-07 14:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 13:51 [PATCH v5 0/4] iio: light: add support for veml6031x00 ALS series Javier Carrasco
2026-08-07 13:51 ` [PATCH v5 1/4] dt-bindings: iio: light: veml6030: add " Javier Carrasco
2026-08-07 14:06 ` sashiko-bot
2026-08-07 14:34 ` Javier Carrasco [this message]
2026-08-07 15:33 ` Rob Herring (Arm)
2026-08-10 6:23 ` Krzysztof Kozlowski
2026-08-10 7:23 ` Javier Carrasco
2026-08-07 13:51 ` [PATCH v5 2/4] iio: light: add support for " Javier Carrasco
2026-08-07 14:19 ` sashiko-bot
2026-08-07 14:53 ` Javier Carrasco
2026-08-07 21:02 ` Uwe Kleine-König
2026-08-10 13:38 ` Andy Shevchenko
2026-08-10 23:06 ` Javier Carrasco
2026-08-11 5:40 ` Andy Shevchenko
2026-08-07 13:51 ` [PATCH v5 3/4] iio: light: veml6031x00: add support for triggered buffers Javier Carrasco
2026-08-07 14:49 ` sashiko-bot
2026-08-07 20:33 ` Javier Carrasco
2026-08-07 13:51 ` [PATCH v5 4/4] iio: light: veml6031x00: add support for events and trigger Javier Carrasco
2026-08-07 15:08 ` sashiko-bot
2026-08-08 6:35 ` Javier Carrasco
2026-08-10 15:32 ` Andy Shevchenko
2026-08-10 23:09 ` Javier Carrasco
2026-08-11 5:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKISB5L2MJXM.S5JH6EXSRJM2@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.