From: "Danilo Krummrich" <dakr@kernel.org>
To: "John Hubbard" <jhubbard@nvidia.com>
Cc: "Vladislav Zaharov" <vladazaharova2018@gmail.com>,
<acourbot@nvidia.com>, <aliceryhl@google.com>, <ttabi@nvidia.com>,
<nova-gpu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpu: nova-core: gsp: retain the GSP-RM log buffers after unbind
Date: Thu, 13 Aug 2026 01:15:10 +0200 [thread overview]
Message-ID: <DKNCIMHM4AG6.145KTN1QZLFTD@kernel.org> (raw)
In-Reply-To: <a72edc5b-49c0-42e0-b21c-940e71909666@nvidia.com>
On Thu Aug 13, 2026 at 12:41 AM CEST, John Hubbard wrote:
> I'd *much* rather use a kernel parameter: keep_gsp_logs, instead of
> requiring a rebuild of the kernel. As you mention above, nouveau
> arrived at the same conclusion, and yet even after mentioning it,
> you went off in this other direction, but without explaining why.
Not sure if Vladislav read that, but it might be on us; we were both talking
about a Kconfig in [1] back then, but meant a module param actually. :)
> If someone is debugging, all they need to do is reboot with that
> parameter, in order to get the logs. That's a big improvement over
> requiring a kernel rebuild.
I think for development it doesn't make a huge difference, but a module param
might be easier to deal with if something unexpected happens in some less
controlled environment.
So, while I'm usually not a huge fan of module params, I do agree in this case.
[1] https://lore.kernel.org/all/067c6016-ce21-449e-b0d6-86252ac483a0@nvidia.com/
next prev parent reply other threads:[~2026-08-12 23:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 11:37 [PATCH 0/2] gpu: nova-core: retain the GSP-RM log buffers Vladislav Zaharov
2026-08-12 11:37 ` [PATCH 1/2] gpu: nova-core: gsp: retain the GSP-RM log buffers after unbind Vladislav Zaharov
2026-08-12 11:53 ` sashiko-bot
2026-08-12 12:06 ` Vladislav Zaharov
2026-08-12 14:00 ` Gary Guo
2026-08-12 14:38 ` Vladislav Zaharov
2026-08-12 22:41 ` John Hubbard
2026-08-12 23:15 ` Danilo Krummrich [this message]
2026-08-13 0:00 ` John Hubbard
2026-08-12 23:43 ` Danilo Krummrich
2026-08-12 11:37 ` [PATCH 2/2] Documentation: nova: remove completed GSP log buffer task Vladislav Zaharov
2026-08-12 15:54 ` [PATCH 0/2] gpu: nova-core: retain the GSP-RM log buffers Danilo Krummrich
2026-08-12 16:08 ` Vladislav Zaharov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKNCIMHM4AG6.145KTN1QZLFTD@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jhubbard@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ttabi@nvidia.com \
--cc=vladazaharova2018@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.