From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-26.mta0.migadu.com [91.218.175.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B05C43BE141 for ; Mon, 17 Aug 2026 08:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.26 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786954516; cv=none; b=Q3RyO81Js8QbXBiMctiww7CpJL2OJIYf2wLXnohOeGc1N5y0EZazftJMlJ5rpzXD8s0OLRWAn6h2fnl9s/5UzwLS0oBn48yxYJsLn4/NVzqC3mwjrcxCaxiqVTQUulhtp4Ccqu1fDipCkd5CT2Q7QtcTf5r/tY80aR2fSQV0srM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786954516; c=relaxed/simple; bh=C0O0F0T5Khr4i9evrKR9qQ1b3ukNc51FfJbV+j3oy3Q=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=sgfCr+PpF50enoXxuDmkKpILp1TfOXvhddmfMXYl9qeacyfoejV7tMsLtPROu4X5w/qk7vFKdVeB9EqvxBTu8/2l2Y3sztD81YLeqjvk4Jlx5NNPWDtfNQ61eoWGhS1cgYpGi0XCb/xxOgrcNxct1lu9pzMBJnYzHYBzz9Nv0rU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=hhVhQJO6; arc=none smtp.client-ip=91.218.175.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="hhVhQJO6" X-Envelope-To: linux-crypto@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=C0O0F0T5Khr4i9evrKR9qQ1b3ukNc51FfJbV+j3oy3Q=; c=simple/simple; d=cknow-tech.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786954510; v=1; x=1787559310; b=hhVhQJO6LkgnZbGnPrn8ZOEQmZ7vWhS+ZVrfUmUxrqh+qv0Lrw3p1WOmQTwfA3WY2wTf5SBI 0tDB9rb2tHUdFs9DxdaIjJJiMseOo/TUH43zMy4zDmw1i8uKCuhHLYknSM1JWHe94JQi4ZJRJOl y7DSQa1EYuOWLuLa5i3Yz4UuPqb4mxRmshbPhrWy2sBSremdXLazCLaAGqrt1wul74Ls8UgjAtQ FJ4oOXzu1Jy8RBfSiUyvZ2ZovLXnBlMoKdC6erXOqhkS5UNWGDOJMEIg1TMH8bEd6GJ/N3O0lsO 95LPnVzzotiEKHIhkkGTkzVOYwfef25S4fEIDjh5vtdNg== X-Envelope-To: linux-crypto@vger.kernel.org Received: from localhost (92.254.112.55) by smtp.migadu.com with ESMTPS id 54f7be6b0ec37d4f; Mon, 17 Aug 2026 08:15:00 +0000 X-Migadu-Flow: FLOW_OUT Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 17 Aug 2026 10:14:58 +0200 Message-Id: Subject: Re: [PATCH v3 1/4] dt-bindings: crypto: rockchip: Add RK356x/RK3588 crypto engine binding From: "Diederik de Haas" To: "Dawid Olesinski" , "Herbert Xu" , "David S . Miller" , "Rob Herring" , "Krzysztof Kozlowski" , "Heiko Stuebner" Cc: "Diederik de Haas" , "Eric Biggers" , "Sebastian Reichel" , "Philipp Zabel" , "Conor Dooley" , "Corentin Labbe" , , , , , X-Mailer: aerc 0.22.0 References: <20260708175837.1718437-1-dawidro@gmail.com> <20260816194112.552100-1-dawidro@gmail.com> <20260816194112.552100-2-dawidro@gmail.com> In-Reply-To: <20260816194112.552100-2-dawidro@gmail.com> Hi Dawid, On Sun Aug 16, 2026 at 9:39 PM CEST, Dawid Olesinski wrote: > Add a YAML device tree binding for the Rockchip second-generation (V2) > cryptographic hardware accelerator present on the RK3568 and RK3588 SoCs. > > The IP block exposes AES-ECB, AES-CBC, AES-XTS block ciphers, SHA-1, > SHA-224, SHA-256, SHA-384, SHA-512, MD5, and SM3 hash algorithms, each > with a hardware DMA engine controlled via linked-list descriptors. > > The binding covers two compatible strings: > > - rockchip,rk3568-crypto: clocks and resets are driven directly by the > non-secure CRU (accessible to Linux at EL1). > - rockchip,rk3588-crypto: clocks and resets live in SECURECRU, a > register bank sandboxed to TrustZone. Linux must request them through > the ARM SCMI firmware interface (scmi_clk / scmi_reset), as direct > MMIO access to SECURECRU from EL1 triggers a bus fault. > > Co-developed-by: Corentin Labbe > Signed-off-by: Corentin Labbe > Signed-off-by: Dawid Olesinski > Tested-by: Diederik de Haas # Quartz64-B, > NanoPi R5S, NanoPC-T6 LTS AFAIK these lines should not have a line break, ie must be on one line. Cheers, Diederik > --- > .../crypto/rockchip,rk3588-crypto.yaml | 83 +++++++++++++++++++ > MAINTAINERS | 2 + > 2 files changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3= 588-crypto.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3588-cry= pto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.= yaml > new file mode 100644 > index 000000000000..32d241c19453 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yam= l > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/rockchip,rk3588-crypto.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip cryptographic offloader > + > +maintainers: > + - Heiko Stuebner > + - Corentin Labbe > + - Dawid Olesinski > + > +properties: > + compatible: > + oneOf: > + - const: rockchip,rk3568-crypto > + - items: > + - enum: > + - rockchip,rk3588-crypto > + - const: rockchip,rk3568-crypto > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Core clock for the crypto IP internal logic > + - description: AXI interconnect clock interface > + - description: AHB interface clock > + > + clock-names: > + items: > + - const: core > + - const: aclk > + - const: hclk > + > + resets: > + minItems: 1 > + maxItems: 3 > + > + reset-names: > + minItems: 1 > + items: > + - const: core > + - const: aclk > + - const: hclk > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + bus { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + crypto@fe370000 { > + compatible =3D "rockchip,rk3588-crypto", "rockchip,rk3568-crypto= "; > + reg =3D <0x0 0xfe370000 0x0 0x2000>; > + interrupts =3D ; > + clocks =3D <&scmi_clk SCMI_CRYPTO_CORE>, <&scmi_clk SCMI_ACLK_SE= CURE_NS>, > + <&scmi_clk SCMI_HCLK_SECURE_NS>; > + clock-names =3D "core", "aclk", "hclk"; > + resets =3D <&scmi_reset SCMI_SRST_CRYPTO_CORE>; > + reset-names =3D "core"; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index c8d4b913f26c..50b77a750db3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23131,9 +23131,11 @@ F: drivers/media/platform/rockchip/rkcif/ > =20 > ROCKCHIP CRYPTO DRIVERS > M: Corentin Labbe > +M: Dawid Olesinski > L: linux-crypto@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > +F: Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml > F: drivers/crypto/rockchip/ > =20 > ROCKCHIP I2S TDM DRIVER From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3593C5DF70 for ; Mon, 17 Aug 2026 08:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GOxezrNZTc+Pa8cguh/5BJYQUZ3Z2aMPLUiL92i0KEE=; b=w4DsdvJA86/hVI /m/uiEyGOUPFR6A85vohA/eNRVzet9aZglrJpPd/mKpsn940zY3XOx7vpHC7zR3JWSRbH3P87KX7+ XkTtRcPl+gT/Qa/W+ARXtgL3Ii6+bnFwnw3WI/0cP5SsRXAEXaFeOIRbiVgZUp8TUR6Xg8zrPsudi Q3r/CsvbRVoiq5MRUYClhcVSlNv35IKv1X2IiiZ3APf/v944+hMeftQidFw9nySd5ld1UBaCskH4K CKvF8DyUvH7QqSpSx8d1g+kFOEZ2+MKbMNnDrgZWTXY2ejuWcufRDiBKR2sGb3Sauo9ap44CUFv6r /6gPmowdw7KERGFBvuEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wvsV4-00000005dgt-1clb; Mon, 17 Aug 2026 08:15:18 +0000 Received: from out-214.mta1.migadu.com ([2001:41d0:203:375::d6] helo=mta1.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wvsUz-00000005dfp-2msa for linux-rockchip@lists.infradead.org; Mon, 17 Aug 2026 08:15:16 +0000 X-Envelope-To: linux-rockchip@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=C0O0F0T5Khr4i9evrKR9qQ1b3ukNc51FfJbV+j3oy3Q=; c=simple/simple; d=cknow-tech.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786954510; v=1; x=1787559310; b=hhVhQJO6LkgnZbGnPrn8ZOEQmZ7vWhS+ZVrfUmUxrqh+qv0Lrw3p1WOmQTwfA3WY2wTf5SBI 0tDB9rb2tHUdFs9DxdaIjJJiMseOo/TUH43zMy4zDmw1i8uKCuhHLYknSM1JWHe94JQi4ZJRJOl y7DSQa1EYuOWLuLa5i3Yz4UuPqb4mxRmshbPhrWy2sBSremdXLazCLaAGqrt1wul74Ls8UgjAtQ FJ4oOXzu1Jy8RBfSiUyvZ2ZovLXnBlMoKdC6erXOqhkS5UNWGDOJMEIg1TMH8bEd6GJ/N3O0lsO 95LPnVzzotiEKHIhkkGTkzVOYwfef25S4fEIDjh5vtdNg== X-Envelope-To: linux-rockchip@lists.infradead.org Received: from localhost (92.254.112.55) by smtp.migadu.com with ESMTPS id 54f7be6b0ec37d4f; Mon, 17 Aug 2026 08:15:00 +0000 X-Migadu-Flow: FLOW_OUT Mime-Version: 1.0 Date: Mon, 17 Aug 2026 10:14:58 +0200 Message-Id: Subject: Re: [PATCH v3 1/4] dt-bindings: crypto: rockchip: Add RK356x/RK3588 crypto engine binding From: "Diederik de Haas" To: "Dawid Olesinski" , "Herbert Xu" , "David S . Miller" , "Rob Herring" , "Krzysztof Kozlowski" , "Heiko Stuebner" Cc: "Diederik de Haas" , "Eric Biggers" , "Sebastian Reichel" , "Philipp Zabel" , "Conor Dooley" , "Corentin Labbe" , , , , , X-Mailer: aerc 0.22.0 References: <20260708175837.1718437-1-dawidro@gmail.com> <20260816194112.552100-1-dawidro@gmail.com> <20260816194112.552100-2-dawidro@gmail.com> In-Reply-To: <20260816194112.552100-2-dawidro@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260817_011515_057939_6252C704 X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Dawid, On Sun Aug 16, 2026 at 9:39 PM CEST, Dawid Olesinski wrote: > Add a YAML device tree binding for the Rockchip second-generation (V2) > cryptographic hardware accelerator present on the RK3568 and RK3588 SoCs. > > The IP block exposes AES-ECB, AES-CBC, AES-XTS block ciphers, SHA-1, > SHA-224, SHA-256, SHA-384, SHA-512, MD5, and SM3 hash algorithms, each > with a hardware DMA engine controlled via linked-list descriptors. > > The binding covers two compatible strings: > > - rockchip,rk3568-crypto: clocks and resets are driven directly by the > non-secure CRU (accessible to Linux at EL1). > - rockchip,rk3588-crypto: clocks and resets live in SECURECRU, a > register bank sandboxed to TrustZone. Linux must request them through > the ARM SCMI firmware interface (scmi_clk / scmi_reset), as direct > MMIO access to SECURECRU from EL1 triggers a bus fault. > > Co-developed-by: Corentin Labbe > Signed-off-by: Corentin Labbe > Signed-off-by: Dawid Olesinski > Tested-by: Diederik de Haas # Quartz64-B, > NanoPi R5S, NanoPC-T6 LTS AFAIK these lines should not have a line break, ie must be on one line. Cheers, Diederik > --- > .../crypto/rockchip,rk3588-crypto.yaml | 83 +++++++++++++++++++ > MAINTAINERS | 2 + > 2 files changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml > new file mode 100644 > index 000000000000..32d241c19453 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/rockchip,rk3588-crypto.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip cryptographic offloader > + > +maintainers: > + - Heiko Stuebner > + - Corentin Labbe > + - Dawid Olesinski > + > +properties: > + compatible: > + oneOf: > + - const: rockchip,rk3568-crypto > + - items: > + - enum: > + - rockchip,rk3588-crypto > + - const: rockchip,rk3568-crypto > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Core clock for the crypto IP internal logic > + - description: AXI interconnect clock interface > + - description: AHB interface clock > + > + clock-names: > + items: > + - const: core > + - const: aclk > + - const: hclk > + > + resets: > + minItems: 1 > + maxItems: 3 > + > + reset-names: > + minItems: 1 > + items: > + - const: core > + - const: aclk > + - const: hclk > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + crypto@fe370000 { > + compatible = "rockchip,rk3588-crypto", "rockchip,rk3568-crypto"; > + reg = <0x0 0xfe370000 0x0 0x2000>; > + interrupts = ; > + clocks = <&scmi_clk SCMI_CRYPTO_CORE>, <&scmi_clk SCMI_ACLK_SECURE_NS>, > + <&scmi_clk SCMI_HCLK_SECURE_NS>; > + clock-names = "core", "aclk", "hclk"; > + resets = <&scmi_reset SCMI_SRST_CRYPTO_CORE>; > + reset-names = "core"; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index c8d4b913f26c..50b77a750db3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23131,9 +23131,11 @@ F: drivers/media/platform/rockchip/rkcif/ > > ROCKCHIP CRYPTO DRIVERS > M: Corentin Labbe > +M: Dawid Olesinski > L: linux-crypto@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > +F: Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.yaml > F: drivers/crypto/rockchip/ > > ROCKCHIP I2S TDM DRIVER _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip