From: "Alexis Lothoré" <alexis.lothore@bootlin.com>
To: "Daniel Borkmann" <daniel@iogearbox.net>,
"Alexis Lothoré (eBPF Foundation)" <alexis.lothore@bootlin.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"Jiri Olsa" <jolsa@kernel.org>,
"Emil Tsalapatis" <emil@etsalapatis.com>,
"Shuah Khan" <shuah@kernel.org>,
"Ihor Solodrai" <ihor.solodrai@linux.dev>
Cc: <ebpf@linuxfoundation.org>,
"Bastien Curutchet" <bastien.curutchet@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
<bpf@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf v5 2/2] selftests/bpf: allocate a larger timeout for connection
Date: Mon, 17 Aug 2026 11:55:59 +0200 [thread overview]
Message-ID: <DKR4NFY9QWP6.HDPI329BNKZ0@bootlin.com> (raw)
In-Reply-To: <07776a9c-2998-4d65-af3e-c714181d4241@iogearbox.net>
Hi Daniel,
On Mon Aug 17, 2026 at 10:55 AM CEST, Daniel Borkmann wrote:
> Hi Alexis,
>
> On 8/14/26 9:11 AM, Alexis Lothoré (eBPF Foundation) wrote:
[...]
>> + /*
>> + * If the timeout configured by the test is different from the
>> + * connect timeout, restore it
>> + */
>> + if (opts->timeout_ms != CONNECT_MIN_TIMEOUT_MS &&
>> + settimeo(fd, opts->timeout_ms)) {
>> + log_err("Failed to set timeout for connected socket");
>> + goto close;
>> }
>
> Could you do one last spin? I'll get the comment fix applied, but the above
> still has issues as pointed out by sashiko, so maybe this could be reworked
> as follows (untested):
Sure, I was planning to respin today with fixes to issues raised by the
CI bot (wrong patch subject and mishandling of timeouts larger than the
default connect timeout). I'll send it later today.
Thanks,
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-08-17 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 7:11 [PATCH bpf v5 0/2] selftest/bpf: make test_tc_tunnel and test_tc_edt more robust to CI load Alexis Lothoré (eBPF Foundation)
2026-08-14 7:11 ` [PATCH bpf v5 1/2] bpf/selftests: fix comment style in network_helpers.c Alexis Lothoré (eBPF Foundation)
2026-08-14 7:49 ` bot+bpf-ci
2026-08-14 7:11 ` [PATCH bpf v5 2/2] selftests/bpf: allocate a larger timeout for connection Alexis Lothoré (eBPF Foundation)
2026-08-14 7:49 ` bot+bpf-ci
2026-08-17 8:55 ` Daniel Borkmann
2026-08-17 9:55 ` Alexis Lothoré [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKR4NFY9QWP6.HDPI329BNKZ0@bootlin.com \
--to=alexis.lothore@bootlin.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bastien.curutchet@bootlin.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ebpf@linuxfoundation.org \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.