From: "Gary Guo" <gary@garyguo.net>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>
Cc: "Josh Poimboeuf" <jpoimboe@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
rust-for-linux@vger.kernel.org, "Ke Sun" <sunke@kylinos.cn>
Subject: Re: [PATCH] objtool/rust: add one more `noreturn` Rust function
Date: Tue, 18 Aug 2026 17:38:37 +0100 [thread overview]
Message-ID: <DKS7U9UHY6XR.2JC0EBIPCI06Z@garyguo.net> (raw)
In-Reply-To: <CANiq72kBrbV827gHUXd4R3AJrMTAVwxA=vGvzJ_AuOcNjVfVtg@mail.gmail.com>
On Sat Aug 15, 2026 at 3:55 PM BST, Miguel Ojeda wrote:
> On Wed, Aug 5, 2026 at 4:45 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>>
>> When the pointer formatting series [1] is applied and KUnit tests
>> are enabled, `objtool` would report an error with any of our
>> supported Rust versions. For instance, with Rust 1.97.1:
>
> With the version that I applied of that series, this was not strictly
> needed anymore.
I am seeing this function causing issue on my 1.85.1 -Os build, although the
error message is different this time:
rust/kernel.o: warning: objtool: _RNvXs2_NtNtCsaNryh1j6xD7_4core3str6traitseINtNtNtB9_3ops5index5IndexINtNtBJ_5range9RangeFromjEE5indexCsldbe0TGTmNx_6kernel+0x1d: stack state mismatch: cfa1=4+8 cfa2=4+16
Disassembly shows that the function call before the warning location is a call
to _4core3str16slice_error_fail, and objtool thought it can return (which will
end up with a unbalanced stack if it does return).
Applying the patch fixes the issue.
Best,
Gary
next prev parent reply other threads:[~2026-08-18 16:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 14:45 [PATCH] objtool/rust: add one more `noreturn` Rust function Miguel Ojeda
2026-08-15 14:55 ` Miguel Ojeda
2026-08-18 16:38 ` Gary Guo [this message]
2026-08-18 18:17 ` Miguel Ojeda
2026-08-24 1:14 ` Miguel Ojeda
-- strict thread matches above, loose matches on Subject: below --
2026-02-06 20:43 Miguel Ojeda
2026-02-10 10:03 ` Miguel Ojeda
2025-10-20 2:07 Miguel Ojeda
2025-10-20 8:17 ` Alice Ryhl
2025-10-20 10:51 ` Peter Zijlstra
2025-10-21 17:25 ` Miguel Ojeda
2025-10-22 8:13 ` Peter Zijlstra
2025-04-13 0:23 Miguel Ojeda
2025-04-13 17:18 ` Sasha Levin
2025-04-13 17:22 ` Miguel Ojeda
2025-04-14 14:07 ` Alice Ryhl
2025-04-14 15:08 ` Miguel Ojeda
2025-01-12 14:39 Miguel Ojeda
2025-01-12 14:47 ` Miguel Ojeda
2025-01-12 14:54 ` Greg KH
2025-01-15 19:25 ` Gary Guo
2025-02-12 22:28 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKS7U9UHY6XR.2JC0EBIPCI06Z@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=jpoimboe@kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sunke@kylinos.cn \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.