From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11E1E137750; Thu, 20 Aug 2026 05:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787202159; cv=none; b=ZJ7Zezd5nQSLuf7o0vp3WBRVfSq5UPxmcVXF246o8SBcOX41+QVA3RlilzD3E+MN3eWHfd2X8U/mnIZZrx8AamvIxNFnZnt8jSz4+U/rAUYMPhEoXp5FSpKFJ/IeQLTlabazsaFg9B85VrdltzG+6TRmxQmIPAd14uWJnmhhsiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787202159; c=relaxed/simple; bh=pY4cXMl9g1/YDScEen6tbm7WPEsJq7UDTp5xjJNYt7k=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:From:To:Subject: References:In-Reply-To; b=Cmd4cOtQi+GjNpxyY9YsWhUJSqbxPTRMfl9ZUs397u6ZFjIRGHE/An7AYuYM67ncQLuZyiu4DcJPMjFTtjb9shwfYBdImMdbgtgkO/IRHmhWiZbB1xvz18Bv4aKx7B9Yv3KIzanPj0vUIV5MZ1u0zkll+6r4w3GPgRjavgzsvH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=d+qe4FcP; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="d+qe4FcP" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 46E154E412E2; Thu, 20 Aug 2026 05:02:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0D5445FF59; Thu, 20 Aug 2026 05:02:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id EB63311C75D87; Thu, 20 Aug 2026 07:02:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1787202147; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=I2eZLHoFTLtYnqAPbAqSK2Rpc5EQeElhxYx0vz8zAvQ=; b=d+qe4FcP1K7JQejOsetBB+a4w9v32yPTsVG3+rfnPI+JwdnSHy+3Lh2q7zrru87RoH3/0l jv8gE28PvnVnK04uypiXw1Ilr2+GI+hx1KSDR13AFKBhVBc3VGlNI5CGWSedKOtpOsb54j qqbUuSVob2hC18z9jLlLjNei5SRX+K+XOSwuHBKudeKI5nljkafUugazoZMg7mxD6HX0x5 N/X0dLT5et5k2UphW6SIm5dLf63UYkVCq3MiokZFUDnagNTzg1DwwFJx/m22VTC+s3jV5b oH2iYEwn3LbCYOM5yy3HvqnjN/NVntP5yjR+M1m20bddieKDztRJ0301W7e0jQ== Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 20 Aug 2026 07:02:18 +0200 Message-Id: Cc: , , , , , , , , From: "Mathieu Dubois-Briand" To: "Geert Uytterhoeven" , "Tero Kristo" , "Stephen Boyd" , "Brian Masney" , "Jerome Brunet" , "Nobuhiro Iwamatsu" , "Nuno Sa" , "Guenter Roeck" , "Michael Hennerich" , "Antoniu Miclaus" , "Jonathan Cameron" , "David Lechner" , "Andy Shevchenko" , "Sunny Luo" , "Xianwei Zhao" , "Mark Brown" , "Kees Cook" , "Kevin Hilman" Subject: Re: [PATCH treewide 1/5] clk: ti: Make sure clk_init_data is fully initialized X-Mailer: aerc 0.21.0-0-g5549850facc2 References: In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Wed Aug 19, 2026 at 9:05 PM CEST, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > _register_mux() fills in init.parent_data, and assumes that > init.parent_names is NULL. However, the latter in uninitialized, and > thus may cause a crash. > > Make sure all members are fully initialized, to fix such bugs, and to > avoid future breakage when converting drivers to a different method for > specifying the parents. > > Fixes: 667f420c09f1417c ("clk: ti: mux: resolve parent clocks by DT index= , not by name") > Closes: https://lore.kernel.org/CAMuHMdU3yVqoyHC4eNF2NuYo8wy+6ODLoYat4R71= X99Mxc_=3Dkw@mail.gmail.com > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Mathieu Dubois-Briand Thanks again for the fix. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84B3CC5DF85 for ; Thu, 20 Aug 2026 05:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Subject:To:From: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pxaXyJ+zxvnuZY0ixaU//mL5eKV0oFoQ7cQUY+XPTnE=; b=ZmwyOrEckrZbLJ y406Iw+3X4VOv99IQj7KsLFhVsu00eiFbnNo9BdLlFzw/k8melPqbkanLaxRRjyfsZU4wohC4NCAT SzJItLMKBuxmI6DhB5uPKIPkN8b64hHIaqCiodgUP5k+cesQEqr1z5oCscFudLPPeoBfhtU+x3DBO Ca2ftnTJc9XigNkxspz6Xz8kC8/cQJIP6Mj97GYGTnY+vAkSjNNrIZfRXw4eCmCy6u3RGgHWzRsX2 MwFKtnUC2WhVCtXeZTVvnYnnKgUfWbQCb5LFY/9cW0aXDgzrgxvVXm9zooCCFkC6mTBkJfAUAy4zR yOJorluL4ewOgHh9NE2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwuvJ-0000000ApUZ-0eHq; Thu, 20 Aug 2026 05:02:41 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwuvG-0000000ApTr-1eyW; Thu, 20 Aug 2026 05:02:40 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 46E154E412E2; Thu, 20 Aug 2026 05:02:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0D5445FF59; Thu, 20 Aug 2026 05:02:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id EB63311C75D87; Thu, 20 Aug 2026 07:02:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1787202147; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=I2eZLHoFTLtYnqAPbAqSK2Rpc5EQeElhxYx0vz8zAvQ=; b=d+qe4FcP1K7JQejOsetBB+a4w9v32yPTsVG3+rfnPI+JwdnSHy+3Lh2q7zrru87RoH3/0l jv8gE28PvnVnK04uypiXw1Ilr2+GI+hx1KSDR13AFKBhVBc3VGlNI5CGWSedKOtpOsb54j qqbUuSVob2hC18z9jLlLjNei5SRX+K+XOSwuHBKudeKI5nljkafUugazoZMg7mxD6HX0x5 N/X0dLT5et5k2UphW6SIm5dLf63UYkVCq3MiokZFUDnagNTzg1DwwFJx/m22VTC+s3jV5b oH2iYEwn3LbCYOM5yy3HvqnjN/NVntP5yjR+M1m20bddieKDztRJ0301W7e0jQ== Mime-Version: 1.0 Date: Thu, 20 Aug 2026 07:02:18 +0200 Message-Id: Cc: , , , , , , , , From: "Mathieu Dubois-Briand" To: "Geert Uytterhoeven" , "Tero Kristo" , "Stephen Boyd" , "Brian Masney" , "Jerome Brunet" , "Nobuhiro Iwamatsu" , "Nuno Sa" , "Guenter Roeck" , "Michael Hennerich" , "Antoniu Miclaus" , "Jonathan Cameron" , "David Lechner" , "Andy Shevchenko" , "Sunny Luo" , "Xianwei Zhao" , "Mark Brown" , "Kees Cook" , "Kevin Hilman" Subject: Re: [PATCH treewide 1/5] clk: ti: Make sure clk_init_data is fully initialized X-Mailer: aerc 0.21.0-0-g5549850facc2 References: In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260819_220238_591956_D12F2E73 X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed Aug 19, 2026 at 9:05 PM CEST, Geert Uytterhoeven wrote: > The clk_init_data structure contains several mutually-exclusive members > for different methods to specify the possible parents of a clock, > prompting drivers to initialize only the members they need. However, > not initializing all members may cause subtle issues, which are only > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > enabled. > > _register_mux() fills in init.parent_data, and assumes that > init.parent_names is NULL. However, the latter in uninitialized, and > thus may cause a crash. > > Make sure all members are fully initialized, to fix such bugs, and to > avoid future breakage when converting drivers to a different method for > specifying the parents. > > Fixes: 667f420c09f1417c ("clk: ti: mux: resolve parent clocks by DT index, not by name") > Closes: https://lore.kernel.org/CAMuHMdU3yVqoyHC4eNF2NuYo8wy+6ODLoYat4R71X99Mxc_=kw@mail.gmail.com > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Mathieu Dubois-Briand Thanks again for the fix. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic