From: "Zi Yan" <ziy@nvidia.com>
To: "Kiryl Shutsemau" <kirill@shutemov.name>,
<akpm@linux-foundation.org>, <david@kernel.org>, <ljs@kernel.org>,
<hannes@cmpxchg.org>, <usama.arif@linux.dev>,
"Kairui Song" <kasong@tencent.com>
Cc: <lance.yang@linux.dev>, <hughd@google.com>,
<baolin.wang@linux.alibaba.com>, <baohua@kernel.org>,
<liam@infradead.org>, <nico.pache@linux.dev>, <dev.jain@arm.com>,
<ryan.roberts@arm.com>, <balbirs@nvidia.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
"Kiryl Shutsemau (Meta)" <kas@kernel.org>
Subject: Re: [PATCH 3/5] mm/huge_memory: reduce indent level in __folio_freeze_and_split_unmapped()
Date: Wed, 26 Aug 2026 12:34:47 -0400 [thread overview]
Message-ID: <DKZ0RP174ZWV.1DP8KKRE1LQ6Y@nvidia.com> (raw)
In-Reply-To: <20260826162101.1314941-4-kirill@shutemov.name>
On Wed Aug 26, 2026 at 12:20 PM EDT, Kiryl Shutsemau wrote:
> From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
>
> Trivial cleanup: short-circuit the function if folio_ref_freeze() fails.
> It save an indent level for the whole function.
>
> No functional change intended.
>
> Signed-off-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
> ---
> mm/huge_memory.c | 233 +++++++++++++++++++++++------------------------
> 1 file changed, 115 insertions(+), 118 deletions(-)
>
Kairui has a series that cleans up __folio_split()[1]. It seems that your
patch 3, 4, and 5 overlap with his changes (e.g., your patch 3 is the
same as his patch 3).
[1] https://lore.kernel.org/all/20260821-swap-thp-cleanup-v3-0-9b43f5163238@tencent.com/
--
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2026-08-26 16:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 16:20 [PATCH 0/5] Fix deferred_split_isolate() and clean up __folio_freeze_and_split_unmapped() Kiryl Shutsemau
2026-08-26 16:20 ` [PATCH 1/5] mm/huge_memory: do not touch frozen folios in deferred_split_isolate() Kiryl Shutsemau
2026-08-26 16:45 ` Zi Yan
2026-08-27 15:02 ` Johannes Weiner
2026-08-27 15:23 ` David Hildenbrand (Arm)
2026-08-27 15:38 ` Zi Yan
2026-08-27 15:56 ` David Hildenbrand (Arm)
2026-08-27 16:38 ` Usama Arif
2026-08-28 1:57 ` Zi Yan
2026-08-31 0:33 ` Kiryl Shutsemau
2026-08-26 16:20 ` [PATCH 2/5] mm/huge_memory: dequeue the deferred split after the split freeze Kiryl Shutsemau
2026-08-26 17:10 ` Zi Yan
2026-08-27 15:25 ` David Hildenbrand (Arm)
2026-08-27 16:59 ` Johannes Weiner
2026-08-26 16:20 ` [PATCH 3/5] mm/huge_memory: reduce indent level in __folio_freeze_and_split_unmapped() Kiryl Shutsemau
2026-08-26 16:34 ` Zi Yan [this message]
2026-08-26 16:43 ` Kiryl Shutsemau
2026-08-26 16:21 ` [PATCH 4/5] mm/huge_memory: fold nested ifs " Kiryl Shutsemau
2026-08-26 16:21 ` [PATCH 5/5] mm/huge_memory: turn the swapcache-with-mapping error case into an assert Kiryl Shutsemau
2026-08-28 3:14 ` [PATCH 0/5] Fix deferred_split_isolate() and clean up __folio_freeze_and_split_unmapped() Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKZ0RP174ZWV.1DP8KKRE1LQ6Y@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=balbirs@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=kirill@shutemov.name \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nico.pache@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=usama.arif@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.