All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kurt Borja" <kuurtb@gmail.com>
To: "Rickey Bartlett" <subtexel@gmail.com>, <kuurtb@gmail.com>
Cc: <platform-driver-x86@vger.kernel.org>, <Dell.Client.Kernel@dell.com>
Subject: Re: [PATCH] platform/x86/dell: alienware-wmi-wmax: add Alienware Area-51 AAT2250
Date: Thu, 27 Aug 2026 21:47:39 -0500	[thread overview]
Message-ID: <DL08FHLYHRAB.2CA5JTNXDMNSQ@gmail.com> (raw)
In-Reply-To: <CAAqcVzxJMxg83EJJD+e2eatjmEbF63jX2i8x0=KKeNv2F=5PEQ@mail.gmail.com>

On Thu Aug 27, 2026 at 2:37 PM -05, Rickey Bartlett wrote:
> Add the Alienware Area-51 (2025 desktop, model AAT2250) to the AWCC DMI
> table. Tested on hardware with BIOS 1.6.0: loading with
> force_platform_profile=1 force_hwmon=1 exposes a working platform
> profile (quiet/balanced/balanced-performance/custom) and a fully
> functional hwmon interface (6 fans - CPU, 3 top, 2 front - with
> fan boost control and temperature sensors). G-Mode is not applicable
> to this desktop, so generic_quirks is used.

I would move this G-Mode sentence right after the first sentence.

>
> The full product name is matched to avoid colliding with the
> "Alienware Area-51m" and "Alienware 16/18 Area-51" laptop entries.

Same for this paragraph, it makes more sense together with the first
paragraph. Then you can let the "Tested on" stuff be its own paragraph.

>
> Signed-off-by: Rickey Bartlett <subtexel@gmail.com>
> ---
> drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> @@ -122,6 +122,14 @@
> .driver_data = &g_series_quirks,
> },
> {
> + .ident = "Alienware Area-51 AAT2250",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Alienware Area-51 AAT2250"),
> + },
> + .driver_data = &generic_quirks,
> + },
> + {
> .ident = "Alienware Area-51m",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Alienware"),

This is not the right indentation of the file. I believe your patch got
corrupted. It was probably your mail client so you should check that
out. Additionally, please use ./scripts/get_maintainer.pl to get all
maintainers and lists involved. You are missing Ilpo and LKML.

Thanks for adding this model! Could you also email me the acpidump of
that machine? I like to keep acpidumps of every model on the list on my
personal archive.

-- 
Thanks,
 ~ Kurt

           reply	other threads:[~2026-08-28  2:47 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CAAqcVzxJMxg83EJJD+e2eatjmEbF63jX2i8x0=KKeNv2F=5PEQ@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DL08FHLYHRAB.2CA5JTNXDMNSQ@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=subtexel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.