From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD366C61DB9 for ; Fri, 28 Aug 2026 12:09:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2C7C10F375; Fri, 28 Aug 2026 12:09:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="T+IwMLZP"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2203610F375 for ; Fri, 28 Aug 2026 12:09:07 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5492C601FD; Fri, 28 Aug 2026 12:09:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 673251F00A3A; Fri, 28 Aug 2026 12:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787918946; bh=twoPQU5vTKg4nfajP+mzb8+VLElzhS+uBF362FjP9Tk=; h=Date:Subject:Cc:To:From:References:In-Reply-To; b=T+IwMLZPEyxWNnU+xwFhUJdLWi6w4t3yXBg2lSwbGb0GeNTecwGG6aShfHFxkmzd3 o+QGtx2mMIJpF96FE1lasCwwaGCzJ9RsNuRbQZifnuVNa2y/QADtsAGt/h3plt0b8u YNEUfTPwi/zJq1aOxYaWraTG+7+lFu+6JoBMTRmDhtasYtU6tqiWzqb3xqOYWAD7Ct KJEINUykeoeIq5L7og3v8p4Xle4if9salg3nAucVkBygxPuAGgjmQlt/RK5TEGylN/ YVtelE+qdM+Pml74FZ6ShD3Z422nQ51FIuF87KztbqMdn+asIKqdvSl8F+X8lJawdb GTwZjbNvm8CbA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 28 Aug 2026 14:09:01 +0200 Message-Id: Subject: Re: [PATCH 1/2] gpu: nova-core: use kernel lossless integer conversion module Cc: "Alice Ryhl" , "David Airlie" , "Simona Vetter" , "John Hubbard" , "Alistair Popple" , "Timur Tabi" , "Eliot Courtney" , "Zhi Wang" , , , , To: "Alexandre Courbot" , From: "Danilo Krummrich" References: <20260828-nova_num-v1-0-e21f17ba4127@nvidia.com> <20260828-nova_num-v1-1-e21f17ba4127@nvidia.com> In-Reply-To: <20260828-nova_num-v1-1-e21f17ba4127@nvidia.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" (Cc: Miguel) On Fri Aug 28, 2026 at 7:33 AM CEST, Alexandre Courbot wrote: > The `kernel` crate now features a replacement for our lossless integer > conversion routines. Switch to the kernel version and remove our own. > > Signed-off-by: Alexandre Courbot > Reviewed-by: Danilo Krummrich > Reviewed-by: Eliot Courtney > --- > drivers/gpu/nova-core/falcon.rs | 12 +- > drivers/gpu/nova-core/falcon/fsp.rs | 4 +- > drivers/gpu/nova-core/fb.rs | 2 +- > drivers/gpu/nova-core/fb/hal/gb100.rs | 6 +- > drivers/gpu/nova-core/firmware.rs | 4 +- > drivers/gpu/nova-core/firmware/booter.rs | 4 +- > drivers/gpu/nova-core/firmware/fwsec.rs | 2 +- > drivers/gpu/nova-core/firmware/fwsec/bootloader.rs | 4 +- > drivers/gpu/nova-core/firmware/gsp.rs | 9 +- > drivers/gpu/nova-core/firmware/tlv.rs | 11 +- > drivers/gpu/nova-core/fsp.rs | 8 +- > drivers/gpu/nova-core/gsp.rs | 4 +- > drivers/gpu/nova-core/gsp/cmdq.rs | 22 +-- > drivers/gpu/nova-core/gsp/fw.rs | 42 ++-- > drivers/gpu/nova-core/gsp/fw/commands.rs | 4 +- > drivers/gpu/nova-core/gsp/sequencer.rs | 2 +- > drivers/gpu/nova-core/mctp.rs | 8 +- > drivers/gpu/nova-core/num.rs | 211 ---------------= ------ > drivers/gpu/nova-core/vbios.rs | 2 +- > 19 files changed, 78 insertions(+), 283 deletions(-) Please see the discussion in [1]. If we make this change, then the subsequent conversion to const_as!() would= need to go through the Rust tree next cycle, which could be a bit of a mess, as = I'd expect a bunch of conflicts. Alternatively, we could the the full three cycle dance, or have a signed ta= g for const_as!() and use it right away. But honestly, the former would just be unnecessary noise. If we don't do th= e latter, let's just keep the nova-core num module until the dust has been settled. [1] https://lore.kernel.org/all/CANiq72k+-fNWZCwGuQ=3DFTchxgm-X-f6WR=3DtG= =3DErcn19ic1edQg@mail.gmail.com/