All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zi Yan" <ziy@nvidia.com>
To: "Andrew Morton" <akpm@linux-foundation.org>,
	<mm-commits@vger.kernel.org>, <saravanand@crusoe.ai>,
	<ryan.roberts@arm.com>, <peterx@redhat.com>, <ljs@kernel.org>,
	<liam@infradead.org>, <lance.yang@linux.dev>, <jgg@ziepe.ca>,
	<dev.jain@arm.com>, <david@kernel.org>, <clg@redhat.com>,
	<baolin.wang@linux.alibaba.com>, <baohua@kernel.org>
Subject: Re: + mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings-fix.patch added to mm-hotfixes-unstable branch
Date: Sat, 29 Aug 2026 10:07:25 -0400	[thread overview]
Message-ID: <DL1HIHWYJ7TB.1CY76SJS0V03L@nvidia.com> (raw)
In-Reply-To: <20260828173805.4CDF11F000E9@smtp.kernel.org>

On Fri Aug 28, 2026 at 1:38 PM EDT, Andrew Morton wrote:
>
> The patch titled
>      Subject: mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings-fix
> has been added to the -mm mm-hotfixes-unstable branch.  Its filename is
>      mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings-fix.patch
>
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings-fix.patch
>
> This patch will later appear in the mm-hotfixes-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next via various
> branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there most days
>
Hi Andrew,

The patch below is what I suggested. Lorenzo, could you let me know if
you are OK with it. Thanks.

From 94d78f3d6ba2c1acb841535f934eeef4053c531c Mon Sep 17 00:00:00 2001
From: Zi Yan <ziy@nvidia.com>
Date: Sat, 29 Aug 2026 10:02:02 -0400
Subject: [PATCH] renames for Lorenzo's
 mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings patch

Signed-off-by: Zi Yan <ziy@nvidia.com>
---
 mm/huge_memory.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 4bf7b670586df..1e5d68acf62a5 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -118,7 +118,7 @@ static bool vma_is_special_huge(const struct vm_area_struct *vma)
 	return vma_test_any(vma, VMA_PFNMAP_BIT, VMA_MIXEDMAP_BIT);
 }
 
-static bool vma_bypass_thp_tuneables_file(const struct vm_area_struct *vma,
+static bool vma_file_bypass_thp_tuneables(const struct vm_area_struct *vma,
 		enum tva_type type)
 {
 	const bool has_huge_fault = vma->vm_ops->huge_fault;
@@ -132,7 +132,7 @@ static bool vma_bypass_thp_tuneables_file(const struct vm_area_struct *vma,
 	return false;
 }
 
-static bool vma_thp_tuneables_allow_file(vm_flags_t vm_flags)
+static bool vma_file_allow_thp_tuneables(vm_flags_t vm_flags)
 {
 	/* THP=always? */
 	if (hugepage_global_always())
@@ -143,11 +143,11 @@ static bool vma_thp_tuneables_allow_file(vm_flags_t vm_flags)
 	return false;
 }
 
-static bool vma_check_thp_tuneables_file(const struct vm_area_struct *vma,
+static bool vma_file_check_thp_tuneables(const struct vm_area_struct *vma,
 		vm_flags_t vm_flags, enum tva_type type)
 {
-	return vma_bypass_thp_tuneables_file(vma, type) ||
-		vma_thp_tuneables_allow_file(vm_flags);
+	return vma_file_bypass_thp_tuneables(vma, type) ||
+		vma_file_allow_thp_tuneables(vm_flags);
 }
 
 static bool vma_can_map_huge_file(const struct vm_area_struct *vma,
@@ -159,7 +159,7 @@ static bool vma_can_map_huge_file(const struct vm_area_struct *vma,
 	 * Enforce THP collapse requirements as necessary. Anonymous vmas
 	 * were already handled in thp_vma_allowable_orders().
 	 */
-	if (!vma_check_thp_tuneables_file(vma, vm_flags, type))
+	if (!vma_file_check_thp_tuneables(vma, vm_flags, type))
 		return false;
 
 	switch (type) {
-- 
2.53.0


> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings-fix
> Date: Fri Aug 28 10:35:55 AM PDT 2026
>
> s/vma_check_thp_tuneables_file/vma_file_check_thp_tuneables/, per Zi Yan
>
> Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
> Cc: Barry Song <baohua@kernel.org>
> Cc: Cedric Le Goater <clg@redhat.com>
> Cc: David Hildenbrand <david@kernel.org>
> Cc: Dev Jain <dev.jain@arm.com>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Lance Yang <lance.yang@linux.dev>
> Cc: Liam R. Howlett <liam@infradead.org>
> Cc: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Cc: Saravanan D <saravanand@crusoe.ai>
> Cc: Zi Yan <ziy@nvidia.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  mm/huge_memory.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/mm/huge_memory.c~mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings-fix
> +++ a/mm/huge_memory.c
> @@ -143,7 +143,7 @@ static bool vma_thp_tuneables_allow_file
>  	return false;
>  }
>  
> -static bool vma_check_thp_tuneables_file(const struct vm_area_struct *vma,
> +static bool vma_file_check_thp_tuneables(const struct vm_area_struct *vma,
>  		vm_flags_t vm_flags, enum tva_type type)
>  {
>  	return vma_bypass_thp_tuneables_file(vma, type) ||
> @@ -159,7 +159,7 @@ static bool vma_can_map_huge_file(const
>  	 * Enforce THP collapse requirements as necessary. Anonymous vmas
>  	 * were already handled in thp_vma_allowable_orders().
>  	 */
> -	if (!vma_check_thp_tuneables_file(vma, vm_flags, type))
> +	if (!vma_file_check_thp_tuneables(vma, vm_flags, type))
>  		return false;
>  
>  	switch (type) {
> _
>
> Patches currently in -mm which might be from akpm@linux-foundation.org are
>
> mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings-fix.patch
> drivers-media-v4l2-core-v4l2-vp9c-reduce-inlining.patch




-- 
Best Regards,
Yan, Zi


      reply	other threads:[~2026-08-29 14:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 17:38 + mm-huge_memory-bypass-thp-tuneables-for-huge-pfnmap-mappings-fix.patch added to mm-hotfixes-unstable branch Andrew Morton
2026-08-29 14:07 ` Zi Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DL1HIHWYJ7TB.1CY76SJS0V03L@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=clg@redhat.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=jgg@ziepe.ca \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=ljs@kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=peterx@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=saravanand@crusoe.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.