From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>
Cc: "Sophon Zhang via B4 Relay"
<devnull+aiqubits.hotmail.com@kernel.org>,
aiqubits@hotmail.com, "Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Onur Özkan" <work@onurozkan.dev>,
linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] rust: pci: reject IRQ vector indices that do not fit in u32
Date: Tue, 01 Sep 2026 13:08:58 +0200 [thread overview]
Message-ID: <DL3XLHXS647M.1LMHQUVX5RTI@kernel.org> (raw)
In-Reply-To: <DL3XDBBHXKKV.G9P6KRSSX1DN@nvidia.com>
On Tue Sep 1, 2026 at 12:58 PM CEST, Alexandre Courbot wrote:
> That makes me wonder, shouldn't we make `index` take a `u32` directly?
> If that's what the C API expects, it does make sense to align to it
> instead of forcing users to make a potential unneeded conversion if they
> already have a u32.
I intentionally did not do this, as the common type for an index is usize. Thus,
I do not expect anyone to already have a u32, but to already have a usize, e.g.
from some iterator.
The fact that the C API did pick unsigned int as index type is an implementation
detail the abstraction should bother with.
next prev parent reply other threads:[~2026-09-01 11:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 17:09 [PATCH v4] rust: pci: reject IRQ vector indices that do not fit in u32 Sophon Zhang via B4 Relay
2026-08-31 17:09 ` Sophon Zhang
2026-08-31 19:46 ` sashiko-bot
[not found] ` <SN7PR07MB9708A97EA2A41E601D4E9C9ACFA82@SN7PR07MB9708.namprd07.prod.outlook.com>
2026-09-01 9:37 ` 回复: " ai qubits
2026-09-01 10:58 ` Alexandre Courbot
2026-09-01 11:08 ` Danilo Krummrich [this message]
2026-09-01 13:32 ` Alexandre Courbot
2026-09-01 13:36 ` Danilo Krummrich
2026-09-01 13:52 ` Alexandre Courbot
2026-09-01 13:48 ` Gary Guo
2026-09-01 14:08 ` Alexandre Courbot
2026-09-01 15:58 ` 回复: " ai qubits
2026-09-01 11:47 ` ai qubits
2026-09-01 12:06 ` Gary Guo
2026-09-01 12:35 ` 回复: " ai qubits
2026-09-01 12:42 ` Miguel Ojeda
2026-09-01 16:19 ` Gary Guo
2026-09-01 16:31 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL3XLHXS647M.1LMHQUVX5RTI@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aiqubits@hotmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=devnull+aiqubits.hotmail.com@kernel.org \
--cc=gary@garyguo.net \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.