All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: <peter.marko@siemens.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [wrynose][PATCH 1/3] libslirp: fix upstream version check
Date: Thu, 03 Sep 2026 22:45:44 +0200	[thread overview]
Message-ID: <DL5Z475KF36A.2GWHJC82115IA@smile.fr> (raw)
In-Reply-To: <20260823155741.2091982-1-peter.marko@siemens.com>

On Sun Aug 23, 2026 at 5:57 PM CEST, Peter Marko via lists.openembedded.org wrote:
> From: Alexander Kanavin <alex@linutronix.de>
>
> The regex excludes bogus old yyyymmdd tags which sort higher than real versions.
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (From OE-Core rev: 2a60e5db4460cd8ec99b43d8f2ff733ba509c373)
> Signed-off-by: Peter Marko <peter.marko@siemens.com>
> ---
>  meta/recipes-connectivity/slirp/libslirp_4.9.1.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-connectivity/slirp/libslirp_4.9.1.bb b/meta/recipes-connectivity/slirp/libslirp_4.9.1.bb
> index 9f7005d709..50577fd4ae 100644
> --- a/meta/recipes-connectivity/slirp/libslirp_4.9.1.bb
> +++ b/meta/recipes-connectivity/slirp/libslirp_4.9.1.bb
> @@ -6,6 +6,7 @@ LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=bca0186b14e6b05e338e729f106db727"
>  
>  SRC_URI = "git://gitlab.freedesktop.org/slirp/libslirp.git;protocol=https;branch=master"
>  SRCREV = "9c744e1e52aa0d9646ed91d789d588696292c21e"
> +UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
>  
>  DEPENDS = "glib-2.0"
>  

Hello Peter,

Thanks for the series. But, with regrets, I don't think it is acceptable
under the policy:
* 1&3/3 are not bug fixes (UPSTREAM_CHECK_GITTAGREGEX is not used right
  now on stables)
* 2/3 is the upgrade. It contains: 
  "Changed: bootp: allow https for UEFI HTTP boot"
  and that is a feature change (even if, behind it there is only a one
  line change)

I think you did this backport to fix CVE-2026-9539. I think we'll have
to backport the fix, (like you did on scarthgap).

Thanks!
-- 
Yoann Congal
Smile ECS



  parent reply	other threads:[~2026-09-03 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 15:57 [wrynose][PATCH 1/3] libslirp: fix upstream version check Peter Marko
2026-08-23 15:57 ` [wrynose][PATCH 2/3] libslirp: upgrade 4.9.1 -> 4.9.3 Peter Marko
2026-08-23 15:57 ` [wrynose][PATCH 3/3] libslirp: add tag in SRC_URI Peter Marko
2026-09-03 20:45 ` Yoann Congal [this message]
2026-09-04 12:38   ` [OE-core] [wrynose][PATCH 1/3] libslirp: fix upstream version check Alexander Kanavin
2026-09-12 16:12     ` Marko, Peter
2026-09-14 14:18       ` Yoann Congal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DL5Z475KF36A.2GWHJC82115IA@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.marko@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.