All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>
To: "Jan Kiszka" <jan.kiszka@siemens.com>,
	"U-Boot Mailing List" <u-boot@lists.u-boot-project.org>
Cc: "Jens Wiklander" <jens.wiklander@oss.qualcomm.com>,
	"Sai Sree Kartheek Adivi" <s-adivi@ti.com>,
	"Alexander Heinisch" <alexander.heinisch@siemens.com>,
	"Tanmay Kathpalia" <tanmay.kathpalia@altera.com>
Subject: Re: [PATCH v2 3/5] tee: optee: Do not warn about TEE_ERROR_STORAGE_NOT_AVAILABLE
Date: Tue, 08 Sep 2026 10:15:24 +0300	[thread overview]
Message-ID: <DL9R0HDE15M7.1NFT7IXOOHCZ4@linaro.org> (raw)
In-Reply-To: <13fc430cf440cdbc490bce630031ca49e81e1e13.1787514446.git.jan.kiszka@siemens.com>

Hi Jan

On Sun Aug 23, 2026 at 10:47 PM EEST, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This is a transitional error that is resolved once an RPMB becomes
> available. Keep it as debug output only.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  drivers/tee/optee/core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index ed8f2b6ec74..d3b5811afb8 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -106,7 +106,10 @@ static int __enum_services(struct udevice *dev, struct tee_shm *shm, size_t *shm
>
>  	ret = tee_invoke_func(dev, &arg, 1, &param);
>  	if (ret || (arg.ret && arg.ret != TEE_ERROR_SHORT_BUFFER)) {
> -		dev_err(dev, "Enumeration command 0x%x failed: 0x%x\n", pta_cmd, arg.ret);
> +		if (arg.ret != TEE_ERROR_STORAGE_NOT_AVAILABLE)
> +			dev_err(dev, "Enumeration command 0x%x failed: 0x%x\n", pta_cmd, arg.ret);
> +		else
> +			dev_dbg(dev, "Enumeration command 0x%x failed due to unavailable storage\n", pta_cmd);

I don't mind changing this and I like the different error messages. Isn't the dgb message useful for
users though? Or it is something that's not expected to happen in production systems so we can hide
it?

Cheers
/Ilias
>  		return -EINVAL;
>  	}
>


  reply	other threads:[~2026-09-08  7:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 19:47 [PATCH v2 0/5] optee: Add support for enumerating RPMB-dependent services Jan Kiszka
2026-08-23 19:47 ` [PATCH v2 1/5] tee: optee: Factor out service enumeration and binding functions Jan Kiszka
2026-09-08  7:08   ` Ilias Apalodimas
2026-09-08  9:47     ` Jan Kiszka
2026-09-08  9:53       ` Jan Kiszka
2026-09-08 10:34         ` Ilias Apalodimas
2026-08-23 19:47 ` [PATCH v2 2/5] tee: optee: Add support for enumerating services that only need RPMB Jan Kiszka
2026-09-08  7:25   ` Ilias Apalodimas
2026-09-08 10:55     ` Jan Kiszka
2026-09-08 11:55       ` Ilias Apalodimas
2026-08-23 19:47 ` [PATCH v2 3/5] tee: optee: Do not warn about TEE_ERROR_STORAGE_NOT_AVAILABLE Jan Kiszka
2026-09-08  7:15   ` Ilias Apalodimas [this message]
2026-09-08 11:01     ` Jan Kiszka
2026-09-08 11:54       ` Ilias Apalodimas
2026-08-23 19:47 ` [PATCH v2 4/5] mmc: Call back to optee after a successful mmc_init Jan Kiszka
2026-08-26  8:44   ` Peng Fan
2026-08-26 10:10     ` Kathpalia, Tanmay
2026-08-23 19:47 ` [PATCH v2 5/5] mmc: Make "MMC Device not found" a debug output Jan Kiszka
2026-08-26  8:44   ` Peng Fan
2026-08-26 10:10     ` Kathpalia, Tanmay
2026-09-08  7:12   ` Ilias Apalodimas
2026-09-08  7:43     ` Kathpalia, Tanmay
2026-09-08  9:36 ` [PATCH v2 0/5] optee: Add support for enumerating RPMB-dependent services Ilias Apalodimas
2026-09-08  9:43   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DL9R0HDE15M7.1NFT7IXOOHCZ4@linaro.org \
    --to=ilias.apalodimas@linaro.org \
    --cc=alexander.heinisch@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jens.wiklander@oss.qualcomm.com \
    --cc=s-adivi@ti.com \
    --cc=tanmay.kathpalia@altera.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.