From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFA41C79FAD for ; Wed, 9 Sep 2026 10:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Swv7G4AMACBP0/DDEP2NTg19JOTBfq8mifMIqt2q5Q=; b=RHbObKjzcD/n2f nIyiQCKZtha2q+/YXngUa2c2tg0Lz8umTdMKNn2hgQx6iT2aEvy2CHJVBXY/SgrZO8kVHc0p2X7uw FpvwZCgW1FAOJn5fhSrdCpCjfxwzEHPmnXoTk6iE/gIO/4eeQINnve4EUmkUdW7/8KI7W9aoMkenu HoGdVD5x3Sdr4Rr8Rgta0DRdqRrblPJvMES+LtT18+Sw+aYT07CVtRWfzyTyw2pIX0T1APaTA4Skg IhQ2IA3Hsgfoyj7rlxiPAcmIPQkYVld7SGm+8ItiU4BklyEmo/2Z12Ytqg8NFVlPE3M0xs9HNT8lr 80/vzfVY+1jtRj/FEG0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4Fvf-0000000BUSX-112W; Wed, 09 Sep 2026 10:53:23 +0000 Received: from out-238.mta1.migadu.com ([95.215.58.238] helo=mta1.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4Fvb-0000000BUQS-1IjU for linux-rockchip@lists.infradead.org; Wed, 09 Sep 2026 10:53:21 +0000 X-Envelope-To: linux-rockchip@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=ut1UAXDx2kgEZTQBPOYbxfS9ZaWvfArbNUvkXw4DAXs=; c=simple/simple; d=cknow-tech.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788951195; v=1; x=1789555995; b=ZFOn4/Ve548OUpVoEXY1A6leJIscWg5Up+GNEKYBXqTlYOLTMqadaRubzC44SJ8DEJNkp0KP 8xHDQdwMkcGLvE3yYrI71nz/R5LdJ4m1LVm/pHhdQvEaD2aegHFBNroLf/Bn3pwt/v+e28PmoRC Xan8IOEZ7SfsaaC/eHbl1bPvsPapKwEobbEOhi3iFHTSaR7NATo4Q5sLd87nIqmOHZu8kC2mM4F vhhJQMlpe6QJxGNDljfZl9L1j0eZCByrIwUc6gxjmlmhkrfD1tbUW5Pc6iVUxX01FTCJW6Xuk9L sMOP+PYLczf0PyoewkdZXQVwpnEwEg5DElSjWKND+AbjQ== X-Envelope-To: linux-rockchip@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 7dc79fa296131603; Wed, 09 Sep 2026 10:53:15 +0000 X-Mizu-Trace-ID: 7dc79fa296131603 X-Migadu-Flow: FLOW_OUT Mime-Version: 1.0 Date: Wed, 09 Sep 2026 12:53:14 +0200 Message-Id: Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add devicetree for the FriendlyElec NanoPi R28S From: "Diederik de Haas" To: , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" Cc: , , , , "Chukun Pan" , "jensen" X-Mailer: aerc 0.22.0-9-ge948bb7230f4 References: <20260907-r28s-upstream-v2-0-21ab570fc91c@proton.me> <20260907-r28s-upstream-v2-3-21ab570fc91c@proton.me> In-Reply-To: <20260907-r28s-upstream-v2-3-21ab570fc91c@proton.me> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260909_035319_595666_BBBF681B X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gTW9uIFNlcCA3LCAyMDI2IGF0IDQ6MTMgUE0gQ0VTVCwg5a6J5a65IHZpYSBCNCBSZWxheSB3 cm90ZToKPiBGcm9tOiDlronlrrkgPEh5c3RlcmljYWxEcmFnb25zQHByb3Rvbi5tZT4KPgo+IFRo ZSBOYW5vUGkgUjI4UyBpcyBhIGR1YWwgZ2lnYWJpdCBFdGhlcm5ldCByb3V0ZXIgYm9hcmQgYmFz ZWQgb24gdGhlCj4gUm9ja2NoaXAgUkszNTI4IFNvQywgZGVzaWduZWQgYW5kIGRldmVsb3BlZCBi eSBGcmllbmRseUVsZWMuIEl0IHNoYXJlcwo+IG1vc3Qgb2YgaXRzIGRlc2lnbiB3aXRoIHRoZSBO YW5vUGkgWmVybzIsIHNvIGl0IGJ1aWxkcyBvbiB0aGUgY29tbW9uCj4gcmszNTI4LW5hbm9waS5k dHNpLgo+Cj4gU3BlY2lmaWNhdGlvbjoKPiAtIFJvY2tjaGlwIFJLMzUyOAo+IC0gMUdCIFJBTQo+ IC0gZU1NQyBzb2NrZXQgKG9wdGlvbmFsKQo+IC0gTWljcm9TRCBzbG90Cj4gLSAxeCAxMDAwQmFz ZS1UIChHTUFDMSwgUmVhbHRlayBSVEw4MjExRikKPiAtIDF4IDEwMDBCYXNlLVQgKFBDSWUsIFJl YWx0ZWsgUlRMODExMUgpCj4gLSBBSUNTZW1pIEFJQzg4MDBEODAgU0RJTyBXaUZpCj4gLSAzeCBM RURzIChTWVMsIExBTiwgV0FOKQo+IC0gMXggVVNCIDIuMCBUeXBlLUMsIHBlcmlwaGVyYWwgb25s eSwgc2hhcmVkIHdpdGggdGhlIDVWIHBvd2VyIGlucHV0Cj4gLSBVc2VyIGFuZCBNYXNrUk9NIGJ1 dHRvbnMKPiAtIEhhb3l1IEhZTTg1NjMgUlRDCj4gLSAxeCBVU0IgVHlwZS1DIGRlYnVnIFVBUlQg KG9uYm9hcmQgV0NIIENIMzQwRSkKPgo+IEFzc2lzdGVkLWJ5OiBMTE0KPiBTaWduZWQtb2ZmLWJ5 OiDlronlrrkgPEh5c3RlcmljYWxEcmFnb25zQHByb3Rvbi5tZT4KPiAtLS0KPiAgYXJjaC9hcm02 NC9ib290L2R0cy9yb2NrY2hpcC9NYWtlZmlsZSAgICAgICAgICAgICAgfCAgIDEgKwo+ICAuLi4v YXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTI4LW5hbm9waS1yMjhzLmR0cyB8IDE0MiArKysr KysrKysrKysrKysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNDMgaW5zZXJ0aW9ucygrKQo+ Cj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvTWFrZWZpbGUgYi9h cmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL01ha2VmaWxlCj4gaW5kZXggYjY3NzkxNGNkMy4u NTFhOTg4OTA4OCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL01h a2VmaWxlCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9NYWtlZmlsZQo+IEBA IC05NCw2ICs5NCw3IEBAIGR0Yi0kKENPTkZJR19BUkNIX1JPQ0tDSElQKSArPSByazMzOTktdmlj aGFyYWstdmFhbWFuLmR0Ygo+ICBkdGItJChDT05GSUdfQVJDSF9ST0NLQ0hJUCkgKz0gcmszMzk5 cHJvLXJvY2stcGktbjEwLmR0Ygo+ICBkdGItJChDT05GSUdfQVJDSF9ST0NLQ0hJUCkgKz0gcmsz NTI4LWFybXNvbS1zaWdlMS5kdGIKPiAgZHRiLSQoQ09ORklHX0FSQ0hfUk9DS0NISVApICs9IHJr MzUyOC1oaW5saW5rLWgyOGsuZHRiCj4gK2R0Yi0kKENPTkZJR19BUkNIX1JPQ0tDSElQKSArPSBy azM1MjgtbmFub3BpLXIyOHMuZHRiCj4gIGR0Yi0kKENPTkZJR19BUkNIX1JPQ0tDSElQKSArPSBy azM1MjgtbmFub3BpLXplcm8yLmR0Ygo+ICBkdGItJChDT05GSUdfQVJDSF9ST0NLQ0hJUCkgKz0g cmszNTI4LXJhZHhhLWUyMGMuZHRiCj4gIGR0Yi0kKENPTkZJR19BUkNIX1JPQ0tDSElQKSArPSBy azM1Mjgtcm9jay0yYS5kdGIKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2Nr Y2hpcC9yazM1MjgtbmFub3BpLXIyOHMuZHRzIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazM1MjgtbmFub3BpLXIyOHMuZHRzCgpJZiB5b3UgcnVuCmBgc2NyaXB0cy9kdGMvZHQtY2hl Y2stc3R5bGUgLS1tb2RlPXN0cmljdCBhcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzUy OC1uYW5vcGktcjI4cy5kdHNgYAoKaXQgd2lsbCBmaW5kIGEgZmV3IChJTU8pIGZhbHNlLXBvc2l0 aXZlcywgYnV0IHRoZSBwcm9wZXJ0eSBvcmRlciBvZgpwaW5jdHJsLTAvcGluY3RybC1uYW1lcyBp cyB2YWxpZCBhbmQgYSBibGFuayBsaW5lIHByZWNlZWRpbmcgYGBzdGF0dXNgYCB0b28uCgpDaGVl cnMsCiAgRGllZGVyaWsKCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAw Li5iOWU5ZjVhZjRlCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMv cm9ja2NoaXAvcmszNTI4LW5hbm9waS1yMjhzLmR0cwo+IEBAIC0wLDAgKzEsMTQyIEBACj4gKy8v IFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMCsgT1IgTUlUKQo+ICsvKgo+ICsgKiBD b3B5cmlnaHQgKGMpIDIwMjIgUm9ja2NoaXAgRWxlY3Ryb25pY3MgQ28uLCBMdGQuCj4gKyAqIENv cHlyaWdodCAoYykgMjAyNiBGcmllbmRseUVsZWMgQ29tcHV0ZXIgVGVjaC4gQ28uLCBMdGQuCj4g KyAqIENvcHlyaWdodCAoYykgMjAyNiDlronlrrkgPEh5c3RlcmljYWxEcmFnb25zQHByb3Rvbi5t ZT4KPiArICovCj4gKwo+ICsvZHRzLXYxLzsKPiArCj4gKyNpbmNsdWRlIDxkdC1iaW5kaW5ncy9s ZWRzL2NvbW1vbi5oPgo+ICsjaW5jbHVkZSAicmszNTI4LW5hbm9waS5kdHNpIgo+ICsKPiArLyB7 Cj4gKwltb2RlbCA9ICJGcmllbmRseUVsZWMgTmFub1BpIFIyOFMiOwo+ICsJY29tcGF0aWJsZSA9 ICJmcmllbmRseWFybSxuYW5vcGktcjI4cyIsICJyb2NrY2hpcCxyazM1MjgiOwo+ICsKPiArCWFs aWFzZXMgewo+ICsJCW1tYzIgPSAmc2RpbzA7Cj4gKwl9Owo+ICsKPiArCWdwaW8ta2V5cyB7Cj4g KwkJY29tcGF0aWJsZSA9ICJncGlvLWtleXMiOwo+ICsJCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVs dCI7Cj4gKwkJcGluY3RybC0wID0gPCZ1c3JfYnRuPjsKPiArCj4gKwkJYnV0dG9uLXVzZXIgewo+ ICsJCQlkZWJvdW5jZS1pbnRlcnZhbCA9IDw1MD47Cj4gKwkJCWdwaW9zID0gPCZncGlvNCBSS19Q QjIgR1BJT19BQ1RJVkVfTE9XPjsKPiArCQkJbGFiZWwgPSAiVVNFUiI7Cj4gKwkJCWxpbnV4LGNv ZGUgPSA8S0VZX1JFU1RBUlQ+Owo+ICsJCQl3YWtldXAtc291cmNlOwo+ICsJCX07Cj4gKwl9Owo+ ICsKPiArCWxlZHMgewo+ICsJCWNvbXBhdGlibGUgPSAiZ3Bpby1sZWRzIjsKPiArCQlwaW5jdHJs LW5hbWVzID0gImRlZmF1bHQiOwo+ICsJCXBpbmN0cmwtMCA9IDwmbGVkMT4sIDwmbGVkMj4sIDwm bGVkX3N5cz47Cj4gKwo+ICsJCWxlZC1sYW4gewo+ICsJCQljb2xvciA9IDxMRURfQ09MT1JfSURf R1JFRU4+Owo+ICsJCQlkZWZhdWx0LXN0YXRlID0gIm9mZiI7Cj4gKwkJCWZ1bmN0aW9uID0gTEVE X0ZVTkNUSU9OX0xBTjsKPiArCQkJZ3Bpb3MgPSA8JmdwaW80IFJLX1BCMyBHUElPX0FDVElWRV9I SUdIPjsKPiArCQkJbGludXgsZGVmYXVsdC10cmlnZ2VyID0gIm5ldGRldiI7Cj4gKwkJfTsKPiAr Cj4gKwkJbGVkLXN5cyB7Cj4gKwkJCWNvbG9yID0gPExFRF9DT0xPUl9JRF9SRUQ+Owo+ICsJCQlk ZWZhdWx0LXN0YXRlID0gIm9uIjsKPiArCQkJZnVuY3Rpb24gPSBMRURfRlVOQ1RJT05fSEVBUlRC RUFUOwo+ICsJCQlncGlvcyA9IDwmZ3BpbzQgUktfUEIwIEdQSU9fQUNUSVZFX0hJR0g+Owo+ICsJ CQlsaW51eCxkZWZhdWx0LXRyaWdnZXIgPSAiaGVhcnRiZWF0IjsKPiArCQl9Owo+ICsKPiArCQls ZWQtd2FuIHsKPiArCQkJY29sb3IgPSA8TEVEX0NPTE9SX0lEX0dSRUVOPjsKPiArCQkJZGVmYXVs dC1zdGF0ZSA9ICJvZmYiOwo+ICsJCQlmdW5jdGlvbiA9IExFRF9GVU5DVElPTl9XQU47Cj4gKwkJ CWdwaW9zID0gPCZncGlvNCBSS19QQjEgR1BJT19BQ1RJVkVfSElHSD47Cj4gKwkJCWxpbnV4LGRl ZmF1bHQtdHJpZ2dlciA9ICJuZXRkZXYiOwo+ICsJCX07Cj4gKwl9Owo+ICsKPiArCXNkaW9fcHdy c2VxOiBzZGlvLXB3cnNlcSB7Cj4gKwkJY29tcGF0aWJsZSA9ICJtbWMtcHdyc2VxLXNpbXBsZSI7 Cj4gKwkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiArCQlwaW5jdHJsLTAgPSA8JnB3cl93 Zj47Cj4gKwkJcG9zdC1wb3dlci1vbi1kZWxheS1tcyA9IDwxMDA+Owo+ICsJCXJlc2V0LWdwaW9z ID0gPCZncGlvMSBSS19QQzIgR1BJT19BQ1RJVkVfTE9XPjsKPiArCX07Cj4gK307Cj4gKwo+ICsm Y29tYnBoeSB7Cj4gKwlzdGF0dXMgPSAib2theSI7Cj4gK307Cj4gKwo+ICsmcGNpZSB7Cj4gKwlw aW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ICsJcGluY3RybC0wID0gPCZwY2llX2V0aF9wZXJz dGI+Owo+ICsJcmVzZXQtZ3Bpb3MgPSA8JmdwaW80IFJLX1BDMCBHUElPX0FDVElWRV9ISUdIPjsK PiArCXZwY2llM3YzLXN1cHBseSA9IDwmdmNjXzN2Mz47Cj4gKwlzdGF0dXMgPSAib2theSI7Cj4g K307Cj4gKwo+ICsmcGluY3RybCB7Cj4gKwlncGlvLWtleXMgewo+ICsJCXVzcl9idG46IHVzci1i dG4gewo+ICsJCQlyb2NrY2hpcCxwaW5zID0gPDQgUktfUEIyIFJLX0ZVTkNfR1BJTyAmcGNmZ19w dWxsX3VwPjsKPiArCQl9Owo+ICsJfTsKPiArCj4gKwlsZWRzIHsKPiArCQlsZWQxOiBsZWQxIHsK PiArCQkJcm9ja2NoaXAscGlucyA9IDw0IFJLX1BCMSBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9u b25lPjsKPiArCQl9Owo+ICsKPiArCQlsZWQyOiBsZWQyIHsKPiArCQkJcm9ja2NoaXAscGlucyA9 IDw0IFJLX1BCMyBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9ub25lPjsKPiArCQl9Owo+ICsKPiAr CQlsZWRfc3lzOiBsZWQtc3lzIHsKPiArCQkJcm9ja2NoaXAscGlucyA9IDw0IFJLX1BCMCBSS19G VU5DX0dQSU8gJnBjZmdfcHVsbF9ub25lPjsKPiArCQl9Owo+ICsJfTsKPiArCj4gKwlwY2llIHsK PiArCQlwY2llX2V0aF9wZXJzdGI6IHBjaWUtZXRoLXBlcnN0YiB7Cj4gKwkJCXJvY2tjaGlwLHBp bnMgPSA8NCBSS19QQzAgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47Cj4gKwkJfTsKPiAr CX07Cj4gKwo+ICsJd2lmaSB7Cj4gKwkJcHdyX3dmOiBwd3Itd2Ygewo+ICsJCQlyb2NrY2hpcCxw aW5zID0gPDEgUktfUEMyIFJLX0ZVTkNfR1BJTyAmcGNmZ19wdWxsX25vbmU+Owo+ICsJCX07Cj4g Kwl9Owo+ICt9Owo+ICsKPiArJnNkaW8wIHsKPiArCWJ1cy13aWR0aCA9IDw0PjsKPiArCWNhcC1z ZC1oaWdoc3BlZWQ7Cj4gKwljYXAtc2Rpby1pcnE7Cj4gKwlrZWVwLXBvd2VyLWluLXN1c3BlbmQ7 Cj4gKwltbWMtcHdyc2VxID0gPCZzZGlvX3B3cnNlcT47Cj4gKwlub24tcmVtb3ZhYmxlOwo+ICsJ c2QtdWhzLXNkcjEwNDsKPiArCXZxbW1jLXN1cHBseSA9IDwmdmNjXzF2OD47Cj4gKwlzdGF0dXMg PSAib2theSI7Cj4gK307Cj4gKwo+ICsmdWFydDIgewo+ICsJcGluY3RybC1uYW1lcyA9ICJkZWZh dWx0IjsKPiArCXBpbmN0cmwtMCA9IDwmdWFydDJtMV94ZmVyPiwgPCZ1YXJ0Mm0xX2N0c24+LCA8 JnVhcnQybTFfcnRzbj47Cj4gKwl1YXJ0LWhhcy1ydHNjdHM7Cj4gKwlzdGF0dXMgPSAib2theSI7 Cj4gK307Cj4gKwo+ICsmdXNiX2hvc3QwX3hoY2kgewo+ICsJLyogVHlwZS1DIHBvcnQsIHNoYXJl ZCB3aXRoIHRoZSA1ViBwb3dlciBpbnB1dCAqLwo+ICsJZHJfbW9kZSA9ICJwZXJpcGhlcmFsIjsK PiArfTsKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1y b2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-42.mta0.migadu.com [91.218.175.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E56526A9E for ; Wed, 9 Sep 2026 10:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951203; cv=none; b=bZEQWCvTGu+4PujuL/EHgz78Fs4soqenuUrnHCouDDgwu+9ilWk8SD6Jh1mhH2biARlqPz8cUILGf5P6vF6Z+liuL3iCSKOJNd6W2A4Noqe9PKmt9MX0LgzOrMentL3Fgq1y7ZG8wLmn97mGxxA0zF38r3flYMksJhsH6y0dL7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951203; c=relaxed/simple; bh=ut1UAXDx2kgEZTQBPOYbxfS9ZaWvfArbNUvkXw4DAXs=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=ZnGZP4I8jSZ4EYDTVKKUr/flUYqevbCMbiB0DEMm1bQ8CvqG2dV7AEQu0OPJN/7XsnyOFUbuTNfn63ik4K8iZq/y/F4ZlQDUyWumjAZLHoKyvKqJ/MJyMXqZSnyT0PsKsBApluazKEBQawCPFqdtZQMNJdWfnW7BTPH0aogAkI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=ZFOn4/Ve; arc=none smtp.client-ip=91.218.175.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="ZFOn4/Ve" X-Envelope-To: devicetree@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=ut1UAXDx2kgEZTQBPOYbxfS9ZaWvfArbNUvkXw4DAXs=; c=simple/simple; d=cknow-tech.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788951195; v=1; x=1789555995; b=ZFOn4/Ve548OUpVoEXY1A6leJIscWg5Up+GNEKYBXqTlYOLTMqadaRubzC44SJ8DEJNkp0KP 8xHDQdwMkcGLvE3yYrI71nz/R5LdJ4m1LVm/pHhdQvEaD2aegHFBNroLf/Bn3pwt/v+e28PmoRC Xan8IOEZ7SfsaaC/eHbl1bPvsPapKwEobbEOhi3iFHTSaR7NATo4Q5sLd87nIqmOHZu8kC2mM4F vhhJQMlpe6QJxGNDljfZl9L1j0eZCByrIwUc6gxjmlmhkrfD1tbUW5Pc6iVUxX01FTCJW6Xuk9L sMOP+PYLczf0PyoewkdZXQVwpnEwEg5DElSjWKND+AbjQ== X-Envelope-To: devicetree@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 7dc79fa296131603; Wed, 09 Sep 2026 10:53:15 +0000 X-Mizu-Trace-ID: 7dc79fa296131603 X-Migadu-Flow: FLOW_OUT Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 09 Sep 2026 12:53:14 +0200 Message-Id: Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add devicetree for the FriendlyElec NanoPi R28S From: "Diederik de Haas" To: , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" Cc: , , , , "Chukun Pan" , "jensen" X-Mailer: aerc 0.22.0-9-ge948bb7230f4 References: <20260907-r28s-upstream-v2-0-21ab570fc91c@proton.me> <20260907-r28s-upstream-v2-3-21ab570fc91c@proton.me> In-Reply-To: <20260907-r28s-upstream-v2-3-21ab570fc91c@proton.me> On Mon Sep 7, 2026 at 4:13 PM CEST, =E5=AE=89=E5=AE=B9 via B4 Relay wrote: > From: =E5=AE=89=E5=AE=B9 > > The NanoPi R28S is a dual gigabit Ethernet router board based on the > Rockchip RK3528 SoC, designed and developed by FriendlyElec. It shares > most of its design with the NanoPi Zero2, so it builds on the common > rk3528-nanopi.dtsi. > > Specification: > - Rockchip RK3528 > - 1GB RAM > - eMMC socket (optional) > - MicroSD slot > - 1x 1000Base-T (GMAC1, Realtek RTL8211F) > - 1x 1000Base-T (PCIe, Realtek RTL8111H) > - AICSemi AIC8800D80 SDIO WiFi > - 3x LEDs (SYS, LAN, WAN) > - 1x USB 2.0 Type-C, peripheral only, shared with the 5V power input > - User and MaskROM buttons > - Haoyu HYM8563 RTC > - 1x USB Type-C debug UART (onboard WCH CH340E) > > Assisted-by: LLM > Signed-off-by: =E5=AE=89=E5=AE=B9 > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts | 142 +++++++++++++++= ++++++ > 2 files changed, 143 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/= rockchip/Makefile > index b677914cd3..51a9889088 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -94,6 +94,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399-vicharak-vaaman= .dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3399pro-rock-pi-n10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3528-armsom-sige1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3528-hinlink-h28k.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3528-nanopi-r28s.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3528-nanopi-zero2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3528-radxa-e20c.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3528-rock-2a.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts b/arch/a= rm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts If you run ``scripts/dtc/dt-check-style --mode=3Dstrict arch/arm64/boot/dts/rockchip/r= k3528-nanopi-r28s.dts`` it will find a few (IMO) false-positives, but the property order of pinctrl-0/pinctrl-names is valid and a blank line preceeding ``status`` too= . Cheers, Diederik > new file mode 100644 > index 0000000000..b9e9f5af4e > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-r28s.dts > @@ -0,0 +1,142 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2022 Rockchip Electronics Co., Ltd. > + * Copyright (c) 2026 FriendlyElec Computer Tech. Co., Ltd. > + * Copyright (c) 2026 =E5=AE=89=E5=AE=B9 > + */ > + > +/dts-v1/; > + > +#include > +#include "rk3528-nanopi.dtsi" > + > +/ { > + model =3D "FriendlyElec NanoPi R28S"; > + compatible =3D "friendlyarm,nanopi-r28s", "rockchip,rk3528"; > + > + aliases { > + mmc2 =3D &sdio0; > + }; > + > + gpio-keys { > + compatible =3D "gpio-keys"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&usr_btn>; > + > + button-user { > + debounce-interval =3D <50>; > + gpios =3D <&gpio4 RK_PB2 GPIO_ACTIVE_LOW>; > + label =3D "USER"; > + linux,code =3D ; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible =3D "gpio-leds"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&led1>, <&led2>, <&led_sys>; > + > + led-lan { > + color =3D ; > + default-state =3D "off"; > + function =3D LED_FUNCTION_LAN; > + gpios =3D <&gpio4 RK_PB3 GPIO_ACTIVE_HIGH>; > + linux,default-trigger =3D "netdev"; > + }; > + > + led-sys { > + color =3D ; > + default-state =3D "on"; > + function =3D LED_FUNCTION_HEARTBEAT; > + gpios =3D <&gpio4 RK_PB0 GPIO_ACTIVE_HIGH>; > + linux,default-trigger =3D "heartbeat"; > + }; > + > + led-wan { > + color =3D ; > + default-state =3D "off"; > + function =3D LED_FUNCTION_WAN; > + gpios =3D <&gpio4 RK_PB1 GPIO_ACTIVE_HIGH>; > + linux,default-trigger =3D "netdev"; > + }; > + }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible =3D "mmc-pwrseq-simple"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pwr_wf>; > + post-power-on-delay-ms =3D <100>; > + reset-gpios =3D <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&combphy { > + status =3D "okay"; > +}; > + > +&pcie { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pcie_eth_perstb>; > + reset-gpios =3D <&gpio4 RK_PC0 GPIO_ACTIVE_HIGH>; > + vpcie3v3-supply =3D <&vcc_3v3>; > + status =3D "okay"; > +}; > + > +&pinctrl { > + gpio-keys { > + usr_btn: usr-btn { > + rockchip,pins =3D <4 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > + > + leds { > + led1: led1 { > + rockchip,pins =3D <4 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > + led2: led2 { > + rockchip,pins =3D <4 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > + led_sys: led-sys { > + rockchip,pins =3D <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + pcie { > + pcie_eth_perstb: pcie-eth-perstb { > + rockchip,pins =3D <4 RK_PC0 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + wifi { > + pwr_wf: pwr-wf { > + rockchip,pins =3D <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > +}; > + > +&sdio0 { > + bus-width =3D <4>; > + cap-sd-highspeed; > + cap-sdio-irq; > + keep-power-in-suspend; > + mmc-pwrseq =3D <&sdio_pwrseq>; > + non-removable; > + sd-uhs-sdr104; > + vqmmc-supply =3D <&vcc_1v8>; > + status =3D "okay"; > +}; > + > +&uart2 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&uart2m1_xfer>, <&uart2m1_ctsn>, <&uart2m1_rtsn>; > + uart-has-rtscts; > + status =3D "okay"; > +}; > + > +&usb_host0_xhci { > + /* Type-C port, shared with the 5V power input */ > + dr_mode =3D "peripheral"; > +};