From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F6D2C79FB6 for ; Wed, 9 Sep 2026 17:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Subject:Cc:To: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4jYxSKbLmObR8MAY5C+LpQnr6O33X8gkqYlJK1YFLms=; b=GmJod+MkE1Urqn 8a//LsGiHT0n8nzE4pfY43fhFHTczh5mh3FpYKrOGn0N8vsAZqnQYgiuqdymhe/gAXD6LjSa7Nliw fhePrgX6bG22LI9V7lHOGwN6QJ/7a4Xc35QCXIRrI62I79JnKSrDwYdBT1ILObU20NWKfzNQXDKXn BQvSNTTI8we6x4lANWfP583QXSGCd9ZkIUHbQAK8B9/2kiYorEG2swRyyhAuyI1H9YQW/jA0ivaOC MFPkC9OFou28d/fE/xDEnLOatzfUvin6fyPYkCDEJzrL+rojGju9ThbAsabL+Mqacmgyq7MNERcbL W6xpjM/seCicbWK0N2og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4MJj-0000000CWiP-2myK; Wed, 09 Sep 2026 17:42:39 +0000 Received: from out-168.mta0.migadu.com ([2001:41d0:1004:224b::a8] helo=mta0.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4MJf-0000000CWgz-2bjv for linux-rockchip@lists.infradead.org; Wed, 09 Sep 2026 17:42:38 +0000 X-Envelope-To: linux-rockchip@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=fTEVGWI3xZqNHtli5O7XYQjJwsilEDuETEuMfL8uIPM=; c=simple/simple; d=cknow-tech.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788975752; v=1; x=1789580552; b=RF54K1YLN66eGsOhQnHzlvBKiZTc9tuYeIhf4Dr+eaNoqHxNappwd5aEZ142VCyb4P9UUDOm BoWRYyUtZTO7bY7aqVWH42O2gDRw67guvkL9pySNIi1HMZ5C2aQq+TLAgIV+rT8TVj/LRe9UIFh ZXo0iV0EeceA7ddksiOfyteB9kIXeItJiBD3jJNiCeGX8Onr0yxa98uMB3SMZFFTvVSoF8aywQR lKLVpssPrhFLbmebEkEIyY31IypSAVqDNLBwdHGtaD0mMoL7f5EulfuPdFkwT/WqrrQI5IUNYZr wI9T8PO03yfJKlX+IZkrPTG5YpIFhoL/kgYUqIaofqdcA== X-Envelope-To: linux-rockchip@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 29aa8afd47eb6454; Wed, 09 Sep 2026 17:42:22 +0000 X-Mizu-Trace-ID: 29aa8afd47eb6454 X-Migadu-Flow: FLOW_OUT Mime-Version: 1.0 Date: Wed, 09 Sep 2026 19:42:18 +0200 Message-Id: From: "Diederik de Haas" To: , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" Cc: , , , , "Chukun Pan" , "jensen" , "Andrey Korshunov" , "Diederik de Haas" Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: Follow the DTS coding style in the NanoPi RK3528 devicetrees X-Mailer: aerc 0.22.0-9-ge948bb7230f4 References: <20260909-r28s-upstream-v3-0-ee3e1a34a353@proton.me> <20260909-r28s-upstream-v3-5-ee3e1a34a353@proton.me> In-Reply-To: <20260909-r28s-upstream-v3-5-ee3e1a34a353@proton.me> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260909_104236_287601_3511ED11 X-CRM114-Status: GOOD ( 20.81 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gV2VkIFNlcCA5LCAyMDI2IGF0IDQ6MzMgUE0gQ0VTVCwg5a6J5a65IHZpYSBCNCBSZWxheSB3 cm90ZToKPiBGcm9tOiDlronlrrkgPEh5c3RlcmljYWxEcmFnb25zQHByb3Rvbi5tZT4KPgo+IHNj cmlwdHMvZHRjL2R0LWNoZWNrLXN0eWxlIC0tbW9kZT1zdHJpY3QgcmVwb3J0cyB0d28gZGV2aWF0 aW9ucyBmcm9tCgpJIG1lbnRpb25lZCBkdC1jaGVjay1zdHlsZSBhcyBpdCBpcyBhIHVzZWZ1bCB0 b29sIGFuZCBpdCB3b3VsZCBiZQpiZW5lZmljaWFsIGlmIG1vcmUvYWxsIGZ1dHVyZSBzdWJtaXNz aW9ucyB3ZXJlIGFsc28gY2hlY2tlZCB3aXRoIGl0LgpJIHdvdWxkIG5vdCBtYWtlIGl0IHBhcnQg b2YgdGhlIGNvbW1pdCBtZXNzYWdlIHRob3VnaC4KSnVzdCBsaWtlICdjaGVja3BhdGNoJyBpcyBh IHRvb2wgaW4gdGhlIHRvb2xib3gsIHNvIGlzIGR0LWNoZWNrLXN0eWxlLgoKPiBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZHRzLWNvZGluZy1zdHlsZS5yc3QgaW4gdGhlIHNoYXJl ZAoKQmVjYXVzZSB0aGUgYWN0dWFsIHJlYXNvbiBmb3IgdGhpcyBjaGFuZ2UgaXMgYSB2aW9sYXRp b24gb2YgdGhlIERUUyBjb2RpbmcKc3R5bGUgLi4uIHdoaWNoIEkgd291bGQgcHV0IGluIHRoZSBj b21taXQgbWVzc2FnZS4KCj4gTmFub1BpIFJLMzUyOCBkZXZpY2V0cmVlIGFuZCBpbiB0aGUgTmFu b1BpIFplcm8yIGJvYXJkIGRldmljZXRyZWU6Cj4gInBpbmN0cmwtMCIgaGFzIHRvIHNvcnQgYmVm b3JlICJwaW5jdHJsLW5hbWVzIiwgYW5kICJzdGF0dXMiIGhhcyB0byBiZQo+IHByZWNlZGVkIGJ5 IGEgYmxhbmsgbGluZSB3aGVuIHRoZSBub2RlIGhhcyBjb250ZW50IGJlZm9yZSBpdC4KPgo+IFNv cnQgdGhlIHByb3BlcnRpZXMgYW5kIGFkZCB0aGUgbWlzc2luZyBibGFuayBsaW5lcy4gVGhlIGdl bmVyYXRlZAo+IGRldmljZXRyZWUgYmxvYnMgYXJlIHVuY2hhbmdlZC4KCk1ha2luZyBleHBsaWNp dCB3aGljaCBmaXhlcyB5b3UndmUgZG9uZSBpcyBmaW5lIEFGQUlDLCBidXQgbm90IHN0cmljdGx5 Cm5lZWRlZCBhcyB0aGUgZGlmZiBhbHJlYWR5IHNob3dzIGl0LiBJIHdvdWxkIHJhdGhlciB1c2Ug Ik5vIGZ1bmN0aW9uYWwKY2hhbmdlcy4iLCBpbnN0ZWFkIG9mICdibG9icyBhcmUgdW5jaGFuZ2Vk Jy4KCj4gVGhlIHJlbWFpbmluZyBmaW5kaW5ncyBvZiB0aGUgdG9vbCBhcmUgbGVmdCBhbG9uZSwg YXMgdGhleSBjb250cmFkaWN0Cj4gdGhlIGVzdGFibGlzaGVkIHByYWN0aWNlIGluIGFyY2gvYXJt NjQvYm9vdC9kdHMvcm9ja2NoaXA6ICJtb2RlbCIKPiBiZWZvcmUgImNvbXBhdGlibGUiLCAicmVn dWxhdG9yLW5hbWUiIGJlZm9yZSB0aGUgb3RoZXIgcmVndWxhdG9yCj4gcHJvcGVydGllcywgInJl Z3VsYXRvci1taW4tbWljcm92b2x0IiBiZWZvcmUgInJlZ3VsYXRvci1tYXgtbWljcm92b2x0IiwK PiAicHdtcyIgYmVmb3JlICJwd20tc3VwcGx5IiBhbmQgImxpbnV4LGNvZGUiIGJlZm9yZSAid2Fr ZXVwLXNvdXJjZSIgb3IKPiAicHJlc3MtdGhyZXNob2xkLW1pY3Jvdm9sdCIuCgpCdXQgYXMgeW91 IG5vdGljZWQsIGl0J3Mgbm90IGZsYXdsZXNzLiBNeSBndWVzcyBpcyB0aGF0IGl0IGFjdHVhbGx5 IGRvZXMKYW4gYWxwaGFudW1lcmljYWwgc29ydCwgd2hpbGUgdGhlIERUUyBjb2Rpbmcgc3R5bGUg cHJlc2NyaWJlcyBhIG5hdHVyYWwKc29ydGluZy4gRHVubm8gaWYgdGhlcmUncyBhbiBhY3R1YWwg KGVuZm9yY2VhYmxlKSBkZWZpbml0aW9uIGZvciBpdC4KCkkgd291bGQgbm90IGxpc3Qgd2hhdCBJ IHNlZSBhcyB0b29sIGVycm9ycyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UgdGhvdWdoLgoKQUZBSUMg bm8gbmVlZCBmb3IgYSBuZXcgdmVyc2lvbiBmb3IgKGp1c3QpIHRoaXMgdGhvdWdoLgoKTXkgMC4w MgoKQ2hlZXJzLAogIERpZWRlcmlrCgo+IFN1Z2dlc3RlZC1ieTogRGllZGVyaWsgZGUgSGFhcyA8 ZGllZGVyaWtAY2tub3ctdGVjaC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog5a6J5a65IDxIeXN0ZXJp Y2FsRHJhZ29uc0Bwcm90b24ubWU+Cj4gLS0tCj4gIC4uLi9ib290L2R0cy9yb2NrY2hpcC9yazM1 MjgtbmFub3BpLXplcm8yLmR0cyAgICAgIHwgIDUgKysrLS0KPiAgYXJjaC9hcm02NC9ib290L2R0 cy9yb2NrY2hpcC9yazM1MjgtbmFub3BpLmR0c2kgICAgfCAyNiArKysrKysrKysrKysrKystLS0t LS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1MjgtbmFu b3BpLXplcm8yLmR0cyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTI4LW5hbm9w aS16ZXJvMi5kdHMKPiBpbmRleCA0OGU0MjczODcyLi45NmM1MzdkYTZhIDEwMDY0NAo+IC0tLSBh L2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTI4LW5hbm9waS16ZXJvMi5kdHMKPiAr KysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzUyOC1uYW5vcGktemVybzIuZHRz Cj4gQEAgLTI1LDggKzI1LDggQEAgYnV0dG9uLXJlY292ZXJ5IHsKPiAgCj4gIAlsZWRzIHsKPiAg CQljb21wYXRpYmxlID0gImdwaW8tbGVkcyI7Cj4gLQkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0 IjsKPiAgCQlwaW5jdHJsLTAgPSA8JmxlZDE+LCA8JmxlZF9zeXM+Owo+ICsJCXBpbmN0cmwtbmFt ZXMgPSAiZGVmYXVsdCI7Cj4gIAo+ICAJCWxlZC0wIHsKPiAgCQkJY29sb3IgPSA8TEVEX0NPTE9S X0lEX1JFRD47Cj4gQEAgLTU5LDggKzU5LDggQEAgdXNiMl9ob3N0XzV2OiByZWd1bGF0b3ItNXYw LXVzYjItaG9zdCB7Cj4gIAkJY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQiOwo+ICAJCWVu YWJsZS1hY3RpdmUtaGlnaDsKPiAgCQlncGlvcyA9IDwmZ3BpbzQgUktfUEI1IEdQSU9fQUNUSVZF X0hJR0g+Owo+IC0JCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4gIAkJcGluY3RybC0wID0g PCZ1c2IyMF9ob3N0MV9wd3Jlbj47Cj4gKwkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiAg CQlyZWd1bGF0b3ItbmFtZSA9ICJ1c2IyX2hvc3RfNXYiOwo+ICAJCXJlZ3VsYXRvci1taW4tbWlj cm92b2x0ID0gPDUwMDAwMDA+Owo+ICAJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDUwMDAw MDA+Owo+IEBAIC05Niw1ICs5Niw2IEBAICZ1c2JfaG9zdDBfb2hjaSB7Cj4gIAo+ICAmdXNiMnBo eV9ob3N0IHsKPiAgCXBoeS1zdXBwbHkgPSA8JnVzYjJfaG9zdF81dj47Cj4gKwo+ICAJc3RhdHVz ID0gIm9rYXkiOwo+ICB9Owo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tj aGlwL3JrMzUyOC1uYW5vcGkuZHRzaSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmsz NTI4LW5hbm9waS5kdHNpCj4gaW5kZXggMTk4MGQxNGQ2Zi4uNDVlMzFiOTBhNyAxMDA2NDQKPiAt LS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzUyOC1uYW5vcGkuZHRzaQo+ICsr KyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTI4LW5hbm9waS5kdHNpCj4gQEAg LTc3LDggKzc3LDggQEAgdmNjXzN2MzogcmVndWxhdG9yLTN2My12Y2Mgewo+ICAJdmNjM3YzX3Nk OiByZWd1bGF0b3ItM3YzLXZjYy1zZCB7Cj4gIAkJY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4 ZWQiOwo+ICAJCWdwaW9zID0gPCZncGlvNCBSS19QQTEgR1BJT19BQ1RJVkVfTE9XPjsKPiAtCQlw aW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ICAJCXBpbmN0cmwtMCA9IDwmc2RtbWNfcHdyZW5f bD47Cj4gKwkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPiAgCQlyZWd1bGF0b3ItbmFtZSA9 ICJ2Y2MzdjNfc2QiOwo+ICAJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ ICAJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+IEBAIC05Nyw4ICs5Nyw4 IEBAIHZjYzV2MF9zeXM6IHJlZ3VsYXRvci01djAtdmNjLXN5cyB7Cj4gIAl2Y2Npb19zZDogcmVn dWxhdG9yLXZjY2lvLXNkIHsKPiAgCQljb21wYXRpYmxlID0gInJlZ3VsYXRvci1ncGlvIjsKPiAg CQlncGlvcyA9IDwmZ3BpbzQgUktfUEI2IEdQSU9fQUNUSVZFX0hJR0g+Owo+IC0JCXBpbmN0cmwt bmFtZXMgPSAiZGVmYXVsdCI7Cj4gIAkJcGluY3RybC0wID0gPCZzZG1tY192b2xfY3RybF9oPjsK PiArCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ICAJCXJlZ3VsYXRvci1uYW1lID0gInZj Y2lvX3NkIjsKPiAgCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDwxODAwMDAwPjsKPiAgCQly ZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwzMzAwMDAwPjsKPiBAQCAtMTUyLDIwICsxNTIsMjMg QEAgJmdtYWMxIHsKPiAgCXBoeS1oYW5kbGUgPSA8JnJnbWlpX3BoeT47Cj4gIAlwaHktbW9kZSA9 ICJyZ21paS1pZCI7Cj4gIAlwaHktc3VwcGx5ID0gPCZ2Y2NfM3YzPjsKPiAtCXBpbmN0cmwtbmFt ZXMgPSAiZGVmYXVsdCI7Cj4gIAlwaW5jdHJsLTAgPSA8JnJnbWlpX21paW0+LCA8JnJnbWlpX3R4 X2J1czI+LCA8JnJnbWlpX3J4X2J1czI+LAo+ICAJCSAgICA8JnJnbWlpX3JnbWlpX2Nsaz4sIDwm cmdtaWlfcmdtaWlfYnVzPiwgPCZnbWFjMV9yc3RuX2w+Owo+ICsJcGluY3RybC1uYW1lcyA9ICJk ZWZhdWx0IjsKPiArCj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIH07Cj4gIAo+ICAmZ3B1IHsKPiAg CW1hbGktc3VwcGx5ID0gPCZ2ZGRfbG9naWM+Owo+ICsKPiAgCXN0YXR1cyA9ICJva2F5IjsKPiAg fTsKPiAgCj4gICZpMmMxIHsKPiAtCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4gIAlwaW5j dHJsLTAgPSA8JmkyYzFtMF94ZmVyPjsKPiArCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4g Kwo+ICAJc3RhdHVzID0gIm9rYXkiOwo+ICAKPiAgCWh5bTg1NjM6IHJ0Y0A1MSB7Cj4gQEAgLTE3 NCw4ICsxNzcsOCBAQCBoeW04NTYzOiBydGNANTEgewo+ICAJCSNjbG9jay1jZWxscyA9IDwwPjsK PiAgCQlpbnRlcnJ1cHQtcGFyZW50ID0gPCZncGlvND47Cj4gIAkJaW50ZXJydXB0cyA9IDxSS19Q QzEgSVJRX1RZUEVfTEVWRUxfTE9XPjsKPiAtCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ ICAJCXBpbmN0cmwtMCA9IDwmcnRjX2ludF9sPjsKPiArCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1 bHQiOwo+ICAJCXdha2V1cC1zb3VyY2U7Cj4gIAl9Owo+ICB9Owo+IEBAIC0yMTYsMTkgKzIxOSwy MiBAQCBzZG1tY192b2xfY3RybF9oOiBzZG1tYy12b2wtY3RybC1oIHsKPiAgfTsKPiAgCj4gICZw d20xIHsKPiAtCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4gIAlwaW5jdHJsLTAgPSA8JnB3 bTFtMF9waW5zPjsKPiArCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4gKwo+ICAJc3RhdHVz ID0gIm9rYXkiOwo+ICB9Owo+ICAKPiAgJnB3bTIgewo+IC0JcGluY3RybC1uYW1lcyA9ICJkZWZh dWx0IjsKPiAgCXBpbmN0cmwtMCA9IDwmcHdtMm0wX3BpbnM+Owo+ICsJcGluY3RybC1uYW1lcyA9 ICJkZWZhdWx0IjsKPiArCj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIH07Cj4gIAo+ICAmc2FyYWRj IHsKPiAgCXZyZWYtc3VwcGx5ID0gPCZ2Y2NfMXY4PjsKPiArCj4gIAlzdGF0dXMgPSAib2theSI7 Cj4gIH07Cj4gIAo+IEBAIC0yNDEsNiArMjQ3LDcgQEAgJnNkaGNpIHsKPiAgCW5vbi1yZW1vdmFi bGU7Cj4gIAl2bW1jLXN1cHBseSA9IDwmdmNjXzN2Mz47Cj4gIAl2cW1tYy1zdXBwbHkgPSA8JnZj Y18xdjg+Owo+ICsKPiAgCXN0YXR1cyA9ICJva2F5IjsKPiAgfTsKPiAgCj4gQEAgLTI1MiwxMiAr MjU5LDE0IEBAICZzZG1tYyB7Cj4gIAlzZC11aHMtc2RyMTA0Owo+ICAJdm1tYy1zdXBwbHkgPSA8 JnZjYzN2M19zZD47Cj4gIAl2cW1tYy1zdXBwbHkgPSA8JnZjY2lvX3NkPjsKPiArCj4gIAlzdGF0 dXMgPSAib2theSI7Cj4gIH07Cj4gIAo+ICAmdWFydDAgewo+IC0JcGluY3RybC1uYW1lcyA9ICJk ZWZhdWx0IjsKPiAgCXBpbmN0cmwtMCA9IDwmdWFydDBtMF94ZmVyPjsKPiArCXBpbmN0cmwtbmFt ZXMgPSAiZGVmYXVsdCI7Cj4gKwo+ICAJc3RhdHVzID0gIm9rYXkiOwo+ICB9Owo+ICAKPiBAQCAt MjY2LDYgKzI3NSw3IEBAICZ1c2JfaG9zdDBfeGhjaSB7Cj4gIAltYXhpbXVtLXNwZWVkID0gImhp Z2gtc3BlZWQiOwo+ICAJcGh5cyA9IDwmdXNiMnBoeV9vdGc+Owo+ICAJcGh5LW5hbWVzID0gInVz YjItcGh5IjsKPiArCj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIH07Cj4gIAoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWls aW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-55.mta1.migadu.com [95.215.58.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60E0938D6BD for ; Wed, 9 Sep 2026 17:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788975758; cv=none; b=lFruREI6iMsfZEMOhTpLBBQmDNK0F7tIGAeTatl9ehlhgqUN+ZG5EgWNKjcBbP2HkD8HLh2dXoMpcM07PYKtl1ROuC6UvXgX5vYtECvJOe0dYn02DkXzOvTtV1keieeoEjM3G6eQ0znpWVx/pZsXjAXC4l8Nij7HWmIJQnci0vk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788975758; c=relaxed/simple; bh=fTEVGWI3xZqNHtli5O7XYQjJwsilEDuETEuMfL8uIPM=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=fdZ226BnEcg2lakko5EUulafTi/iLbfF3qF8D81Y/CNHf0uhbQnpXY57b7bwbvHvPEzYbsHiyXp3qp9lVftrehKLCV66ffLCvVUPk9OoLLjDivYJhzuebXz6KoH624TCzMLmfxxW1pbmSBi17JxoUGExVwG4eyssALqhYxTRoOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=RF54K1YL; arc=none smtp.client-ip=95.215.58.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="RF54K1YL" X-Envelope-To: devicetree@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=fTEVGWI3xZqNHtli5O7XYQjJwsilEDuETEuMfL8uIPM=; c=simple/simple; d=cknow-tech.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788975752; v=1; x=1789580552; b=RF54K1YLN66eGsOhQnHzlvBKiZTc9tuYeIhf4Dr+eaNoqHxNappwd5aEZ142VCyb4P9UUDOm BoWRYyUtZTO7bY7aqVWH42O2gDRw67guvkL9pySNIi1HMZ5C2aQq+TLAgIV+rT8TVj/LRe9UIFh ZXo0iV0EeceA7ddksiOfyteB9kIXeItJiBD3jJNiCeGX8Onr0yxa98uMB3SMZFFTvVSoF8aywQR lKLVpssPrhFLbmebEkEIyY31IypSAVqDNLBwdHGtaD0mMoL7f5EulfuPdFkwT/WqrrQI5IUNYZr wI9T8PO03yfJKlX+IZkrPTG5YpIFhoL/kgYUqIaofqdcA== X-Envelope-To: devicetree@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 29aa8afd47eb6454; Wed, 09 Sep 2026 17:42:22 +0000 X-Mizu-Trace-ID: 29aa8afd47eb6454 X-Migadu-Flow: FLOW_OUT Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 09 Sep 2026 19:42:18 +0200 Message-Id: From: "Diederik de Haas" To: , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" Cc: , , , , "Chukun Pan" , "jensen" , "Andrey Korshunov" , "Diederik de Haas" Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: Follow the DTS coding style in the NanoPi RK3528 devicetrees X-Mailer: aerc 0.22.0-9-ge948bb7230f4 References: <20260909-r28s-upstream-v3-0-ee3e1a34a353@proton.me> <20260909-r28s-upstream-v3-5-ee3e1a34a353@proton.me> In-Reply-To: <20260909-r28s-upstream-v3-5-ee3e1a34a353@proton.me> On Wed Sep 9, 2026 at 4:33 PM CEST, =E5=AE=89=E5=AE=B9 via B4 Relay wrote: > From: =E5=AE=89=E5=AE=B9 > > scripts/dtc/dt-check-style --mode=3Dstrict reports two deviations from I mentioned dt-check-style as it is a useful tool and it would be beneficial if more/all future submissions were also checked with it. I would not make it part of the commit message though. Just like 'checkpatch' is a tool in the toolbox, so is dt-check-style. > Documentation/devicetree/bindings/dts-coding-style.rst in the shared Because the actual reason for this change is a violation of the DTS coding style ... which I would put in the commit message. > NanoPi RK3528 devicetree and in the NanoPi Zero2 board devicetree: > "pinctrl-0" has to sort before "pinctrl-names", and "status" has to be > preceded by a blank line when the node has content before it. > > Sort the properties and add the missing blank lines. The generated > devicetree blobs are unchanged. Making explicit which fixes you've done is fine AFAIC, but not strictly needed as the diff already shows it. I would rather use "No functional changes.", instead of 'blobs are unchanged'. > The remaining findings of the tool are left alone, as they contradict > the established practice in arch/arm64/boot/dts/rockchip: "model" > before "compatible", "regulator-name" before the other regulator > properties, "regulator-min-microvolt" before "regulator-max-microvolt", > "pwms" before "pwm-supply" and "linux,code" before "wakeup-source" or > "press-threshold-microvolt". But as you noticed, it's not flawless. My guess is that it actually does an alphanumerical sort, while the DTS coding style prescribes a natural sorting. Dunno if there's an actual (enforceable) definition for it. I would not list what I see as tool errors in the commit message though. AFAIC no need for a new version for (just) this though. My 0.02 Cheers, Diederik > Suggested-by: Diederik de Haas > Signed-off-by: =E5=AE=89=E5=AE=B9 > --- > .../boot/dts/rockchip/rk3528-nanopi-zero2.dts | 5 +++-- > arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi | 26 +++++++++++++++-= ------ > 2 files changed, 21 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts b/arch/= arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts > index 48e4273872..96c537da6a 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts > @@ -25,8 +25,8 @@ button-recovery { > =20 > leds { > compatible =3D "gpio-leds"; > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&led1>, <&led_sys>; > + pinctrl-names =3D "default"; > =20 > led-0 { > color =3D ; > @@ -59,8 +59,8 @@ usb2_host_5v: regulator-5v0-usb2-host { > compatible =3D "regulator-fixed"; > enable-active-high; > gpios =3D <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>; > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&usb20_host1_pwren>; > + pinctrl-names =3D "default"; > regulator-name =3D "usb2_host_5v"; > regulator-min-microvolt =3D <5000000>; > regulator-max-microvolt =3D <5000000>; > @@ -96,5 +96,6 @@ &usb_host0_ohci { > =20 > &usb2phy_host { > phy-supply =3D <&usb2_host_5v>; > + > status =3D "okay"; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi b/arch/arm64= /boot/dts/rockchip/rk3528-nanopi.dtsi > index 1980d14d6f..45e31b90a7 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi > @@ -77,8 +77,8 @@ vcc_3v3: regulator-3v3-vcc { > vcc3v3_sd: regulator-3v3-vcc-sd { > compatible =3D "regulator-fixed"; > gpios =3D <&gpio4 RK_PA1 GPIO_ACTIVE_LOW>; > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&sdmmc_pwren_l>; > + pinctrl-names =3D "default"; > regulator-name =3D "vcc3v3_sd"; > regulator-min-microvolt =3D <3300000>; > regulator-max-microvolt =3D <3300000>; > @@ -97,8 +97,8 @@ vcc5v0_sys: regulator-5v0-vcc-sys { > vccio_sd: regulator-vccio-sd { > compatible =3D "regulator-gpio"; > gpios =3D <&gpio4 RK_PB6 GPIO_ACTIVE_HIGH>; > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&sdmmc_vol_ctrl_h>; > + pinctrl-names =3D "default"; > regulator-name =3D "vccio_sd"; > regulator-min-microvolt =3D <1800000>; > regulator-max-microvolt =3D <3300000>; > @@ -152,20 +152,23 @@ &gmac1 { > phy-handle =3D <&rgmii_phy>; > phy-mode =3D "rgmii-id"; > phy-supply =3D <&vcc_3v3>; > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&rgmii_miim>, <&rgmii_tx_bus2>, <&rgmii_rx_bus2>, > <&rgmii_rgmii_clk>, <&rgmii_rgmii_bus>, <&gmac1_rstn_l>; > + pinctrl-names =3D "default"; > + > status =3D "okay"; > }; > =20 > &gpu { > mali-supply =3D <&vdd_logic>; > + > status =3D "okay"; > }; > =20 > &i2c1 { > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&i2c1m0_xfer>; > + pinctrl-names =3D "default"; > + > status =3D "okay"; > =20 > hym8563: rtc@51 { > @@ -174,8 +177,8 @@ hym8563: rtc@51 { > #clock-cells =3D <0>; > interrupt-parent =3D <&gpio4>; > interrupts =3D ; > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&rtc_int_l>; > + pinctrl-names =3D "default"; > wakeup-source; > }; > }; > @@ -216,19 +219,22 @@ sdmmc_vol_ctrl_h: sdmmc-vol-ctrl-h { > }; > =20 > &pwm1 { > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&pwm1m0_pins>; > + pinctrl-names =3D "default"; > + > status =3D "okay"; > }; > =20 > &pwm2 { > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&pwm2m0_pins>; > + pinctrl-names =3D "default"; > + > status =3D "okay"; > }; > =20 > &saradc { > vref-supply =3D <&vcc_1v8>; > + > status =3D "okay"; > }; > =20 > @@ -241,6 +247,7 @@ &sdhci { > non-removable; > vmmc-supply =3D <&vcc_3v3>; > vqmmc-supply =3D <&vcc_1v8>; > + > status =3D "okay"; > }; > =20 > @@ -252,12 +259,14 @@ &sdmmc { > sd-uhs-sdr104; > vmmc-supply =3D <&vcc3v3_sd>; > vqmmc-supply =3D <&vccio_sd>; > + > status =3D "okay"; > }; > =20 > &uart0 { > - pinctrl-names =3D "default"; > pinctrl-0 =3D <&uart0m0_xfer>; > + pinctrl-names =3D "default"; > + > status =3D "okay"; > }; > =20 > @@ -266,6 +275,7 @@ &usb_host0_xhci { > maximum-speed =3D "high-speed"; > phys =3D <&usb2phy_otg>; > phy-names =3D "usb2-phy"; > + > status =3D "okay"; > }; > =20