From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Ping-Ke Shih" <pkshih@realtek.com>, "Luka Gejak" <luka.gejak@linux.dev>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michael Straube" <straube.linux@gmail.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Bitterblue Smith" <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH v11 4/7] wifi: rtw88: sdio: zero the padding added to a TX transfer
Date: Fri, 11 Sep 2026 08:41:00 +0200 [thread overview]
Message-ID: <DLCA5RRJUQKI.37EVVUC379JC4@linux.dev> (raw)
In-Reply-To: <f139980a5614454cac50517a5b602cd5@realtek.com>
On Fri Sep 11, 2026 at 2:30 AM CEST, Ping-Ke Shih wrote:
> Luka Gejak <luka.gejak@linux.dev>
>>
>> One thing to decide, though. The commit message says the padding "costs
>> nothing observable", which is too strong given the numbers in that same
>> paragraph. Do you think it needs rewording? If so, would you be willing
>> to amend it yourself when applying? That seems better than a resend of
>> seven patches for one line.
>
> I can amend it myself as
>
> "... padding the transfer costs about 2% observable over transfer."
>
> Or you can help to reword the paragraph. I can copy & paste it.
>
> Ping-Ke
Please amend it yourself, that is much better than a resend. Here is the
change:
"padding the transfer costs nothing observable:" to "padding the transfer
costs about 2% observable over transfer:"
Leave the rest as is, after semicolons there are numbers to explain that 2%.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-09-11 6:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 7:45 [PATCH v11 0/7] wifi: rtw88: preparations for RTL8723B/RTL8723BS luka.gejak
2026-09-09 7:45 ` [PATCH v11 1/7] wifi: rtw88: add the RTL8723B chip type and SDIO helper luka.gejak
2026-09-09 7:45 ` [PATCH v11 2/7] wifi: rtw88: rx: mark zero length packets on RTL8723BS luka.gejak
2026-09-09 7:45 ` [PATCH v11 3/7] wifi: rtw88: tx: extend the TX report purge timeout to RTL8723BS luka.gejak
2026-09-09 7:45 ` [PATCH v11 4/7] wifi: rtw88: sdio: zero the padding added to a TX transfer luka.gejak
2026-09-10 2:24 ` Ping-Ke Shih
2026-09-10 14:56 ` Luka Gejak
2026-09-10 15:51 ` Luka Gejak
2026-09-11 0:45 ` Ping-Ke Shih
2026-09-11 0:53 ` Ping-Ke Shih
2026-09-11 7:40 ` Luka Gejak
2026-09-11 7:45 ` Ping-Ke Shih
2026-09-11 8:42 ` Luka Gejak
2026-09-13 2:53 ` Ping-Ke Shih
2026-09-11 0:30 ` Ping-Ke Shih
2026-09-11 6:41 ` Luka Gejak [this message]
2026-09-09 7:45 ` [PATCH v11 5/7] wifi: rtw88: sdio: track free TX pages and OQT credits for RTL8723BS luka.gejak
2026-09-10 2:40 ` Ping-Ke Shih
2026-09-09 7:45 ` [PATCH v11 6/7] wifi: rtw88: sdio: set up RX aggregation and interrupts " luka.gejak
2026-09-09 7:45 ` [PATCH v11 7/7] wifi: rtw88: sdio: add TX back-pressure and retry on page starvation luka.gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLCA5RRJUQKI.37EVVUC379JC4@linux.dev \
--to=luka.gejak@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pbrobinson@gmail.com \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.