From: "Michael Walle" <mwalle@kernel.org>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
<Takahiro.Kuwano@infineon.com>
Cc: <pratyush@kernel.org>, <richard@nod.at>, <vigneshr@ti.com>,
<tudor.ambarus@linaro.org>, <alex@sverdlin.org>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mtd: spi-nor: spansion: Assign .fixups to s25fs256s1
Date: Wed, 16 Sep 2026 10:15:39 +0200 [thread overview]
Message-ID: <DLGLAZ55FZH3.114WUI353COSS@kernel.org> (raw)
In-Reply-To: <874ifqoctq.fsf@bootlin.com>
On Tue Sep 15, 2026 at 3:37 PM CEST, Miquel Raynal wrote:
> Hello,
>
>> This didn't help as SFDP cache size is truncated to PAGE_SIZE in sfdp.c:
>>
>> /*
>> * Limit the total size to a reasonable value to avoid allocating too
>> * much memory just of because the flash returned some insane values.
>> */
>> if (sfdp_size > PAGE_SIZE) {
>> dev_dbg(dev, "SFDP data (%zu) too big, truncating\n",
>> sfdp_size);
>> sfdp_size = PAGE_SIZE;
>> }
>
> That size just being a sanity check, if it no longer fits our needs it
> must be increased.
Yes. Takahiro, could you propose a patch to replace the limit by
let's say SZ_16K. Hopefully, nobody will use an arbitrary offset >
0x3fff. but who knows :)
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-09-16 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 4:50 [PATCH 0/2] mtd: spi-nor: spansion: Cleanup S25FS256S Takahiro Kuwano
2026-09-14 4:50 ` Takahiro Kuwano via B4 Relay
2026-09-14 4:50 ` [PATCH 1/2] mtd: spi-nor: spansion: Remove s25fs256s0 Takahiro Kuwano
2026-09-14 4:50 ` Takahiro Kuwano via B4 Relay
2026-09-14 4:50 ` [PATCH 2/2] mtd: spi-nor: spansion: Assign .fixups to s25fs256s1 Takahiro Kuwano
2026-09-14 4:50 ` Takahiro Kuwano via B4 Relay
2026-09-14 6:33 ` Michael Walle
2026-09-14 7:11 ` Takahiro.Kuwano
2026-09-14 9:37 ` Michael Walle
2026-09-15 6:13 ` Takahiro.Kuwano
2026-09-15 13:37 ` Miquel Raynal
2026-09-16 8:15 ` Michael Walle [this message]
2026-09-14 14:19 ` [PATCH 0/2] mtd: spi-nor: spansion: Cleanup S25FS256S Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLGLAZ55FZH3.114WUI353COSS@kernel.org \
--to=mwalle@kernel.org \
--cc=Takahiro.Kuwano@infineon.com \
--cc=alex@sverdlin.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.