From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45C65C982D2 for ; Fri, 18 Sep 2026 00:41:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17F9F10E532; Fri, 18 Sep 2026 00:41:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=ubuntu.com header.i=@ubuntu.com header.b="WtBzbj8r"; dkim-atps=neutral X-Greylist: delayed 367 seconds by postgrey-1.36 at gabe; Fri, 18 Sep 2026 00:41:11 UTC Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECB4010E532 for ; Fri, 18 Sep 2026 00:41:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: Cc: To: From: Subject: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1789692071; bh=8QgXkkNdHre4C26c9GV+NpL0QV5WDefYsihE2tDLo6E=; b=WtBzbj8r/RUJdlgITKGLJ3i0mWrrdqXQzvoJDf1qDMTZinGg3U1V2YE1tJJ7145ogSvocwIQr lioOv6L7uMuJGbvl5oLpfGZ7JqcUa+3rp6KoDsTPI5dqKsIHUBTyZ7JczMi6wGgSrofk6DsOd9I bk4zCgS9QpdN3mCLH4wnhW7zcfK4+11Vw7IgX/UO52wYfrbQYcOtQi6jjUrBVcSTDzUYsrCtlIe v6UzxYn1C3HJZieVvQEOQygi0SH4Ib2diWhozbiWNTXIqd+BPPTXQbZaQ0Rk25wiWqi8aqcc+Us pUTt6EDu8s3TrAnhRMxY8GufW6DUfFTpXh3xwdH3mnYA== X-Forward-Email-ID: 6aac871042fb3e762f6d18f9 X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.14.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Thu, 17 Sep 2026 20:34:18 -0400 Message-Id: Subject: Re: [PATCH v4 01/20] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy From: "Joshua Peisach" To: "Krzysztof Kozlowski" , "Michal Wilczynski" Cc: "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Lee Jones" , "Andy Yan" , "Philipp Zabel" , "Emil Renner Berthing" , "Hal Feng" , "Michael Turquette" , "Stephen Boyd" , "Heiko Stuebner" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Dominique Belhachemi" , "Brian Masney" , "Jerome Brunet" , , , , , , , , , , "Marek Szyprowski" , "Maud Spierings" , "Graham Markall" , "Icenowy Zheng" , "Chaoyi Chen" , "Joshua Peisach" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Mailer: aerc 0.21.0 References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-1-f0e4fd6f2cc8@samsung.com> <20260917-mutant-chamois-of-competence-46ca77@quoll> In-Reply-To: <20260917-mutant-chamois-of-competence-46ca77@quoll> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu Sep 17, 2026 at 2:51 AM EDT, Krzysztof Kozlowski wrote: > On Tue, Sep 15, 2026 at 05:32:09PM +0200, Michal Wilczynski wrote: >> Add the dt-binding for the StarFive JH7110 Innosilicon HDMI PHY. >>=20 >> This device is a child of the starfive,jh7110-hdmi-subsystem node. It >> functions as both a PHY provider for the controller and as a clock >> provider for the variable pixel clock (hdmi_pclk), which it generates >> from its refoclk. >>=20 >> Reviewed-by: Joshua Peisach > > While I appreciate other people looking at this, I don't think review > here applies. It was a blanket tag, given to the entire series, with > exception that it is from newbie, thus I want to ask: was this binding > REALLY reviewed by Joshua? > > Are the rest of the patches actually reviewed or just "looks good to > me"? I see no comments from Joshua on v3, v2 and v1, which is usual sign > of doing review. > > I commented on v3 saying that I would test if I could. I don't just throw "Reviewed-by" on everything I look at. If anything, I've been trying to be more honest in reviews, and only review ones that I actually care about[1]. If reviewing patches isn't a good way for newbies to start getting familiar with the kernel code (especially a NEW driver), then I don't know what is. And to be clear, I'm not using a LLM to review. I am using actual intelligence. For the JH7110 PR specifically, I did actually go through and review each commit, because I wanted to learn what was happening and why. Actually, that's why I asked where the data sheet was[2]. So if you really want to, drop the Reviewed-by tag. And if it makes you feel better, I'll leave the series alone. -Josh [1] I won't be reviewing PRs around devicetree since I'm not confident (or frankly, interested) in it at this point. https://lore.kernel.org/all/D= L94TU52KBMO.2HAKJMJXV2CPE@ubuntu.com/ [2] Michal giving me the hardware info: https://lore.kernel.org/all/071901ef-57f3-456f-af5b-a8c99a0a7dd3@samsung.co= m/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56007C982D2 for ; Fri, 18 Sep 2026 00:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject:Message-Id :Date:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0wIMu6h2RAx6dcqXjEE/2fqIWu0NiWc9acT7XjMK1dY=; b=dRlj0e2TRU/O4JVejv7Py8NeNP odv0nYFn+7GXIsWcGIb+gUin/BK03SlcZ36aoboILUG2QGA1RD5EgIiiXrTIrY48s+6cS4+v2VLbT 5s1VZJO3s2HfjBcD5/EuSvw3HQJ/kHKeSU4cs2iwmC4zVNPV3NAG93KuaSRZr2g5ikkcYH7MHot8G j0vS1Z9I25+OK7/yxT1l/LcJnMZTyd/x0hXKqyzmNAfl4MqUQ6XOrjjeyszFomf2ldKlwdY06MQRd KZq2wO9iZGVQFpLD7MQvoVh6emYPgyM/tjscdPxpGTp/456EbIAltwqwnSCFN1Jq/pE8yogDrp4oX bxsWO4Kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7MZD-0000000D2e9-2lim; Fri, 18 Sep 2026 00:35:03 +0000 Received: from smtp.forwardemail.net ([149.28.215.223]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7MZA-0000000D2cz-3YES for linux-phy@lists.infradead.org; Fri, 18 Sep 2026 00:35:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: Cc: To: From: Subject: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1789691699; bh=8QgXkkNdHre4C26c9GV+NpL0QV5WDefYsihE2tDLo6E=; b=K0OUS4qKGVQXd6mb/W5l7TvwbxMTlN7FGPUAjSnHXZSxeVsWuPVns6p5MawvokZmTsnJfhszV YfiZVNPnesJ44MDa/vUo0JAhomfBuhEhsLKgTPQWttEbobq+Y1elaaF6uOp6J3ygA0j+NSDIL/S ngGinwhXrIrQ2hTCXQqzqcFfiAGAr9bIplZdOHSz5dHgU0K7nI1iq67gS0GNRhzS/Q3IrYUqEvd PbaKClwj99tvoSalQOVG6fMpeRe9WGW2hY+rBQgoGLD85ic5Z3Hy+NFX6I06K1tXXXncO9GmrzA PH3WvRENHfR6b1liAe2d1kXo6mj/nHyaFB8VOkE7sMqg== X-Forward-Email-ID: 6aac871042fb3e762f6d18f9 X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.14.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Mime-Version: 1.0 Date: Thu, 17 Sep 2026 20:34:18 -0400 Message-Id: Subject: Re: [PATCH v4 01/20] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy From: "Joshua Peisach" To: "Krzysztof Kozlowski" , "Michal Wilczynski" Cc: "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Lee Jones" , "Andy Yan" , "Philipp Zabel" , "Emil Renner Berthing" , "Hal Feng" , "Michael Turquette" , "Stephen Boyd" , "Heiko Stuebner" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Dominique Belhachemi" , "Brian Masney" , "Jerome Brunet" , , , , , , , , , , "Marek Szyprowski" , "Maud Spierings" , "Graham Markall" , "Icenowy Zheng" , "Chaoyi Chen" , "Joshua Peisach" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Mailer: aerc 0.21.0 References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-1-f0e4fd6f2cc8@samsung.com> <20260917-mutant-chamois-of-competence-46ca77@quoll> In-Reply-To: <20260917-mutant-chamois-of-competence-46ca77@quoll> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260917_173501_153886_DBADB588 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="Flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu Sep 17, 2026 at 2:51 AM EDT, Krzysztof Kozlowski wrote: > On Tue, Sep 15, 2026 at 05:32:09PM +0200, Michal Wilczynski wrote: >> Add the dt-binding for the StarFive JH7110 Innosilicon HDMI PHY. >> >> This device is a child of the starfive,jh7110-hdmi-subsystem node. It >> functions as both a PHY provider for the controller and as a clock >> provider for the variable pixel clock (hdmi_pclk), which it generates >> from its refoclk. >> >> Reviewed-by: Joshua Peisach > > While I appreciate other people looking at this, I don't think review > here applies. It was a blanket tag, given to the entire series, with > exception that it is from newbie, thus I want to ask: was this binding > REALLY reviewed by Joshua? > > Are the rest of the patches actually reviewed or just "looks good to > me"? I see no comments from Joshua on v3, v2 and v1, which is usual sign > of doing review. > > I commented on v3 saying that I would test if I could. I don't just throw "Reviewed-by" on everything I look at. If anything, I've been trying to be more honest in reviews, and only review ones that I actually care about[1]. If reviewing patches isn't a good way for newbies to start getting familiar with the kernel code (especially a NEW driver), then I don't know what is. And to be clear, I'm not using a LLM to review. I am using actual intelligence. For the JH7110 PR specifically, I did actually go through and review each commit, because I wanted to learn what was happening and why. Actually, that's why I asked where the data sheet was[2]. So if you really want to, drop the Reviewed-by tag. And if it makes you feel better, I'll leave the series alone. -Josh [1] I won't be reviewing PRs around devicetree since I'm not confident (or frankly, interested) in it at this point. https://lore.kernel.org/all/DL94TU52KBMO.2HAKJMJXV2CPE@ubuntu.com/ [2] Michal giving me the hardware info: https://lore.kernel.org/all/071901ef-57f3-456f-af5b-a8c99a0a7dd3@samsung.com/ -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB9DBC982D0 for ; Fri, 18 Sep 2026 00:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject:Message-Id :Date:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ukJva9YONbvrg8TWiiGhLEAMJQweu7Siyl11fGKQ6dA=; b=ChrzQ4jNTjDIBO2OsdI8DdKU4Z ha3J/flY9Ta2Mrc1KF7gT/F4Ngyfp/m5lPtX0Ep6TbN9UgNzRTAh4O5a0R1/eKXQmF7pYEVgkSHfH UXoIVEI8zxPw2Uz2iqy6D75Y46d2mCQZFLod8Lrm/wZbsH+UHjR+SqgL8gRsBc3MkbpPEw85JvIuI 0spUB8RcaGgazV9uxRF3X8ZcORcf6eXIzluDZKHCRqQtkX/O65wlJjJWyHAWFgyH33ZhNh1N5eV0b NnKRlp3V8ujlPLATd7BV8ktH12uPlqLP7TJiGLPzQJiYcOl9YikoTEdgAbBB2GwoHle2WdvL48vAn sIbQP3xQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7McL-0000000D3BG-1elP; Fri, 18 Sep 2026 00:38:17 +0000 Received: from smtp.forwardemail.net ([149.28.215.223]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7McI-0000000D3AJ-2l8n for linux-rockchip@lists.infradead.org; Fri, 18 Sep 2026 00:38:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: Cc: To: From: Subject: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1789691893; bh=8QgXkkNdHre4C26c9GV+NpL0QV5WDefYsihE2tDLo6E=; b=uxFggGXJ4xAJ9b6IaAJd+UlvvnArndDMelAh7toaVbABlFzGBS+NT3Ub4nAX5mARAoIHQEBpY bJ5SBStdQec9oCsyDF8XLizqjIjgpn1RFqBIGdBL8TnwppXUQskDVYiUptY8JKWWZZB53so/ei4 +P6owSkvwjnJGNeXqfonBn+MUwTN/f2tL5UkDjY66D3j/s3kUS54YWiJyDHTKD7FliXVtzwxW50 w6BrKLqRmOezwohinQL5vV+VBcfS0qi3hyXyEiciEW3chl38lV27ZgphOC3fntCV1PKhkPPQds9 6eQy1+q9OCeWHeE36eJUF6Yt4JSIVM8jNo0vBldsRljw== X-Forward-Email-ID: 6aac871042fb3e762f6d18f9 X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.14.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Mime-Version: 1.0 Date: Thu, 17 Sep 2026 20:34:18 -0400 Message-Id: Subject: Re: [PATCH v4 01/20] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy From: "Joshua Peisach" To: "Krzysztof Kozlowski" , "Michal Wilczynski" Cc: "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Lee Jones" , "Andy Yan" , "Philipp Zabel" , "Emil Renner Berthing" , "Hal Feng" , "Michael Turquette" , "Stephen Boyd" , "Heiko Stuebner" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Dominique Belhachemi" , "Brian Masney" , "Jerome Brunet" , , , , , , , , , , "Marek Szyprowski" , "Maud Spierings" , "Graham Markall" , "Icenowy Zheng" , "Chaoyi Chen" , "Joshua Peisach" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Mailer: aerc 0.21.0 References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-1-f0e4fd6f2cc8@samsung.com> <20260917-mutant-chamois-of-competence-46ca77@quoll> In-Reply-To: <20260917-mutant-chamois-of-competence-46ca77@quoll> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260917_173814_864197_F4663391 X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="Flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu Sep 17, 2026 at 2:51 AM EDT, Krzysztof Kozlowski wrote: > On Tue, Sep 15, 2026 at 05:32:09PM +0200, Michal Wilczynski wrote: >> Add the dt-binding for the StarFive JH7110 Innosilicon HDMI PHY. >> >> This device is a child of the starfive,jh7110-hdmi-subsystem node. It >> functions as both a PHY provider for the controller and as a clock >> provider for the variable pixel clock (hdmi_pclk), which it generates >> from its refoclk. >> >> Reviewed-by: Joshua Peisach > > While I appreciate other people looking at this, I don't think review > here applies. It was a blanket tag, given to the entire series, with > exception that it is from newbie, thus I want to ask: was this binding > REALLY reviewed by Joshua? > > Are the rest of the patches actually reviewed or just "looks good to > me"? I see no comments from Joshua on v3, v2 and v1, which is usual sign > of doing review. > > I commented on v3 saying that I would test if I could. I don't just throw "Reviewed-by" on everything I look at. If anything, I've been trying to be more honest in reviews, and only review ones that I actually care about[1]. If reviewing patches isn't a good way for newbies to start getting familiar with the kernel code (especially a NEW driver), then I don't know what is. And to be clear, I'm not using a LLM to review. I am using actual intelligence. For the JH7110 PR specifically, I did actually go through and review each commit, because I wanted to learn what was happening and why. Actually, that's why I asked where the data sheet was[2]. So if you really want to, drop the Reviewed-by tag. And if it makes you feel better, I'll leave the series alone. -Josh [1] I won't be reviewing PRs around devicetree since I'm not confident (or frankly, interested) in it at this point. https://lore.kernel.org/all/DL94TU52KBMO.2HAKJMJXV2CPE@ubuntu.com/ [2] Michal giving me the hardware info: https://lore.kernel.org/all/071901ef-57f3-456f-af5b-a8c99a0a7dd3@samsung.com/ _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 281F9C982D2 for ; Fri, 18 Sep 2026 00:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject:Message-Id :Date:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JQdSOM8cAGEiuAveJlESn0lx0s0Vpv1/xTPbLvD5Fgo=; b=q9vZbj13lMxwbFUzFWvRFBv+s0 mXX17B4TJglmhXnufEtiBiPERRa+3p+rOFs4rVuBlc4oZ2w+lmTSxsgU5nHj9qaoZGB3UqF4LsGOp vFdqlYb/BjHoF9xaJyaSIT3CEMBmdzrFJdojvY4IYiNi59oftybZqygxYatkAr6+d+mADWqt4G5B+ RNsQVwD29IOIJrQHvxNJn8Vru0EYloqBOSThl3WFsvIRwWwVKuETc0EzCnZfgnBIwH3r2oG66v+gO wozEL3Rx8B5hVwCDbzj4hvJKsfayOl2DzUM2Tv90dJ2Fd/gRUS5HGSqpuUzgtzqOOy9nMXNVtfDGp j2wvOVfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7McL-0000000D3BB-1ErZ; Fri, 18 Sep 2026 00:38:17 +0000 Received: from smtp.forwardemail.net ([149.28.215.223]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7McI-0000000D39n-0xWX for linux-riscv@lists.infradead.org; Fri, 18 Sep 2026 00:38:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: Cc: To: From: Subject: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1789691893; bh=8QgXkkNdHre4C26c9GV+NpL0QV5WDefYsihE2tDLo6E=; b=uxFggGXJ4xAJ9b6IaAJd+UlvvnArndDMelAh7toaVbABlFzGBS+NT3Ub4nAX5mARAoIHQEBpY bJ5SBStdQec9oCsyDF8XLizqjIjgpn1RFqBIGdBL8TnwppXUQskDVYiUptY8JKWWZZB53so/ei4 +P6owSkvwjnJGNeXqfonBn+MUwTN/f2tL5UkDjY66D3j/s3kUS54YWiJyDHTKD7FliXVtzwxW50 w6BrKLqRmOezwohinQL5vV+VBcfS0qi3hyXyEiciEW3chl38lV27ZgphOC3fntCV1PKhkPPQds9 6eQy1+q9OCeWHeE36eJUF6Yt4JSIVM8jNo0vBldsRljw== X-Forward-Email-ID: 6aac871042fb3e762f6d18f9 X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.14.2 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Mime-Version: 1.0 Date: Thu, 17 Sep 2026 20:34:18 -0400 Message-Id: Subject: Re: [PATCH v4 01/20] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy From: "Joshua Peisach" To: "Krzysztof Kozlowski" , "Michal Wilczynski" Cc: "Vinod Koul" , "Neil Armstrong" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Lee Jones" , "Andy Yan" , "Philipp Zabel" , "Emil Renner Berthing" , "Hal Feng" , "Michael Turquette" , "Stephen Boyd" , "Heiko Stuebner" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Dominique Belhachemi" , "Brian Masney" , "Jerome Brunet" , , , , , , , , , , "Marek Szyprowski" , "Maud Spierings" , "Graham Markall" , "Icenowy Zheng" , "Chaoyi Chen" , "Joshua Peisach" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Mailer: aerc 0.21.0 References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-1-f0e4fd6f2cc8@samsung.com> <20260917-mutant-chamois-of-competence-46ca77@quoll> In-Reply-To: <20260917-mutant-chamois-of-competence-46ca77@quoll> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260917_173814_277679_EB297F24 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="Flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu Sep 17, 2026 at 2:51 AM EDT, Krzysztof Kozlowski wrote: > On Tue, Sep 15, 2026 at 05:32:09PM +0200, Michal Wilczynski wrote: >> Add the dt-binding for the StarFive JH7110 Innosilicon HDMI PHY. >> >> This device is a child of the starfive,jh7110-hdmi-subsystem node. It >> functions as both a PHY provider for the controller and as a clock >> provider for the variable pixel clock (hdmi_pclk), which it generates >> from its refoclk. >> >> Reviewed-by: Joshua Peisach > > While I appreciate other people looking at this, I don't think review > here applies. It was a blanket tag, given to the entire series, with > exception that it is from newbie, thus I want to ask: was this binding > REALLY reviewed by Joshua? > > Are the rest of the patches actually reviewed or just "looks good to > me"? I see no comments from Joshua on v3, v2 and v1, which is usual sign > of doing review. > > I commented on v3 saying that I would test if I could. I don't just throw "Reviewed-by" on everything I look at. If anything, I've been trying to be more honest in reviews, and only review ones that I actually care about[1]. If reviewing patches isn't a good way for newbies to start getting familiar with the kernel code (especially a NEW driver), then I don't know what is. And to be clear, I'm not using a LLM to review. I am using actual intelligence. For the JH7110 PR specifically, I did actually go through and review each commit, because I wanted to learn what was happening and why. Actually, that's why I asked where the data sheet was[2]. So if you really want to, drop the Reviewed-by tag. And if it makes you feel better, I'll leave the series alone. -Josh [1] I won't be reviewing PRs around devicetree since I'm not confident (or frankly, interested) in it at this point. https://lore.kernel.org/all/DL94TU52KBMO.2HAKJMJXV2CPE@ubuntu.com/ [2] Michal giving me the hardware info: https://lore.kernel.org/all/071901ef-57f3-456f-af5b-a8c99a0a7dd3@samsung.com/ _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv