All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alejandro Vallejo" <alejandro.garciavallejo@amd.com>
To: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	<xen-devel@lists.xenproject.org>
Cc: "Jan Beulich" <jbeulich@suse.com>,
	"Roger Pau Monné" <roger@xenproject.org>,
	"Teddy Astie" <teddy.astie@vates.tech>
Subject: Re: [PATCH] x86/vpmu: Fix incorrect printk format specifiers
Date: Mon, 21 Sep 2026 12:33:40 +0200	[thread overview]
Message-ID: <DLKXDDFXWQHS.3KD2N2G4MYVM1@amd.com> (raw)
In-Reply-To: <489f6ce6-2be7-4c94-bcf0-21fc6993f98c@citrix.com>

On Mon Sep 21, 2026 at 11:30 AM CEST, Andrew Cooper wrote:
> On 21/09/2026 10:16 am, Alejandro Vallejo wrote:
> > The patch in Fixes adjusted two vendor variables from uint8_t and plain
> > int to to unsigned int. But they were both used later in printks with
> > the %d specifier rather than %u. Adjust accordingly.
> >
> > Fixes: 39a9a49449d7 ("x86: Remove x86 prefixed names from x86/cpu/ files")
> > Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
>
> If this is going to be a problem, then shouldn't we turn
> -Wformat-signedness on?

I tried that before sending, but that needs a whole new series. Things
are not quite as clean as I'd hope.

>
> For the patch, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks

Alejandro


  reply	other threads:[~2026-09-21 10:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  9:16 [PATCH] x86/vpmu: Fix incorrect printk format specifiers Alejandro Vallejo
2026-09-21  9:30 ` Andrew Cooper
2026-09-21 10:33   ` Alejandro Vallejo [this message]
2026-09-21 15:59     ` Andrew Cooper
2026-09-21 17:31       ` Alejandro Vallejo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLKXDDFXWQHS.3KD2N2G4MYVM1@amd.com \
    --to=alejandro.garciavallejo@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger@xenproject.org \
    --cc=teddy.astie@vates.tech \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.