From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <setairidis@gmail.com>, <bitbake-devel@lists.openembedded.org>
Cc: <jhonata.poma@gmail.com>, <paul@pbarker.dev>
Subject: Re: [bitbake-devel] [PATCH v3] fetch2/local: verify checksums for file:// urls
Date: Thu, 24 Sep 2026 08:36:42 +0200 [thread overview]
Message-ID: <DLNC7K9T9IRB.3TSABE8ZFLIZF@bootlin.com> (raw)
In-Reply-To: <20260923194435.58965-1-setairidis@gmail.com>
Hi,
On Wed Sep 23, 2026 at 9:44 PM CEST, Savvas Etairidis via lists.openembedded.org wrote:
> Local.urldata_init unconditionally cleared ud.needdonestamp, which
> skipped the donestamp + verify_checksum cycle for every file:// url.
> A checksum supplied via a url parameter, such as UNINATIVE_CHECKSUM
> expanded into the uninative tarball's file:// url, was therefore
> never compared against the file's actual contents.
>
> Keep needdonestamp at its default when the url carries a checksum
> parameter, and move rename_bad_checksum onto FetchMethod so Local can
> override it as a no-op, avoiding a rename of the user's source file
> on mismatch.
>
> Based on a patch by Jhonata Poma-Hansen, adapted to this tree's
> Local.urldata_init(), which now uses ud.decodedurl in place of the
> ud.path referenced by the original patch.
This cannot be applied to the master branch cleanly. Can you rebase and re-send
you patch?
Antonin
next prev parent reply other threads:[~2026-09-24 6:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 14:25 [PATCH] fetch2/local: verify checksums for file:// urls Jhonata Poma-Hansen
2026-05-08 14:13 ` [bitbake-devel] " Paul Barker
2026-05-11 14:58 ` [PATCH v2] " Jhonata Poma-Hansen
2026-05-11 15:01 ` Jhonata Poma-Hansen
2026-09-23 19:44 ` [PATCH v3] " Savvas Etairidis
2026-09-24 6:36 ` Antonin Godard [this message]
2026-09-24 20:45 ` [PATCH v4] fetch/local: " Savvas Etairidis
2026-09-28 9:30 ` Paul Barker
2026-09-28 20:59 ` [PATCH v5] " Savvas Etairidis
2026-09-28 21:02 ` Sawas Etairidis
2026-09-29 8:22 ` Jhonata Poma-Hansen
2026-09-30 10:51 ` Paul Barker
2026-09-30 21:21 ` [PATCH v6] " Savvas Etairidis
2026-10-01 8:32 ` Paul Barker
2026-10-01 20:53 ` [PATCH v7] " Savvas Etairidis
2026-10-02 8:50 ` Paul Barker
2026-10-02 20:48 ` Sawas Etairidis
2026-10-02 20:50 ` [PATCH v8] " Savvas Etairidis
2026-10-05 14:36 ` Paul Barker
2026-10-06 16:40 ` Sawas Etairidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLNC7K9T9IRB.3TSABE8ZFLIZF@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=jhonata.poma@gmail.com \
--cc=paul@pbarker.dev \
--cc=setairidis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.