From: "Alejandro Vallejo" <alejandro.garciavallejo@amd.com>
To: "Jason Andryuk" <jason.andryuk@amd.com>,
<xen-devel@lists.xenproject.org>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger@xenproject.org>,
"Timothy Pearson" <tpearson@raptorengineering.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Connor Davis" <connojdavis@gmail.com>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
"Teddy Astie" <teddy.astie@vates.tech>,
"Grygorii Strashko" <grygorii_strashko@epam.com>
Subject: Re: [PATCH] xen: Consolidate linker script setup data
Date: Thu, 24 Sep 2026 17:58:55 +0200 [thread overview]
Message-ID: <DLNO61C820D2.2TSH4227QA8DB@amd.com> (raw)
In-Reply-To: <20260923161935.24429-1-jason.andryuk@amd.com>
On Wed Sep 23, 2026 at 6:19 PM CEST, Jason Andryuk wrote:
> .init.setup, .initcallpresmp.init, and .initcall1.init are duplicated
> across architectures. Replace them with a common define, SETUP_DATA.
>
> Suggested-by: Grygorii Strashko <grygorii_strashko@epam.com>
> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
> Reviewed-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> ---
> Alejandro reviewed internally.
In case it matters, I confirm.
Cheers,
Alejandro
> Jan reviewed off list.
> ---
> xen/arch/arm/xen.lds.S | 11 +----------
> xen/arch/ppc/xen.lds.S | 12 +-----------
> xen/arch/riscv/xen.lds.S | 12 +-----------
> xen/arch/x86/xen.lds.S | 11 +----------
> xen/include/xen/xen.lds.h | 12 ++++++++++++
> 5 files changed, 16 insertions(+), 42 deletions(-)
>
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index d4d9594033..32afbfe131 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -135,16 +135,7 @@ SECTIONS
> *(.init.rodata)
> *(.init.rodata.*)
>
> - . = ALIGN(POINTER_ALIGN);
> - __setup_start = .;
> - *(.init.setup)
> - __setup_end = .;
> -
> - __initcall_start = .;
> - *(.initcallpresmp.init)
> - __presmp_initcall_end = .;
> - *(.initcall1.init)
> - __initcall_end = .;
> + SETUP_DATA
>
> . = ALIGN(4);
> __alt_instructions = .;
> diff --git a/xen/arch/ppc/xen.lds.S b/xen/arch/ppc/xen.lds.S
> index d0f2ed43f1..37256c8865 100644
> --- a/xen/arch/ppc/xen.lds.S
> +++ b/xen/arch/ppc/xen.lds.S
> @@ -107,17 +107,7 @@ SECTIONS
> *(.init.rodata)
> *(.init.rodata.*)
>
> - . = ALIGN(POINTER_ALIGN);
> - __setup_start = .;
> - *(.init.setup)
> - __setup_end = .;
> -
> - __initcall_start = .;
> - *(.initcallpresmp.init)
> - __presmp_initcall_end = .;
> - *(.initcall1.init)
> - __initcall_end = .;
> -
> + SETUP_DATA
> LOCK_PROFILE_DATA
>
> *(.init.data)
> diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S
> index 70db658fef..d9375a9616 100644
> --- a/xen/arch/riscv/xen.lds.S
> +++ b/xen/arch/riscv/xen.lds.S
> @@ -114,17 +114,7 @@ SECTIONS
> *(.init.rodata)
> *(.init.rodata.*)
>
> - . = ALIGN(POINTER_ALIGN);
> - __setup_start = .;
> - *(.init.setup)
> - __setup_end = .;
> -
> - __initcall_start = .;
> - *(.initcallpresmp.init)
> - __presmp_initcall_end = .;
> - *(.initcall1.init)
> - __initcall_end = .;
> -
> + SETUP_DATA
> LOCK_PROFILE_DATA
>
> *(.init.data)
> diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
> index b9e888e596..8f943e11ea 100644
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -223,16 +223,7 @@ SECTIONS
> *(.init.rodata)
> *(.init.rodata.*)
>
> - . = ALIGN(POINTER_ALIGN);
> - __setup_start = .;
> - *(.init.setup)
> - __setup_end = .;
> -
> - __initcall_start = .;
> - *(.initcallpresmp.init)
> - __presmp_initcall_end = .;
> - *(.initcall1.init)
> - __initcall_end = .;
> + SETUP_DATA
>
> *(.init.data)
> *(.init.data.rel)
> diff --git a/xen/include/xen/xen.lds.h b/xen/include/xen/xen.lds.h
> index ea11e3fb62..958f8256b0 100644
> --- a/xen/include/xen/xen.lds.h
> +++ b/xen/include/xen/xen.lds.h
> @@ -179,6 +179,18 @@
> *(.data.schedulers) \
> __end_schedulers_array = .;
>
> +#define SETUP_DATA \
> + . = ALIGN(POINTER_ALIGN); \
> + __setup_start = .; \
> + *(.init.setup) \
> + __setup_end = .; \
> + \
> + __initcall_start = .; \
> + *(.initcallpresmp.init) \
> + __presmp_initcall_end = .; \
> + *(.initcall1.init) \
> + __initcall_end = .;
> +
> #ifdef CONFIG_HYPFS
> #define HYPFS_PARAM \
> . = ALIGN(POINTER_ALIGN); \
next prev parent reply other threads:[~2026-09-24 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 16:19 [PATCH] xen: Consolidate linker script setup data Jason Andryuk
2026-09-24 15:58 ` Alejandro Vallejo [this message]
2026-09-25 9:44 ` Orzel, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLNO61C820D2.2TSH4227QA8DB@amd.com \
--to=alejandro.garciavallejo@amd.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=bertrand.marquis@arm.com \
--cc=connojdavis@gmail.com \
--cc=grygorii_strashko@epam.com \
--cc=jason.andryuk@amd.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger@xenproject.org \
--cc=sstabellini@kernel.org \
--cc=teddy.astie@vates.tech \
--cc=tpearson@raptorengineering.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.