From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Daniel Borkmann" <daniel@iogearbox.net>
Cc: <eddyz87@gmail.com>, <john.fastabend@gmail.com>,
<memxor@gmail.com>, <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v3 05/16] bpf: Cache the jump table of a subprogram during CFG discovery
Date: Fri, 25 Sep 2026 21:01:19 +0000 [thread overview]
Message-ID: <DLOP8435UV3A.3UMMJS0YE7SHX@gmail.com> (raw)
In-Reply-To: <20260925175244.1136329-6-daniel@iogearbox.net>
On Fri, Sep 25, 2026 at 07:52 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
> Subprograms removed as dead code free their table in
> adjust_subprog_starts_after_remove(), which also clears the slots that
> the compaction of subprog_info vacates, as they still hold copies of the
> moved entries and with them their table pointers.
can we free the tables right after bpf_compute_live_registers() ?
bpf_insn_successors() is the only reader and nothing calls it
after that point.
can be a follow up...
next prev parent reply other threads:[~2026-09-25 21:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 17:52 [PATCH bpf-next v3 00/16] Misc BPF gotox fixes Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 01/16] bpf: Avoid quadratic successor rescan in bpf_compute_scc Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 02/16] bpf: Bound the number of indirect jump edges in a program Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 03/16] bpf: Rebase the exception callback subprog when dead subprogs are removed Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 04/16] bpf: Leave out the hidden exit edge of a subprogram without an exit Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 05/16] bpf: Cache the jump table of a subprogram during CFG discovery Daniel Borkmann
2026-09-25 21:01 ` Alexei Starovoitov [this message]
2026-09-25 17:52 ` [PATCH bpf-next v3 06/16] bpf: Reject indirect jumps that leave their subprogram Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 07/16] bpf: Don't remove indirect jump targets in the nop removal pass Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 08/16] bpf: Clear insn array jitted pointers on map reuse Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 09/16] bpf: Clear the insn array used flag with release semantics Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 10/16] bpf: Retarget indirect jump targets across prologue prepends Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 11/16] selftests/bpf: Add tests for the indirect jump edge limit Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 12/16] selftests/bpf: Add a test for a tail call in a subprogram without an exit Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 13/16] selftests/bpf: Add tests for indirect jumps across subprograms Daniel Borkmann
2026-09-25 18:45 ` bot+bpf-ci
2026-09-25 17:52 ` [PATCH bpf-next v3 14/16] selftests/bpf: Add a test for gotox nop targets Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 15/16] selftests/bpf: Add tests for gotox targets across prologue prepends Daniel Borkmann
2026-09-25 17:52 ` [PATCH bpf-next v3 16/16] selftests/bpf: Add a test for an exception callback behind a dead subprog Daniel Borkmann
2026-09-25 21:10 ` [PATCH bpf-next v3 00/16] Misc BPF gotox fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLOP8435UV3A.3UMMJS0YE7SHX@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.