From: "Danilo Krummrich" <dakr@kernel.org>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Johan Hovold" <johan@kernel.org>,
"Aaron Tomlin" <atomlin@atomlin.com>,
"Bradley Morgan" <brads@mainlining.org>,
"Thierry Reding" <thierry.reding@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Armin Wolf" <W_Armin@gmx.de>,
linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Add TAINT_DRIVER_OVERRIDE for usage of driver_override
Date: Sun, 27 Sep 2026 19:12:04 +0200 [thread overview]
Message-ID: <DLQ9LOHGKFWY.2L399J3OOVOCM@kernel.org> (raw)
In-Reply-To: <2026092702-negation-stoppable-b86e@gregkh>
On Sun Sep 27, 2026 at 6:50 PM CEST, Greg Kroah-Hartman wrote:
> Huh? That feels wrong, can't we fix s390 and spi instead? Ok, maybe
> not s390, but why is spi doing that?
Solely to preserve SPI's existing output; when driver_override is unset, SPI has
always printed "\n", whereas most other buses print "(null)\n".
I.e. SPI previously did
sysfs_emit(buf, "%s\n", spi->driver_override ? : "");
now it does
sysfs_emit(buf, "%s\n", dev->driver_override.name ?: "");
and the driver core does
sysfs_emit(buf, "%s\n", dev->driver_override.name);
The driver-core behavior matches most other buses (except SPI and AP).
Switching SPI to it would have changed the userspace-visible value.
prev parent reply other threads:[~2026-09-27 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 8:03 [PATCH v2 0/2] Add TAINT_DRIVER_OVERRIDE for usage of driver_override Uwe Kleine-König
2026-09-27 8:03 ` [PATCH v2 1/2] docs: admin-guide: Handle TAINT_FORCED_BIND when parsing /proc/sys/kernel/tainted Uwe Kleine-König
2026-09-27 16:39 ` Randy Dunlap
2026-09-27 8:03 ` [PATCH v2 2/2] Add TAINT_DRIVER_OVERRIDE for usage of driver_override Uwe Kleine-König
2026-09-27 8:13 ` sashiko-bot
2026-09-27 9:55 ` Danilo Krummrich
2026-09-27 10:03 ` Danilo Krummrich
2026-09-28 8:50 ` Uwe Kleine-König
2026-09-28 9:17 ` Danilo Krummrich
2026-09-27 16:50 ` Greg Kroah-Hartman
2026-09-27 17:12 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLQ9LOHGKFWY.2L399J3OOVOCM@kernel.org \
--to=dakr@kernel.org \
--cc=W_Armin@gmx.de \
--cc=atomlin@atomlin.com \
--cc=brads@mainlining.org \
--cc=dlechner@baylibre.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=thierry.reding@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.