Re: [PATCH] drm/i915/gt: Do not destroy uninitialized timer

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi Krzysztof,

On Tue Sep 29, 2026 at 1:12 PM CEST, Krzysztof Karas wrote:
> If intel_ring_begin() fails in live_emit_pte_full_ring(), then
> cleanup is performed on an uninitialized timer.
>
> Check if the timer has been set up, before trying to remove it.
>
> Assisted-by: Copilot-Claude-Opus-5
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> ---
How about something like this:

diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu/drm/i915/gt/selftest_migrate.c
index 5b986a7687d9..7efdc8d9d8cd 100644
--- a/drivers/gpu/drm/i915/gt/selftest_migrate.c
+++ b/drivers/gpu/drm/i915/gt/selftest_migrate.c
@@ -626,7 +626,8 @@ static int live_emit_pte_full_ring(void *arg)
                cs = intel_ring_begin(rq, sz);
                if (IS_ERR(cs)) {
                        err = PTR_ERR(cs);
-                       goto out_rq;
+                       i915_request_add(rq);
+                       goto out_unpin;
                }
 
                memset32(cs, MI_NOOP, sz);

-- 
Best regards,
Sebastian