Re: [PATCH] rust: macros: allow non-ASCII characters in `authors`

["Gary Guo" <gary@garyguo.net>]

On Wed Sep 30, 2026 at 1:13 PM BST, Miguel Ojeda wrote:
> On Thu, Sep 17, 2026 at 7:11 AM Thiébaud Weksteen <tweek@google.com> wrote:
>>
>> Module authors may have non-ASCII characters in their names. In C,
>> `MODULE_AUTHOR` allows arbitrary string literals which are emitted as
>> raw UTF-8 bytes into the `.modinfo` section, and multiple in-tree
>> modules use non-ASCII author names.
>>
>> Originally, the single `author` field permitted arbitrary string literals
>> including non-ASCII characters. When support for multiple authors was
>> introduced in commit 38559da6afb2 ("rust: module: introduce `authors`
>> key"), it reused the `expect_string_array` helper that had originally been
>> added for module aliases. Because that helper enforced an ASCII check,
>> `authors` inadvertently became restricted to ASCII-only string literals.
>> Later, when the macro parsing was rewritten to use `syn` in commit
>> c578ad703ae9 ("rust: macros: use `syn` to parse `module!` macro"), this
>> restriction was carried over by using AsciiLitStr in `authors` type.
>>
>> Change the element type of `authors` in `ModuleInfo` from `AsciiLitStr`
>> to `LitStr` so that UTF-8 author names are permitted.
>>
>> Fixes: 38559da6afb2 ("rust: module: introduce `authors` key")
>> Signed-off-by: Thiébaud Weksteen <tweek@google.com>
>
> This looks good, thanks! We did discuss allowing non-ASCII long ago,
> so this wasn't intentional.
>
> Petr & modules: I can pick this on up (an Acked-by would be nice!),
> unless you want to pick it.
>
> By the way:
>
> Cc: stable@vger.kernel.org

I'm not sure that this should be considered a fix. More like a feature.

Best,
Gary