Re: [PATCH v2 5/7] s390/pci: Add error cleanup in zpci_directed_irq_init

["Tobias Schumacher" <ts@linux.ibm.com>]

On Tue Oct 6, 2026 at 3:32 PM CEST, Niklas Schnelle wrote:
> On Mon, 2026-10-05 at 14:03 +0200, Tobias Schumacher wrote:
-- snip --

>> +
>> +out_free_dibv:
>> +	for_each_possible_cpu(cpu) {
>> +		if (zpci_dibv[cpu])
>> +			airq_iv_release(zpci_dibv[cpu]);
>> +	}
>> +	kfree(zpci_dibv);
>> +	zpci_dibv = NULL;
>> +out_free_sbv:
>> +	airq_iv_release(zpci_sbv);
>> +	zpci_sbv = NULL;
>> +	return -ENOMEM;
>
> As Sashiko notes this doesn't undo the
> zpci_set_irq_ctrl(SIC_IRQ_MODE_DIRECT, 0, &iib) and via the iib leaves
> the zpci_sbv->vector that gets freed here set in hardware. While
> Sashiko also notes this is an __init function and these allocations are
> extremely unlikely to fail I think the rollback is still just nice
> form. I think we could simply move the zpci_set_irq_ctrl() to after the
> allocations but before the cpu_enable_directed_irq(). It also seems
> more logical to set the interrupt mode only after memory has been set
> up.

Agreed, will change the order for v3.

Thanks,
Tobias