All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "taozj888" <taozj888@163.com>
Cc: <stable@vger.kernel.org>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Jeff Garzik" <jeff@garzik.org>,
	"Haavard Skinnemoen" <hskinnemoen@atmel.com>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v4] net: macb: rate limit netdev error info print in the data path
Date: Thu, 08 Oct 2026 14:59:55 +0200	[thread overview]
Message-ID: <DLZH4LPJ36YW.1CP7RL0J77DHN@bootlin.com> (raw)
In-Reply-To: <63731290.3f0c.1a1198fe993.Coremail.taozj888@163.com>

Hello Zijin,

 - I'll stop replying inline because you seem to be having issues with
   your mailer. Please fix it to ease the discussion.

   See here how your email looks:
   https://lore.kernel.org/netdev/63731290.3f0c.1a1198fe993.Coremail.taozj888@163.com/

 - Your V4 commit message says "Fixes: 89e5785fc8a6" but that is wrong
   with the current patch, it shold use 4df95131ea80. I don't
   understand why you are talking about the changelog at the same time,
   this is unrelated.

 - You skipped over explaining why your dropped the start_xmit diff.

I'll have to stop reviewing if you skip over parts of the messages.
I gave you a TLDR and you skipped over the first bulletpoint.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2026-10-08 13:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  5:32 [PATCH net v4] net: macb: rate limit netdev error info print in the data path taozj888
2026-10-07  9:33 ` Théo Lebrun
2026-10-08  3:30   ` taozj888
2026-10-08 12:59     ` Théo Lebrun [this message]
2026-10-11  5:46 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLZH4LPJ36YW.1CP7RL0J77DHN@bootlin.com \
    --to=theo.lebrun@bootlin.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hskinnemoen@atmel.com \
    --cc=jeff@garzik.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=taozj888@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.