Re: [bitbake-devel] [PATCH] fetch/wget: rename the partial download on checksum mismatch

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Thu Oct 8, 2026 at 4:15 PM CEST, Ricardo Salveti wrote:
> Hi,
>
> On Thu, Oct 8, 2026 at 8:59 AM Mathieu Dubois-Briand
> <mathieu.dubois-briand@bootlin.com> wrote:
>>
>> On Tue Sep 29, 2026 at 3:28 AM CEST, Ricardo Salveti via lists.openembedded.org wrote:
>> > The wget fetcher downloads into a .tmp file which is resumed with
>> > --continue and is shared with the mirrors of the same file. When it
>> > fails checksum verification it is left in place, so MIRRORS reuse the
>> > bad file instead of downloading their own copy and, without a mirror,
>> > every retry fails the same way until it is removed by hand. Rename it
>> > with rename_bad_checksum(), as done for any other file with a bad
>> > checksum, so it can be inspected and the next attempt starts from
>> > scratch. Mirror downloads skip this check and are still handled by the
>> > existing code once moved into place.
>> >
>> > Seen with parallel CI runners sharing DL_DIR on Amazon FSx for OpenZFS
>> > mounted over NFSv4.2. What corrupts the file there is not addressed,
>> > only the recovery on retry. Tested with the new tests, which fail
>> > without the fix.
>> >
>> > AI-Generated: Uses Claude Code (Claude Fable 5.1)
>> > Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
>> > ---
>>
>> Hi Ricardo,
>>
>> I suspect this patch is responsible of intermittent failures we can see
>> during test_wget_corrupt_partial_download selftest, only on Fedora
>> workers.
>>
>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=16445
>>
>> Do you have any clue about what might be wrong here?
>
> Should be fixed with
> https://patchwork.yoctoproject.org/project/bitbake/patch/20261006213334.3360919-1-ricardo.salveti@oss.qualcomm.com/,
> mind giving it a try?
>
> Thanks,
>
> Ricardo

Sorry, I thought it was still failing, but this is something else. I'll
keep you updated.

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com