All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <yann.dirson@vates.tech>, <bitbake-devel@lists.openembedded.org>,
	<richard.purdie@linuxfoundation.org>
Cc: <docs@lists.yoctoproject.org>
Subject: Re: [bitbake-devel] [PATCH] doc: document dependency tracking associated with addpylib
Date: Tue, 13 Oct 2026 14:09:32 +0200	[thread overview]
Message-ID: <DM3P6R5ZRVPM.3PW3QYG9BZOEI@bootlin.com> (raw)
In-Reply-To: <1791885365.8631fc262581453bbf619ec5b2062170.1a134b0cf0a0008425@vates.tech>

On Tue Oct 13, 2026 at 11:56 AM CEST, Yann Dirson via lists.openembedded.org wrote:
>
>
> On 10/12/26 3:20 PM, Antonin Godard wrote:
>> On Mon Oct 12, 2026 at 3:08 PM CEST, Antonin Godard via lists.openembedded.org wrote:
>>> Hi,
>>>
>>> On Mon Oct 12, 2026 at 10:25 AM CEST, Yann Dirson via lists.openembedded.org wrote:
>>>> Reported-by: Claude Opus 5.5
>>>> Signed-off-by: Yann Dirson <yann.dirson@vates.tech>
>>>> ---
>>>>   doc/bitbake-user-manual/bitbake-user-manual-metadata.rst | 8 ++++++++
>>>>   1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/doc/bitbake-user-manual/bitbake-user-manual-metadata.rst b/doc/bitbake-user-manual/bitbake-user-manual-metadata.rst
>>>> index 621aab253..eef1f9624 100644
>>>> --- a/doc/bitbake-user-manual/bitbake-user-manual-metadata.rst
>>>> +++ b/doc/bitbake-user-manual/bitbake-user-manual-metadata.rst
>>>> @@ -2264,6 +2264,14 @@ The specified <namespace> is imported automatically, and if the imported
>>>>   module specifies an attribute named ``BBIMPORTS``, that list of
>>>>   sub-modules is iterated and imported too.
>>>>   
>>>> +Additionally, Bitbake will detect usage of functions from such a
>>>> +library and include them in task hashes, so changes in those functions
>>>> +trigger task rebuilds.  Note that only functions inside modules
>>>> +declared using ``BBIMPORTS`` benefit from this dependency tracking,
>>>> +any name defined directly in the specified namespace (e.g. in
>>>> +`<namespace>/__init__.py`, or in a library hat would be defined as
>>>
>>> s/hat/that/
>>>
>>>> +`<namespace>.py`) would *not* benefit from this tracking.
>>>
>>> Otherwise, this is clear to me. I did not know about this limitation/feature,
>>> and this is definitely important to document, thanks!
>> 
>> Reading the code[1], it seems that functions prefixed with _ are not included
>> in the task checksums - if I understood correctly. I think it would be also
>> important to mention that. Could you add it in a v2?
>
> It could be asked why we would want to exclude them.  Usually that would 
> be internal functions, to be called by the exported ones, so they would 
> equally matter - but then they are actually not included in the task 
> hash, so it rather looks like a bug rather than something to document?

You're right, it seems strange to exclude them entirely. You may want to send a
patch to remove this then? At least it will kick-off the discussion on this
list.

Thanks,
Antonin


  reply	other threads:[~2026-10-13 12:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12  8:25 [PATCH] doc: document dependency tracking associated with addpylib Yann Dirson
2026-10-12 13:08 ` [bitbake-devel] " Antonin Godard
2026-10-12 13:08   ` Antonin Godard
2026-10-12 13:20   ` Antonin Godard
2026-10-12 13:20     ` Antonin Godard
2026-10-13  9:56     ` Yann Dirson
2026-10-13 12:09       ` Antonin Godard [this message]
2026-10-13 13:10         ` Richard Purdie
2026-10-13 14:05           ` Yann Dirson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM3P6R5ZRVPM.3PW3QYG9BZOEI@bootlin.com \
    --to=antonin.godard@bootlin.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=docs@lists.yoctoproject.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=yann.dirson@vates.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.