All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Robin Jarry" <rjarry@redhat.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH dpdk v2 2/2] meson: add drivers to dynamic libraries
Date: Thu, 15 Oct 2026 14:06:00 +0200	[thread overview]
Message-ID: <DM5ED553NJLC.NBQ71EIJ8HFP@redhat.com> (raw)
In-Reply-To: <atC-kJHTeupb1Qri@bricha3-mobl1.ger.corp.intel.com>

Bruce Richardson, Oct 15, 2026 at 13:52:
> I think this changes significantly how out pkg-config files are working, vs
> our original intention, so I think it actually needs more discussion.
>
> As originally designed, when dynamically linking against DPDK the pkg-config
> --libs libdpdk call was only meant to list out the libraries, with drivers
> being dynamically loaded at runtime. Since drivers were never meant to have
> a public API that was generally used, I believe the idea was that anyone
> using driver-specific APIs was required themselves to pass the driver
> explicitly to the linker. Otherwise everyone who does not use that driver
> could end up (depending on their linker flags) with a dependency on that
> unused driver. This change modifies that assumption and, while it makes it
> easier for those using driver-specific APIs, it does change how things have
> worked up till now.
>
> On my system using a default build, this adds 33 drivers to the list of
> libraries to link against when using pkg-config --libs.

But since these libraries are preceded by -Wl,--as-needed, only ones
that expose symbols that your binary uses will be linked. I don't think
it would change anything in the final result.

Also, this aligns with what the static build is doing: list all drivers
as well albeit with -Wl,--whole-archive and *without* -Wl,--as-needed.

What do you think?

-- 
Robin

# Do not try this at home.


  reply	other threads:[~2026-10-15 12:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 10:09 [PATCH dpdk 0/2] Fix dynamic link of driver symbols with pkgconf Robin Jarry
2026-10-15 10:09 ` [PATCH dpdk 1/2] meson: rename static drivers list Robin Jarry
2026-10-15 10:36   ` Bruce Richardson
2026-10-15 10:09 ` [PATCH dpdk 2/2] meson: add drivers to dynamic libraries Robin Jarry
2026-10-15 10:40   ` Bruce Richardson
2026-10-15 10:41 ` [PATCH dpdk 0/2] Fix dynamic link of driver symbols with pkgconf Bruce Richardson
2026-10-15 11:27   ` Robin Jarry
2026-10-15 11:26 ` [PATCH dpdk v2 " Robin Jarry
2026-10-15 11:26   ` [PATCH dpdk v2 1/2] meson: rename static drivers list Robin Jarry
2026-10-15 11:26   ` [PATCH dpdk v2 2/2] meson: add drivers to dynamic libraries Robin Jarry
2026-10-15 11:52     ` Bruce Richardson
2026-10-15 12:06       ` Robin Jarry [this message]
2026-10-15 12:18         ` Bruce Richardson
2026-10-15 14:47           ` Robin Jarry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5ED553NJLC.NBQ71EIJ8HFP@redhat.com \
    --to=rjarry@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.