From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Adrián García Casado" <adriangarciacasado42@gmail.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>
Cc: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
<bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Add __printf attribute to bpf_diag_source()
Date: Tue, 20 Oct 2026 00:35:50 +0000 [thread overview]
Message-ID: <DM98TFI010XS.5UZ5IEJBS2RQ@gmail.com> (raw)
In-Reply-To: <20261019195916.186225-1-adriangarciacasado42@gmail.com>
On Mon, Oct 19, 2026 at 12:59 PM Adrián García Casado <adriangarciacasado42@gmail.com> wrote:
> @@ -794,6 +794,7 @@ static void diag_print_insn_context(struct bpf_verifier_env *env, u32 insn_idx,
> }
> }
>
> +__printf(4, 5)
> static void bpf_diag_source(struct bpf_verifier_env *env, u32 insn_idx, const char *label,
> const char *fmt, ...)
1. This doesn't apply to bpf-next.
2. The warning was fixed a month ago:
commit 7f2b0b57a8d7 ("bpf: Add printf attributes").
pw-bot: cr
prev parent reply other threads:[~2026-10-20 0:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 19:59 [PATCH bpf-next] bpf: Add __printf attribute to bpf_diag_source() Adrián García Casado
2026-10-20 0:35 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM98TFI010XS.5UZ5IEJBS2RQ@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=adriangarciacasado42@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.