From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792482884; b=ZtsiAhEwt7hEvlocQSyXr3gj4XgdCWEQXg/Z5OxalvhIDE4PVs5p3oFVU9+7bgFp0Ajg dtYODfd+TafbjUYdTi+QFydpgBNfRSWLhXfHwDXYr9E3L8YFK0aey3EffhWBG047N+B1q f2iDKmY9y/dH1gDmvO8Vtb3RTReJl8Jif2O7OcHoMZbTlxmf0cJt4wjMR+Yp95A9HXwBu 4bVD4L8zoErFEtot0ae0JbhRcdPhthApQm3NEYjTmuIinel1b1cMemlwTGPZSy7+rdTEF eQ1jfy4pCuevYe0zd8UJTY3w3t6i0rzLQTfLrq6m0iJfLYFT5w99o57RGY3kxEZFmuw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792482884; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Mime-Version: Content-Transfer-Encoding:Content-Type:Date:Message-Id:From:To:Cc: Subject:X-Mailer:References:In-Reply-To:X-Last-TLS-Session-Version; bh=nhRD7+nxyHeCKS+xkeCWsLjCOGr/T5riYo2YwiC+rww=; b=nAq+3a73C+5y3B5G633tqyzi5KC2ozfbMDoBxSxFs+gxOqfPLlCks8GY8I5orSF8eWrY 3wKjhXfYO02fuipbHrKUWpAB8Mr6xC4NDZQdzQQerv9atemnJiHfTPGsrKfzegeP+Y9GZ bnq9sl4bBMt5SFLolSbKB3mZq9ZfLIjECba2k+86kx+qpgyB0UG4miyS8WG+0BRaKtfBO tPUqbPNRHBGkHlaMt42ynnueypCFAGL9OBMTisKGhf+MiU/Ed0jZpm9IO5BfewQwqlmre sII5TjvfkJ/+JzKlmT/liqLq2vubZd7jrMDS+Njsh1OhCq6beVCFyTq0vyTM47yhsoA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=1N3mKuZI; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2D3160A2603 for ; Tue, 20 Oct 2026 07:54:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D2D3160A2603 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=1N3mKuZI Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 4B8184E4128D; Tue, 20 Oct 2026 07:54:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 18B2E60393; Tue, 20 Oct 2026 07:54:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5448A10328D55; Tue, 20 Oct 2026 09:54:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1792482866; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=nhRD7+nxyHeCKS+xkeCWsLjCOGr/T5riYo2YwiC+rww=; b=1N3mKuZI0qxd6NRMVyevLU7abiuW3foNzamZpUF5nc0LMuS1ZOv15zGssSgmZXSG8Q1Zwa fMPrPkw1e9Uv15TxnfOzxDAVr7ostyN/wBesKDLV0V1qMabUTrwp6Ep9HPvr4WCC+wI+AH ppXavt/nePP1bqqMOLBqoxyt69GI3F8VzILWjAvgiRTLE++hJttq3Iftsj+LOyWoeJ8kQ0 aWpIy12aYFolytX6Vo1kKUGRHvQoohidPZv6mY8cyttHXb+ryIB24IgHFv6UlfZwCNsrC2 E6L1oUccqE0dEnQ7I6ilzrz/QmmCgw6mmnN2FyklD+7nP9xFEUqm5tfJHF/kkg== X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 20 Oct 2026 09:54:25 +0200 Message-Id: From: "Paul Louvel" To: "Tzung-Bi Shih" , "Paul Louvel" Cc: "Wim Van Sebroeck" , "Guenter Roeck" , , , "Thomas Petazzoni" Subject: Re: [PATCH v4 2/6] watchdog: w83627hf_wdt: Replace magic numbers with descriptive macros X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261013-w83627hf_wdt-improvements-v4-0-b6f6b60a9566@bootlin.com> <20261013-w83627hf_wdt-improvements-v4-2-b6f6b60a9566@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Mon Oct 19, 2026 at 5:22 PM CEST, Tzung-Bi Shih wrote: > On Tue, Oct 13, 2026 at 03:58:46PM +0200, Paul Louvel wrote: >> Raw hex values for Super I/O register addresses are difficult to >> understand >> without constantly consulting the datasheet. Use named macros instead. >> Also, replace macros value that contains bit position with the BIT() >> macro. >> Remove comments that doesn't help understanding the code. >>=20 >> Signed-off-by: Paul Louvel > > This looks good to me. Except for a weird line wrap in the commit messag= e, > > Reviewed-by: Tzung-Bi Shih ACK. Thanks, --=20 Paul Louvel, Bootlin Embedded Linux and Kernel engineering https://bootlin.com