All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: <jinwang.li@oss.qualcomm.com>,
	<openembedded-core@lists.openembedded.org>
Cc: <cheng.jiang@oss.qualcomm.com>, <quic_chezhou@quicinc.com>,
	<wei.deng@oss.qualcomm.com>, <shuai.zhang@oss.qualcomm.com>,
	<mengshi.wu@oss.qualcomm.com>, <xiuzhuo.shang@oss.qualcomm.com>
Subject: Re: [OE-core] [wrynose][PATCH 4/5] bluez5: Fix ABORT response being discarded
Date: Tue, 20 Oct 2026 09:57:46 +0200	[thread overview]
Message-ID: <DM9I7SSWHOKE.TOUEIMFGVMET@smile.fr> (raw)
In-Reply-To: <20261019082346.3287363-5-jinwang.li@oss.qualcomm.com>

On Mon Oct 19, 2026 at 10:23 AM CEST, Jinwang Li via lists.openembedded.org wrote:
> Send the ABORT response after transfer_complete(), since it clears
> the pending tx queue and was discarding the response first.
>
> Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
> ---
>  meta/recipes-connectivity/bluez5/bluez5.inc   |  1 +
>  ...x-Fix-ABORT-response-being-discarded.patch | 44 +++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index de9835e5a7..db650acdd0 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -79,6 +79,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
>             file://0001-avdtp-Fix-error-handling-for-AVDTP_OPEN-cmd.patch \
>             file://0001-avdtp-Fix-GET_CONFIGURATION-cmd.patch \
>             file://0001-avdtp-Return-correct-error-when-SEP-is-inuse.patch \
> +           file://0001-gobex-Fix-ABORT-response-being-discarded.patch \
>             "
>  S = "${UNPACKDIR}/bluez-${PV}"
>  
> diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
> new file mode 100644
> index 0000000000..5c0d7414ee
> --- /dev/null
> +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-gobex-Fix-ABORT-response-being-discarded.patch
> @@ -0,0 +1,44 @@
> +From 38a88cc433e0bc3cccb6dab126e484fc06ccd8bb Mon Sep 17 00:00:00 2001
> +From: Jinwang Li <jinwang.li@oss.qualcomm.com>
> +Date: Thu, 27 Aug 2026 16:36:51 +0800
> +Subject: [PATCH] gobex: Fix ABORT response being discarded
> +
> +g_obex_drop_tx_queue() in transfer_complete() clears any pending tx,
> +so the ABORT success response should be enqueued after transfer_complete().
> +
> +Fixes the following PTS test cases:
> +- OPP/SR/OPH/BV-27-I
> +- FTP/SR/OTR/BV-02-C
> +- PBAP/PSE/PDF/BV-06-I
> +- PBAP/PSE/PBF/BV-03-I
> +
> +Fixes: 7a35c12a6ceb ("gobex: Fix segfault caused by interrupted transfer")
> +Upstream-Status: Backport [https://github.com/bluez/bluez/commit/d094be10ff0cc9d48714d35557e0fd297f36f907]
> +Assisted-by: Claude:claude-sonnet-5
> +Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>

Hello,

Is that commit included in master and blacksail? If not, can you send
the needed upgrades/backports so I can merge this here?

Thanks!
-- 
Yoann Congal
Smile ECS


  reply	other threads:[~2026-10-20  7:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  8:23 [wrynose][PATCH 0/5] bluez5: fix AVDTP and OBEX issues Jinwang Li
2026-10-19  8:23 ` [wrynose][PATCH 1/5] bluez5: Fix error handling for AVDTP_OPEN cmd Jinwang Li
2026-10-20  7:55   ` [OE-core] " Yoann Congal
2026-10-19  8:23 ` [wrynose][PATCH 2/5] bluez5: Fix GET_CONFIGURATION cmd Jinwang Li
2026-10-20  7:55   ` [OE-core] " Yoann Congal
2026-10-19  8:23 ` [wrynose][PATCH 3/5] bluez5: Return correct error when SEP is inuse Jinwang Li
2026-10-20  7:56   ` [OE-core] " Yoann Congal
2026-10-19  8:23 ` [wrynose][PATCH 4/5] bluez5: Fix ABORT response being discarded Jinwang Li
2026-10-20  7:57   ` Yoann Congal [this message]
2026-10-19  8:23 ` [wrynose][PATCH 5/5] bluez5: Fix u128_to_string skipping data[4] Jinwang Li
2026-10-20  7:58   ` [OE-core] " Yoann Congal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM9I7SSWHOKE.TOUEIMFGVMET@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=cheng.jiang@oss.qualcomm.com \
    --cc=jinwang.li@oss.qualcomm.com \
    --cc=mengshi.wu@oss.qualcomm.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=quic_chezhou@quicinc.com \
    --cc=shuai.zhang@oss.qualcomm.com \
    --cc=wei.deng@oss.qualcomm.com \
    --cc=xiuzhuo.shang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.