From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <nora.schiffer@ew.tq-group.com>,
<openembedded-core@lists.openembedded.org>
Cc: <oss@ew.tq-group.com>
Subject: Re: [OE-core] [PATCH 2/2] sysvinit: rc: improve counting of progress steps
Date: Tue, 20 Oct 2026 15:57:47 +0200 [thread overview]
Message-ID: <DM9PVG0L0C8R.1FM7K9CJCQ1UU@bootlin.com> (raw)
In-Reply-To: <d3cf81007124c572c2010e785d421a0d2df9b619.1787734737.git.nora.schiffer@ew.tq-group.com>
On Wed Aug 26, 2026 at 11:00 AM CEST, Nora Schiffer via lists.openembedded.org wrote:
> Fix a number of issues that caused more steps to be counted than calls
> to startup_progress would happen in some situations, resulting in the
> progress bar never reaching 100%:
>
> - Use the same conditions when looping over initscripts for counting
> steps that are also used for running them
> - When skipping a script, run startup_progress to avoid off-by-one
>
> Signed-off-by: Nora Schiffer <nora.schiffer@ew.tq-group.com>
> ---
I was not able to reproduce the original issue of a progress bar never
reaching 100%, yet these changes are not breaking anything.
The code changes look sane.
So the whole patch looks good to me.
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-10-20 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 9:00 [PATCH 1/2] sysvinit: rc: fix inconsistent indentation Nora Schiffer
2026-08-26 9:00 ` [PATCH 2/2] sysvinit: rc: improve counting of progress steps Nora Schiffer
2026-10-20 13:57 ` Mathieu Dubois-Briand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM9PVG0L0C8R.1FM7K9CJCQ1UU@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=nora.schiffer@ew.tq-group.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=oss@ew.tq-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.