Re: [PATCH bpf-next v3] selftests/bpf: Run the enable_stats program with BPF_PROG_TEST_RUN

["Alexei Starovoitov" <alexei.starovoitov@gmail.com>]

On Mon Oct 19, 2026 at 2:57 AM UTC, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] selftests/bpf: deprecated CHECK() macro used in test_enable_stats()
> --
>
> commit 149e144806feffc72e780046d3d7759e157ee137
> Author: Qiliang Yuan <odys.yuan@gmail.com>
>
> selftests/bpf: Run the enable_stats program with BPF_PROG_TEST_RUN
>
> This commit replaces attaching the enable_stats BPF program to sys_enter
> with running it 1000 times via BPF_PROG_TEST_RUN so that concurrent
> syscalls on other CPUs do not race with reading run_cnt and count.
>
>> diff --git a/tools/testing/selftests/bpf/prog_tests/enable_stats.c b/tools/testing/selftests/bpf/prog_tests/enable_stats.c
>> index 75f85d0fe74a4..5b9cc119d072d 100644
>> --- a/tools/testing/selftests/bpf/prog_tests/enable_stats.c
>> +++ b/tools/testing/selftests/bpf/prog_tests/enable_stats.c
>> @@ -5,10 +5,11 @@
>>  void test_enable_stats(void)
>>  {
>>  	struct test_enable_stats *skel;
>> -	int stats_fd, err, prog_fd;
>> +	int stats_fd, err, prog_fd, i;
>>  	struct bpf_prog_info info;
>>  	__u32 info_len = sizeof(info);
>>  	int duration = 0;
>> +	LIBBPF_OPTS(bpf_test_run_opts, topts);
>>  
>>  	skel = test_enable_stats__open_and_load();
>>  	if (CHECK(!skel, "skel_open_and_load", "skeleton open/load failed\n"))
>> @@ -20,13 +21,15 @@ void test_enable_stats(void)
>>  		return;
>>  	}
>>  
>> -	err = test_enable_stats__attach(skel);
>> -	if (CHECK(err, "attach_raw_tp", "err %d\n", err))
>> +	prog_fd = bpf_program__fd(skel->progs.test_enable_stats);
>> +	for (i = 0; i < 1000; i++) {
>> +		err = bpf_prog_test_run_opts(prog_fd, &topts);
>> +		if (err)
>> +			break;
>> +	}
>> +	if (CHECK(err, "test_run", "err %d\n", err))
>>  		goto cleanup;
>
> [Severity: Low]
> Since CHECK() is deprecated in BPF selftests, should this new check in
> test_enable_stats() (and perhaps the surrounding checks in this function)
> use ASSERT_OK(err, "test_run") instead?

bot is correct.

pw-bot: cr