From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Dudu Lu" <phx0fer@gmail.com>, <john.fastabend@gmail.com>,
<jakub@cloudflare.com>, <jiayuan.chen@linux.dev>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf] bpf, sockmap: use READ_ONCE/WRITE_ONCE for saved_data_ready in the verdict path
Date: Wed, 21 Oct 2026 16:45:10 +0000 [thread overview]
Message-ID: <DMAO25C5MTPO.1PS8C0R1D0KP2@gmail.com> (raw)
In-Reply-To: <20261021155629.68813-1-phx0fer@gmail.com>
On Wed, Oct 21, 2026 at 08:56 AM Dudu Lu <phx0fer@gmail.com> wrote:
> sk_psock_stop_strp() uses WRITE_ONCE for the same field. sock_map_link()
> / sock_map_unref() touch the same psock from another CPU without the
> lock, so KCSAN reports the race:
>
> BUG: KCSAN: data-race in sock_map_link / sock_map_unref
> BUG: KCSAN: data-race in sk_psock_start_verdict / sock_map_unref
sashiko is right. KCSAN will print both with this patch applied.
pw-bot: cr
next prev parent reply other threads:[~2026-10-21 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 15:56 [PATCH bpf] bpf, sockmap: use READ_ONCE/WRITE_ONCE for saved_data_ready in the verdict path Dudu Lu
2026-10-21 16:10 ` sashiko-bot
2026-10-21 16:37 ` bot+bpf-ci
2026-10-21 16:45 ` Alexei Starovoitov [this message]
2026-10-21 20:30 ` Jakub Sitnicki
2026-10-22 3:37 ` Jiayuan Chen
2026-10-22 5:48 ` [PATCH bpf v2] bpf, sockmap: annotate the psock teardown data races Dudu Lu
2026-10-22 15:40 ` Alexei Starovoitov
2026-10-23 18:49 ` Jakub Sitnicki
2026-10-23 18:53 ` Alexei Starovoitov
2026-10-26 12:33 ` Jakub Sitnicki
2026-10-27 5:10 ` phx
2026-10-27 16:33 ` Jakub Sitnicki
2026-10-27 16:46 ` Alexei Starovoitov
2026-10-27 17:34 ` Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMAO25C5MTPO.1PS8C0R1D0KP2@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jakub@cloudflare.com \
--cc=jiayuan.chen@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phx0fer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.