Re: [OE-core] [PATCH] lrzsz: upgrade 0.12.20 -> 0.13.1

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Wed Oct 21, 2026 at 2:38 PM CEST, Jaipaul Cheernam wrote:
> ChangeLog: https://github.com/UweOhse/lrzsz/blob/release_0.13.1/ChangeLog
>
> Version 0.13.1 - October 2026, Uwe Ohse
> In this release one recently implemented feature (ESC8 - high bit escaping) was removed
> after Stephen Hurd (of zmtx-zmrx) informed me about its incompatibility.
> A list of known incompatibilities between the 0.12 and the 0.13 series exists.
>
> NEWS: https://www.ohse.de/uwe/software/lrzsz/NEWS-0.13.0.html
>
> Upstream resumed activity and released 0.13.1, the first release in
> decades. It incorporates equivalents of all the fixes carried locally,
> so the full patch stack is dropped:
>
> - Drop autotools-update/autotools/makefile/lrzsz-check-locale.h patches
>   Upstream reworked the autotools/gettext setup (external gettext,
>   configure.ac, intl/ and ansi2knr removed).
> - Drop cve-2018-10195.patch
>   zsdata() integer overflow is fixed upstream.
> - Drop include/0001-Fix-build-with-GCC-15/K&R-to-ANSI patches
>   Targeted the lib/ tree and K&R prototypes that no longer exist;
>   src/lsyslog.c already carries the added includes.
> - Drop 0001-Fix-cross-compilation-using-autoconf-detected-AR.patch
>   No static archive is built any more, so no host 'ar' is invoked.
>
> Also drop the -Wno-error=incompatible-pointer-types workaround as the
> src/tcp.c it covered was removed upstream.
>
> Tested on qemux86-64: builds under -Werror -std=c23, passes package QA,
> and upstream 'make vcheck' passes the zmodem/ymodem/xmodem transfer and
> traversal/restricted-mode tests.
>
> Signed-off-by: Jaipaul Cheernam <jaipaul.cheernam@est.tech>
> ---

Hi Jaipaul,

We can see some failures, only on x86 builds:

ERROR: lib32-lrzsz-0.13.1-r0 do_compile: Execution of '/srv/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/x86-pokymllib32-linux/lib32-lrzsz/0.13.1/temp/run.do_compile.3925122' failed with exit code 1
...
| ../../sources/lrzsz-0.13.1/src/linesimulator.c: In function 'xorshift64':
| ../../sources/lrzsz-0.13.1/src/linesimulator.c:126:13: error: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '11400714819323198485' to '2135587861' [-Werror=overflow]
|   126 |         x = 0x9E3779B97F4A7C15UL;
|       |             ^~~~~~~~~~~~~~~~~~~~
| ../../sources/lrzsz-0.13.1/src/linesimulator.c: In function 'es_seed':
| ../../sources/lrzsz-0.13.1/src/linesimulator.c:344:19: error: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '11400714819323198485' to '2135587861' [-Werror=overflow]
|   344 |         es->rng = 0x9E3779B97F4A7C15UL;
|       |                   ^~~~~~~~~~~~~~~~~~~~
| cc1: all warnings being treated as errors
| make[2]: *** [Makefile:491: linesimulator.o] Error 1
| make[2]: *** Waiting for unfinished jobs....
| make[2]: Leaving directory '/srv/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/x86-pokymllib32-linux/lib32-lrzsz/0.13.1/build/src'
| make[1]: *** [Makefile:434: all-recursive] Error 1
| make[1]: Leaving directory '/srv/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/x86-pokymllib32-linux/lib32-lrzsz/0.13.1/build'
| make: *** [Makefile:373: all] Error 2
| ERROR: oe_runmake failed

https://autobuilder.yoctoproject.org/valkyrie/#/builders/59/builds/4892
https://autobuilder.yoctoproject.org/valkyrie/#/builders/6/builds/4888
https://autobuilder.yoctoproject.org/valkyrie/#/builders/17/builds/4717
https://autobuilder.yoctoproject.org/valkyrie/#/builders/19/builds/4861
https://autobuilder.yoctoproject.org/valkyrie/#/builders/65/builds/4833

Can you have a look at the issue?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com