From: "Abdurrahman Hussain" <abdurrahman@nexthop.ai>
To: "Abdurrahman Hussain" <abdurrahman@nexthop.ai>,
"Guenter Roeck" <linux@roeck-us.net>,
<sashiko-reviews@lists.linux.dev>
Cc: <devicetree@vger.kernel.org>, <linux-hwmon@vger.kernel.org>,
<robh@kernel.org>, <conor+dt@kernel.org>,
"Guenter Roeck" <groeck7@gmail.com>
Subject: Re: [PATCH v2 3/4] hwmon: (pmbus_core) Support relative encoding of vout related commands
Date: Wed, 21 Oct 2026 13:04:37 -0700 [thread overview]
Message-ID: <DMASAV68R9CA.GRPDV6UG4MEU@nexthop.ai> (raw)
In-Reply-To: <DM9W9SZZV7OK.33TH12KSMSBQS@nexthop.ai>
On Tue Oct 20, 2026 at 11:58 AM PDT, Abdurrahman Hussain wrote:
> On Tue Oct 20, 2026 at 8:37 AM PDT, Guenter Roeck wrote:
>> On 10/20/26 01:55, sashiko-bot@kernel.org wrote:
>>> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>>> - [High] hwmon: (pmbus_core) divide-by-zero after pmbus_regulator_set_voltage()
>>> - [Medium] hwmon: (pmbus_core) broken relative VOUT margin handling in regulator ops
>>> --
>>
>> Good that I did not just apply this patch. Do you have time to look into
>> those issues and fix them ?
>>
>
> Looking into it,
>
> Thanks,
> Abdurrahman
Addressed all sashiko comments in v4.
Thanks,
Abdurrahman
next prev parent reply other threads:[~2026-10-21 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 7:43 [PATCH v2 0/4] hwmon: (pmbus) Support relative VOUT mode, add TDK FS1412 and FS1525 Abdurrahman Hussain
2026-10-20 7:43 ` [PATCH v2 1/4] dt-bindings: vendor-prefixes: Add TDK Corporation Abdurrahman Hussain
2026-10-20 8:39 ` sashiko-bot
2026-10-20 7:43 ` [PATCH v2 2/4] dt-bindings: trivial-devices: Add TDK FS1412 and FS1525 Abdurrahman Hussain
2026-10-20 8:40 ` sashiko-bot
2026-10-20 7:43 ` [PATCH v2 3/4] hwmon: (pmbus_core) Support relative encoding of vout related commands Abdurrahman Hussain
2026-10-20 8:55 ` sashiko-bot
2026-10-20 15:37 ` Guenter Roeck
2026-10-20 18:58 ` Abdurrahman Hussain
2026-10-21 20:04 ` Abdurrahman Hussain [this message]
2026-10-21 21:41 ` Guenter Roeck
2026-10-21 21:58 ` Abdurrahman Hussain
2026-10-20 7:43 ` [PATCH v2 4/4] hwmon: (pmbus/fs1412) Add TDK FS1412 and FS1525 driver Abdurrahman Hussain
2026-10-20 8:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMASAV68R9CA.GRPDV6UG4MEU@nexthop.ai \
--to=abdurrahman@nexthop.ai \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=groeck7@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.