From: "Michael Walle" <mwalle@kernel.org>
To: "Shuai Liu" <847807867@qq.com>, <linux-mtd@lists.infradead.org>
Cc: <pratyush@kernel.org>, <takahiro.kuwano@infineon.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: fix missing space after comma in legacy flash names
Date: Fri, 23 Oct 2026 11:30:52 +0200 [thread overview]
Message-ID: <DMC42PZGE0L9.25VCSYHXHMN9L@kernel.org> (raw)
In-Reply-To: <tencent_760494FBADB4184B967C5A93312EB198F506@qq.com>
[-- Attachment #1.1: Type: text/plain, Size: 1401 bytes --]
On Fri Oct 23, 2026 at 11:24 AM CEST, Shuai Liu wrote:
> Add the missing space between string literals in the legacy
> flash_info entries. Cosmetic only, no functional change; silences
> checkpatch ERRORs on these lines.
>
> Signed-off-by: Shuai Liu <847807867@qq.com>
> ---
> drivers/mtd/spi-nor/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 8bc117b46..31cba60bd 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3898,11 +3898,11 @@ static const struct spi_device_id spi_nor_dev_ids[] = {
> */
> {"at25df321a"}, {"at25df641"}, {"at26df081a"},
> {"mx25l4005a"}, {"mx25l1606e"}, {"mx25l6405d"}, {"mx25l12805d"},
> - {"mx25l25635e"},{"mx66l51235l"},
> + {"mx25l25635e"}, {"mx66l51235l"},
> {"n25q064"}, {"n25q128a11"}, {"n25q128a13"}, {"n25q512a"},
> {"s25fl256s1"}, {"s25fl512s"}, {"s25sl12801"}, {"s25fl008k"},
> {"s25fl064k"},
> - {"sst25vf040b"},{"sst25vf016b"},{"sst25vf032b"},{"sst25wf040"},
> + {"sst25vf040b"}, {"sst25vf016b"}, {"sst25vf032b"}, {"sst25wf040"},
> {"m25p40"}, {"m25p80"}, {"m25p16"}, {"m25p32"},
> {"m25p64"}, {"m25p128"},
> {"w25x80"}, {"w25x32"}, {"w25q32"}, {"w25q32dw"},
Well, that is because they are aligned with all the other entries.
IMHO this is just unneeded code churn.
-michael
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-10-23 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 9:24 [PATCH] mtd: spi-nor: fix missing space after comma in legacy flash names Shuai Liu
2026-10-23 9:30 ` Michael Walle [this message]
[not found] <20261023092444.3969022-1-847807867@qq.com>
2026-10-23 9:39 ` Shuai Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMC42PZGE0L9.25VCSYHXHMN9L@kernel.org \
--to=mwalle@kernel.org \
--cc=847807867@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pratyush@kernel.org \
--cc=takahiro.kuwano@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.