All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noam D. Eliyahu" <noam.d.eliyahu@gmail.com>
To: "Pavan Chebbi" <pavan.chebbi@broadcom.com>
Cc: <mchan@broadcom.com>, <netdev@vger.kernel.org>,
	"George Shuklin" <george.shuklin@gmail.com>,
	"Lenny Szubowicz" <lszubowi@redhat.com>,
	"Michael Chan" <michael.chan@broadcom.com>
Subject: Re: [DISCUSS] tg3 reboot handling on Dell T440 (BCM5720)
Date: Fri, 23 Oct 2026 18:43:25 +0300	[thread overview]
Message-ID: <DMCBZ8FR2UYP.2G9NV2OYGYYOD@pve> (raw)
In-Reply-To: <CALs4sv2Fua=QqutN01raaUojNxJr+jrUshQ+riLZAMPKKhCv9A@mail.gmail.com>

Hi Pavan,

Thanks for circling back on this!

On Fri Oct 23, 2026 at 6:40 AM IDT, Pavan Chebbi wrote:
> We haven't heard back from Lenny but I think this solution should work.

While waiting to hear back, I worked around this locally across my environments with a custom kernel. I also shared the solution in a few Reddit threads and received positive feedback from others hitting the exact same behavior. After getting things working locally, pushing it upstream slipped off my radar.

> Hello Noam, bumping up this old discussion... do you want to submit a
> patch for this?

I would be happy to submit the patch.
Locally, I had taken the quick path and stripped out the code in question, but for the upstream patch I will implement the proper approach we discussed: keeping the DMI table to guard the conditional tg3_power_down (restricted only to models where the original issue was observed, e.g., R650xs) and dropping the AER handling entirely.

I'll adapt my patch to this logic and test it across different firmware versions over the weekend to make sure everything behaves as expected due to the date gap between then and now.

As this is my first kernel submission, could you point me to any recommended guides or things to know before submitting the patch?

I know about:
- https://docs.kernel.org/process/submitting-patches.html
- https://docs.kernel.org/process/maintainer-netdev.html

Thanks again,
Noam

  reply	other threads:[~2026-10-23 15:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-21 17:50 [DISCUSS] tg3 reboot handling on Dell T440 (BCM5720) Noam D. Eliyahu
2025-12-22  5:53 ` Pavan Chebbi
2025-12-24 16:53   ` Noam D. Eliyahu
2025-12-31 15:10     ` Pavan Chebbi
2026-01-02 16:22       ` Noam D. Eliyahu
2026-10-23  3:40         ` Pavan Chebbi
2026-10-23 15:43           ` Noam D. Eliyahu [this message]
2026-10-24  4:51             ` Pavan Chebbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMCBZ8FR2UYP.2G9NV2OYGYYOD@pve \
    --to=noam.d.eliyahu@gmail.com \
    --cc=george.shuklin@gmail.com \
    --cc=lszubowi@redhat.com \
    --cc=mchan@broadcom.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.