From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793208334; b=y4XG0UxSQcEUtdK9/AsZd7FwmKkGRZSknxSCTd9sRkt3G7/OAEPuepQ+hvil9IINt3su /4jPDEdKiAXqDATbm+iRgXYSv1YMciCcCWyM9NLm5jyTvr3DmLmU0SJ/4Tr07kUTry+Nc sGwsICGBchuM9w6g+GZck7MEvnZRsBbnTlUjUXIAr+Uxb0SOlqEubKCoS6taVN1nUZz3S i/Vbzn6s9XDe47e6HFbS0EtMnhsmnuQs5EUKAQULSqMZTttex+Xyo73SEvTDVZXrMRMS3 nHzXKXYzENEaDBhpNUMoaBqN5GXCn8zhztSs4p/zN2BOIVpr4emnux1AcR2OKM7f67g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793208334; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Content-Type:Date:Message-Id:Subject:From:To:Cc:In-Reply-To: References:Content-Transfer-Encoding:MIME-Version; bh=XLYiEepDtnyQ6wJ1rlYe5RaJc/i8ARvs/UjwaNMVQRE=; b=lbPcptbHYdlP/gMCavGZpB/Sik6XvYmEp32WW+Md9/HdVJ9TuxGWhiolIIUI2xBEXx2w OGGBbNsAyDRGpPNrJtv0QmAFMpmOQBtAe0ZRya7oKTerqjxjl6eAp3PP70+3CmYYye3PF emA3zboYUhWHnrUlg6nVaKothVqaD0jIaJYdhqGPCtOCdhZRwRaM/usj4RgQoJFQ04SLn xosI8xpFbO6Th03E/g1LjJ0gVEp//NP6Am28NbLvNljqDyyNZWdR/9Em3WxzhF96H94OX MHO6vQLfSHbVVSw1YgMj/pvS1+TsBsk8yfsACj7tCsr4cktt0D8gHsOd1T05Qwn27zg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Af7y52Ro; arc=none smtp.remote-ip=209.85.216.54 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC25606A31D for ; Wed, 28 Oct 2026 17:25:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DEC25606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Af7y52Ro Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3acd21ba21aso1066228a91.1 for ; Wed, 28 Oct 2026 10:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793208333; x=1793813133; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:references:in-reply-to:cc:to :from:subject:message-id:date:content-type:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XLYiEepDtnyQ6wJ1rlYe5RaJc/i8ARvs/UjwaNMVQRE=; b=Af7y52RoNQXZRESfNzlA5nWU7zYO0dfLPezS+5rNH3Tx4+4DsnOMyhABRaQvfQPhli WGDEJ6zWLk88idrS1IRmCJxUBASFuuPGGngNzQZZ7LzmANcSte3aAEFKuC2VjHtOK2z7 yjKMj+n+y7innZ39T/IQMUNxUrOFGpd7ZgkibuW592Y5ybQz3HYIMsH9Gk9Vo/7F25Aa q36OaknOzdG878FRgHSj5M2t3J2VawgIYj7j4isik5KORWNcsNhJEboFyrcCLGCCUvS1 gSvujDxwZjfi6G+bKCVFt8XzBT2Fk2cA1mp2Ztj8lzO/DQBvE/UHm9uoMPtJq1mQY/nw HIEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793208333; x=1793813133; h=mime-version:content-transfer-encoding:references:in-reply-to:cc:to :from:subject:message-id:date:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XLYiEepDtnyQ6wJ1rlYe5RaJc/i8ARvs/UjwaNMVQRE=; b=fX6bREoj9J3uNtPi1BA1AXF5MOXCVW+lCeWs+gqBNKlcno0lCb36L89gvo+ewnPlZM YfzaQbt49YPg6ug993INSF7UO9YLF60YI7tkoB0DVqqEY0D/zuIkwncX55i51lHauntM b7/CgQ3BVijL4M4ZharP8u3mKN0uVA6W9WWHQYFE1oiTNaFrXeNjlDgC+C8DFc2Z/1mZ ILQXcNuINfkN1t0Ce5cjxgye+q/rUEyPRDbob0+MCmsoamiiD7P5VCV51Ca3N/ltxlET G2bPfrn47DCmIHXJabOlQjXedt/CQ4zLHHS5r7FLJKCCVRb9LI51QzFFkzvdC4So6CpO T0Cw== X-Forwarded-Encrypted: i=1; AKwUvBzYF5qitFL2wDfzm3L/ngvJssoWxbCcyaX1PA62kBBaVFVxizRKo9ac6/I5uAdlEqzNopA=@vger.kernel.org X-Gm-Message-State: AFq9FYIxnRQyHuD3/Ot4EJdbbcg0w+bipCGqnKSmFz7KzRYeTh4AH4x5 Y5+KKRpWtiJ+oU5p0ae4ZUfkD4QAG7J9hih6nbgOlbh0lyBaL95OfVoT X-Gm-Gg: AYBFou0CDsXJK61YAnxnca0MWencvT2L+CGCWgIsv5vkF/wk1ccV7+IrXWMsjiEIsnd g9fPfRh2dSomZzOrnvaNNb219EALL7ga7lTufgCMGM6EG/GtD223vL4eyLvaWVWEqBm8X/wTFnA yXqZv8x/f+xpLuVYuVPb1buiBK7wZg1hxuPOtCClbyDc1gERgB8Fl3lH2jPnxPf607cKBoJgYpT V8vwplswWSQrSCo0qyfUKTX3+36OaYvmgc1ZXFt5ss+Dr0lLNPbrvE0l+PzAm948OhPzMEVoPkf wpyJpx3cVb5QDGwCzCOAfZHol1yf7TzePhKExqEizMnJZKwrapYuZcSDawPYHkLiNrKKLvsMJnK ouxzIoHt4P8Nl4Inw+dHPW4VrNujh7pp8OlSaq7nKhlM92dPwF5OdSKMehFWNN75+gh17SYt5xW KEh98ScAOspqjA7XMEQ3kQCw19E6Um/8Ag8N1/z9S8uTYPEAQINlcgF+Uz3/wncxZz1N+uGdHIt JW447l7Zc07j8QoAUyMp8vXHkMnHLbFp8f2uN4403S3132Wnoq49k7ykP5LFQjsKGgoJ1n/aIF4 T/94KUBksoaaVw7IZyHVcMhddCsdkRwdZQsGGxDbRyBjXwQ9Q7+U0RJF9XsGlmgOhKW26ZS7TmA rQQa/jddcTHok3Mb3irzzADYb6wFDMShX9A== X-Received: by 2002:a17:90b:3a46:b0:3aa:fdad:7d6e with SMTP id 98e67ed59e1d1-3ae581b7b3fmr2290113a91.10.1793208333116; Wed, 28 Oct 2026 10:25:33 -0700 (PDT) Received: from localhost ([153.61.198.248]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae6e9583c1sm397200a91.10.2026.10.28.10.25.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2026 10:25:32 -0700 (PDT) Content-Type: text/plain; charset=UTF-8 Date: Wed, 28 Oct 2026 17:25:31 +0000 Message-Id: Subject: Re: [PATCH RFC 0/8] vsock: add datagram support to virtio and vhost From: "Alexei Starovoitov" To: "Sergio Lopez" , "Stefano Garzarella" , "Bobby Eshleman" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Bryan Tan" , "Vishnu Dasa" , "Broadcom internal kernel review list" , "Stefan Hajnoczi" , "Michael S. Tsirkin" , "Jason Wang" , =?utf-8?q?Eugenio_P=C3=A9rez?= , "Xuan Zhuo" , "Haiyang Zhang" , "Wei Liu" , "Dexuan Cui" Cc: , , , , , In-Reply-To: <20261028-vsock-dgram-support-v1-0-e457cf7cee78@sinrega.org> References: <20261028-vsock-dgram-support-v1-0-e457cf7cee78@sinrega.org> Content-Transfer-Encoding: 8bit X-Mailing-List: bpf@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Wed, Oct 28, 2026 at 09:04 AM Sergio Lopez wrote: > This series implements SOCK_DGRAM support for virtio-vsock and > vhost-vsock, allowing applications to exchange connectionless messages > through the existing AF_VSOCK datagram API. The cover doesn't say who needs it. Bobby and Amery took the same feature to v6: https://lore.kernel.org/all/20240710212555.1617795-1-amery.hung@bytedance.com/ Stefano said there that it can work well and that the virtio spec change is the next step. The last mails of the thread have Amery's v7 WIP and a short list of what is left. The cover doesn't mention it. The spec change is still missing. Why not finish v7 instead ? This RFC goes the other way in these places: what v6 this RFC ----------------- ------------------------ ---------------------------- (cid, port) space own bind table for dgram shared with stream. The 2nd bind() gets EADDRINUSE vsk->transport empty until connect(), g2h or h2g, picked in lookup per packet socket(). -ENODEV with vsock_loopback only routing one helper for stream 2nd copy of the chain in and dgram vsock_assign_transport() recvmsg() in af_vsock.c, dgram_dequeue() stays, no dgram_dequeue() dgram_payload_len() is new VMCI fallback first. No virtio dgram when its module is loaded dgram > RX buffer drop, EHOSTUNREACH in every RX buffer is 64K the error queue > Datagrams use destination-based routing across guest-to-host, > host-to-guest and loopback transports while retaining the socket's > transport state. VMCI keeps priority as the dedicated datagram A dgram socket uses two members of struct virtio_vsock_sock: tx_lock and bytes_unsent. They serve SIOCOUTQ only. virtio_transport_alloc_skb() does skb_set_owner_w() already. udp_ioctl() returns sk_wmem_alloc_get() for SIOCOUTQ. Without them a dgram socket has no transport state, like in v6. Then no need for the owner transport, dgram_transport_match(), fallback_transport, tx_accounted, the skb destructor, etc. > transport. Guest RX buffers accommodate complete messages when > datagrams are negotiated, preserving message boundaries. That's 64K per RX buffer instead of 4K, for stream and seqpacket too. It undoes commit 03a92f036a04 ("vsock/virtio: Resize receive buffers so that each SKB fits in a 4K page"). pskb_trim_unique() doesn't reduce skb->truesize. So a datagram of 1 byte charges more than 64K to sk_rmem_alloc of the guest socket. The default sk_rcvbuf is about 208K on x86-64. The 5th datagram in the queue is dropped.